Re: [PATCH] Add info about stats report when a reload is done in management.txt

2017-10-05 Thread Lukas Tribus
Hello Ricardo,


Am 05.10.2017 um 09:47 schrieb Ricardo Fraile:
> +Note that when a "restart" is doing, the new process have the listening ports
> +but the old process continue with the existing connections until they close.
> +All the active connections that the old process did are still working but not
> +reported in the statistics, which are only reported from the new process.

This is actually wrong. You probably got this from my erroneous first response 
in
the other thread:
"Haproxy refuses new connections when doing a reload followed by a restart"

Actually a restart kills existing connections and makes haproxy quit 
immediately.

Also read the initial 2 paragraphs in section 4 of the management doc:
https://cbonte.github.io/haproxy-dconv/1.7/management.html#4



Regards,
Lukas




[PATCH] Add info about stats report when a reload is done in management.txt

2017-10-05 Thread Ricardo Fraile
Hi,


It's interesting to have in the section "4. Stopping and restarting
HAProxy" in the management.txt document some information related to the
behaviour of the stats when a restart is done.

As suggestion, here is my patch.



Thanks,
Ricardo F.
diff --git a/doc/management.txt b/doc/management.txt
index dd886de..2d7f2c4 100644
--- a/doc/management.txt
+++ b/doc/management.txt
@@ -484,6 +484,11 @@ don't have enough load to trigger the race conditions. And for most high traffic
 users, the failure rate is still fairly within the noise margin provided that at
 least SO_REUSEPORT is properly supported on their systems.
 
+Note that when a "restart" is doing, the new process have the listening ports 
+but the old process continue with the existing connections until they close. 
+All the active connections that the old process did are still working but not 
+reported in the statistics, which are only reported from the new process.
+
 
 5. File-descriptor limitations
 --