Re: [PATCH] CLEANUP: contrib/prometheus-exporter: typo fixes for ssl reuse metric

[Willy Tarreau]

Hi William,

On Wed, Dec 16, 2020 at 12:52:57PM +0100, William Dauchy wrote:
> Hi Willy
> 
> On Tue, Jul 7, 2020 at 11:17 PM Willy Tarreau  wrote:
> > On Tue, Jul 07, 2020 at 07:14:08PM +0200, Pierre Cheynier wrote:
> > > A typo I identified while having a look to our metric inventory.
> >
> > Thank you, now merged.
> 
> Do you think that's something we could backport to v2.x to make it
> coherent across versions?

Sure, it makes sense! I guess it was skipped because it was tagged
as a cleanup but in fact it fixes a real bug since the output metric
name was fixed. I backported it to 2.2 right now so it's in the pipe
now :-)

Thanks,
Willy

Re: [PATCH] CLEANUP: contrib/prometheus-exporter: typo fixes for ssl reuse metric

[William Dauchy]

Hi Willy

On Tue, Jul 7, 2020 at 11:17 PM Willy Tarreau  wrote:
> On Tue, Jul 07, 2020 at 07:14:08PM +0200, Pierre Cheynier wrote:
> > A typo I identified while having a look to our metric inventory.
>
> Thank you, now merged.

Do you think that's something we could backport to v2.x to make it
coherent across versions?

Thanks,
-- 
William

Re: [PATCH] CLEANUP: contrib/prometheus-exporter: typo fixes for ssl reuse metric

[Willy Tarreau]

Hi Pierre,

On Tue, Jul 07, 2020 at 07:14:08PM +0200, Pierre Cheynier wrote:
> A typo I identified while having a look to our metric inventory.

Thank you, now merged.

Willy

[PATCH] CLEANUP: contrib/prometheus-exporter: typo fixes for ssl reuse metric

[Pierre Cheynier]

A typo I identified while having a look to our metric inventory.

---
 contrib/prometheus-exporter/README   | 2 +-
 contrib/prometheus-exporter/service-prometheus.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/prometheus-exporter/README 
b/contrib/prometheus-exporter/README
index 1c5a99241..a1b9e269c 100644
--- a/contrib/prometheus-exporter/README
+++ b/contrib/prometheus-exporter/README
@@ -122,7 +122,7 @@ Exported metrics
 | haproxy_process_max_ssl_rate   | Maximum observed number of 
SSL sessions per second.   |
 | haproxy_process_current_frontend_ssl_key_rate  | Current frontend SSL Key 
computation per second over last elapsed second. |
 | haproxy_process_max_frontend_ssl_key_rate  | Maximum observed frontend 
SSL Key computation per second. |
-| haproxy_process_frontent_ssl_reuse | SSL session reuse ratio 
(percent).|
+| haproxy_process_frontend_ssl_reuse | SSL session reuse ratio 
(percent).|
 | haproxy_process_current_backend_ssl_key_rate   | Current backend SSL Key 
computation per second over last elapsed second.  |
 | haproxy_process_max_backend_ssl_key_rate   | Maximum observed backend 
SSL Key computation per second.  |
 | haproxy_process_ssl_cache_lookups_total| Total number of SSL session 
cache lookups.|
diff --git a/contrib/prometheus-exporter/service-prometheus.c 
b/contrib/prometheus-exporter/service-prometheus.c
index 952558c70..009e817ae 100644
--- a/contrib/prometheus-exporter/service-prometheus.c
+++ b/contrib/prometheus-exporter/service-prometheus.c
@@ -485,7 +485,7 @@ const struct ist promex_inf_metric_names[INF_TOTAL_FIELDS] 
= {
[INF_MAX_SSL_RATE]   = IST("max_ssl_rate"),
[INF_SSL_FRONTEND_KEY_RATE]  = 
IST("current_frontend_ssl_key_rate"),
[INF_SSL_FRONTEND_MAX_KEY_RATE]  = IST("max_frontend_ssl_key_rate"),
-   [INF_SSL_FRONTEND_SESSION_REUSE_PCT] = IST("frontent_ssl_reuse"),
+   [INF_SSL_FRONTEND_SESSION_REUSE_PCT] = IST("frontend_ssl_reuse"),
[INF_SSL_BACKEND_KEY_RATE]   = 
IST("current_backend_ssl_key_rate"),
[INF_SSL_BACKEND_MAX_KEY_RATE]   = IST("max_backend_ssl_key_rate"),
[INF_SSL_CACHE_LOOKUPS]  = IST("ssl_cache_lookups_total"),
-- 
2.27.0