Re: [PATCH] Fix dumping of stick table entries for k/v pairs.
Le 07/05/2020 à 15:27, Adis Nezirovic a écrit : On 5/7/20 2:44 PM, William Lallemand wrote: On Thu, May 07, 2020 at 02:39:30PM +0200, Christopher Faulet wrote: Sorry for the delay and thanks for the reminder. I don't really know how stick table works internally. But you should probably test the dict_entry pointer is not NULL before accessing its value. It is how it is done in stable_dump_entry_to_buffer(). If it ok for you, I can amend the commit to do the same. Let me know. Ah yes, that's obvious, please amend, I was trimming "unecessary" temporary variables, and was left only with unguarded typecast :-) Also, it should probably be tagged 'BUG/MEDIUM' instead of 'MEDIUM' This one too, it is clearly a bug which causes user script in Lua to fail during StickTable:dump() (and similar) Merges now. Thanks ! -- Christopher Faulet
Re: [PATCH] Fix dumping of stick table entries for k/v pairs.
On 5/7/20 2:44 PM, William Lallemand wrote: On Thu, May 07, 2020 at 02:39:30PM +0200, Christopher Faulet wrote: Sorry for the delay and thanks for the reminder. I don't really know how stick table works internally. But you should probably test the dict_entry pointer is not NULL before accessing its value. It is how it is done in stable_dump_entry_to_buffer(). If it ok for you, I can amend the commit to do the same. Let me know. Ah yes, that's obvious, please amend, I was trimming "unecessary" temporary variables, and was left only with unguarded typecast :-) Also, it should probably be tagged 'BUG/MEDIUM' instead of 'MEDIUM' This one too, it is clearly a bug which causes user script in Lua to fail during StickTable:dump() (and similar) Best regards, -- Adis Nezirovic Software Engineer HAProxy Technologies - Powering your uptime! 375 Totten Pond Road, Suite 302 | Waltham, MA 02451, US +1 (844) 222-4340 | https://www.haproxy.com
Re: [PATCH] Fix dumping of stick table entries for k/v pairs.
On Thu, May 07, 2020 at 02:39:30PM +0200, Christopher Faulet wrote: > Le 07/05/2020 à 12:17, Adis Nezirovic a écrit : > > Hello guys, any comments on the patch? > > > > Bump, adding Thierry to the conversation. > > > > > > Best regards, > > > > Hi Adis, > > Sorry for the delay and thanks for the reminder. I don't really know how > stick > table works internally. But you should probably test the dict_entry pointer > is > not NULL before accessing its value. It is how it is done in > stable_dump_entry_to_buffer(). If it ok for you, I can amend the commit to do > the same. Let me know. > Hi, Also, it should probably be tagged 'BUG/MEDIUM' instead of 'MEDIUM' -- William Lallemand
Re: [PATCH] Fix dumping of stick table entries for k/v pairs.
Le 07/05/2020 à 12:17, Adis Nezirovic a écrit : Hello guys, any comments on the patch? Bump, adding Thierry to the conversation. Best regards, Hi Adis, Sorry for the delay and thanks for the reminder. I don't really know how stick table works internally. But you should probably test the dict_entry pointer is not NULL before accessing its value. It is how it is done in stable_dump_entry_to_buffer(). If it ok for you, I can amend the commit to do the same. Let me know. -- Christopher Faulet
Re: [PATCH] Fix dumping of stick table entries for k/v pairs.
Hello guys, any comments on the patch? Bump, adding Thierry to the conversation. Best regards, -- Adis Nezirovic Software Engineer HAProxy Technologies - Powering your uptime! 375 Totten Pond Road, Suite 302 | Waltham, MA 02451, US +1 (844) 222-4340 | https://www.haproxy.com
