Re: [PATCH] HTTP 103 response (Early Hints)

2018-11-13 Thread Willy Tarreau
On Tue, Nov 13, 2018 at 09:48:03AM +0100, Frederic Lecaille wrote:
> Thank you for having pointed out this issue (fixed by this new patch
> attached to this mail).

Merged, thank you.

Willy



Re: [PATCH] HTTP 103 response (Early Hints)

2018-11-13 Thread Frederic Lecaille

On 11/13/18 7:48 AM, Aleksandar Lazic wrote:

Hi Fred.


Hello Aleksandar,


Sorry to be picky but I still think that there is some missing text in the 
documentation, as mentioned before.

http://git.haproxy.org/?p=haproxy.git;a=commitdiff;h=06f5b6435ba99b7a6a034d27b56192e16249f6f0

MINOR: doc: Add information about "early-hint" http-request action.

As I could be wrong, just ignore this mail.


No you are correct.
Thank you for having pointed out this issue (fixed by this new patch 
attached to this mail).


Regards,

Fred.
>From ff8504842e81c9c2e8d7d317e50a62c6167b9609 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= 
Date: Tue, 13 Nov 2018 09:42:13 +0100
Subject: [PATCH 5/5] MINOR: doc: fix truncated line.

---
 doc/configuration.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/configuration.txt b/doc/configuration.txt
index 4750adf8..8cb4671b 100644
--- a/doc/configuration.txt
+++ b/doc/configuration.txt
@@ -4100,7 +4100,8 @@ http-request early-hint   [ { if | unless }  ]
   This appends an HTTP header field to this response whose name is specified in
and whose value is defined by  which follows the log-format rules
   (see Custom Log Format in section 8.2.4). This is particularly useful to pass
-  to the client som
+  to the client some Link headers to preload resources required to render the
+  HTML documents.
 
   See RFC 8297 for more information.
 
-- 
2.11.0



Re: [PATCH] HTTP 103 response (Early Hints)

2018-11-12 Thread Willy Tarreau
On Tue, Nov 13, 2018 at 07:48:38AM +0100, Aleksandar Lazic wrote:
> Hi Fred.
> 
> Sorry to be picky but I still think that there is some missing text in the 
> documentation, as mentioned before.
> 
> http://git.haproxy.org/?p=haproxy.git;a=commitdiff;h=06f5b6435ba99b7a6a034d27b56192e16249f6f0
> 
> MINOR: doc: Add information about "early-hint" http-request action.

Ah indeed, looks like a "hit enter too fast" issue.

Thanks for spotting this!
Willy



Re: [PATCH] HTTP 103 response (Early Hints)

2018-11-12 Thread Aleksandar Lazic
Hi Fred.

Sorry to be picky but I still think that there is some missing text in the 
documentation, as mentioned before.

http://git.haproxy.org/?p=haproxy.git;a=commitdiff;h=06f5b6435ba99b7a6a034d27b56192e16249f6f0

MINOR: doc: Add information about "early-hint" http-request action.

As I could be wrong, just ignore this mail.

Regards
Aleks


 Ursprüngliche Nachricht 
Von: Willy Tarreau 
Gesendet: 12. November 2018 21:09:23 MEZ
An: Frederic Lecaille 
CC: HAProxy 
Betreff: Re: [PATCH] HTTP 103 response (Early Hints)

On Mon, Nov 12, 2018 at 03:38:28PM +0100, Frederic Lecaille wrote:
> Hello,
> 
> Here is a little series of patches to implement a new http-request
> action named "early-hint" to add HTTP 103 responses prior to any other
> response with headers whose values are defined by log-format rules, as
> this is done with "(add|del)-header" action.

Cool! Applied, thank you Fred :-)

Willy




Re: [PATCH] HTTP 103 response (Early Hints)

2018-11-12 Thread Aleksandar Lazic
Hi Willy.

Am 12.11.2018 um 21:14 schrieb Willy Tarreau:
> Hi Aleks,
> 
> On Mon, Nov 12, 2018 at 06:00:25PM +0100, Aleksandar Lazic wrote:
>> Hi Fred.
>>
>> Am 12.11.2018 um 15:38 schrieb Frederic Lecaille:
>>> Hello,
>>>
>>> Here is a little series of patches to implement a new http-request
>>> action named "early-hint" to add HTTP 103 responses prior to any other
>>> response with headers whose values are defined by log-format rules, as
>>> this is done with "(add|del)-header" action.
>>
>> Cool ;-) , what can I do with that feature?
> 
> You can send some Link header fields to the client immediately before the
> server even gets the request. This allows the client to start to preload
> some contents that you're sure will be needed, without having to wait for
> the server's response to discover this. In reality the purpose is to make
> efficient use of the server's think time which can often be larger than
> one RTT. For many purposes it can be more interesting than PUSH because
> it will even allow the client to fetch from another origin, via a CDN or
> whatever (think for example about the number of sites referencing jquery.js
> or whatever CSS from Cloudflare).
> 
> This technique is still very new and is documented in RFC 8297 produced
> by the IETF HTTP workgroup. Browser support is still unclear in that the
> "link: preload" stuff is also very new and possibly at different maturity
> stages in browsers. But browsers also need server-side components to be
> available in order to improve their support, and since it's easy for us,
> let's provide our share of the work in making the net faster ;-)
Full Ack.

Thank you very much for the detailed explanation ;-)
That sounds a really great solution.

> Cheers,
> Willy

Regards
Aleks



Re: [PATCH] HTTP 103 response (Early Hints)

2018-11-12 Thread Willy Tarreau
Hi Aleks,

On Mon, Nov 12, 2018 at 06:00:25PM +0100, Aleksandar Lazic wrote:
> Hi Fred.
> 
> Am 12.11.2018 um 15:38 schrieb Frederic Lecaille:
> > Hello,
> > 
> > Here is a little series of patches to implement a new http-request
> > action named "early-hint" to add HTTP 103 responses prior to any other
> > response with headers whose values are defined by log-format rules, as
> > this is done with "(add|del)-header" action.
> 
> Cool ;-) , what can I do with that feature?

You can send some Link header fields to the client immediately before the
server even gets the request. This allows the client to start to preload
some contents that you're sure will be needed, without having to wait for
the server's response to discover this. In reality the purpose is to make
efficient use of the server's think time which can often be larger than
one RTT. For many purposes it can be more interesting than PUSH because
it will even allow the client to fetch from another origin, via a CDN or
whatever (think for example about the number of sites referencing jquery.js
or whatever CSS from Cloudflare).

This technique is still very new and is documented in RFC 8297 produced
by the IETF HTTP workgroup. Browser support is still unclear in that the
"link: preload" stuff is also very new and possibly at different maturity
stages in browsers. But browsers also need server-side components to be
available in order to improve their support, and since it's easy for us,
let's provide our share of the work in making the net faster ;-)

Cheers,
Willy



Re: [PATCH] HTTP 103 response (Early Hints)

2018-11-12 Thread Willy Tarreau
On Mon, Nov 12, 2018 at 03:38:28PM +0100, Frederic Lecaille wrote:
> Hello,
> 
> Here is a little series of patches to implement a new http-request
> action named "early-hint" to add HTTP 103 responses prior to any other
> response with headers whose values are defined by log-format rules, as
> this is done with "(add|del)-header" action.

Cool! Applied, thank you Fred :-)

Willy



Re: [PATCH] HTTP 103 response (Early Hints)

2018-11-12 Thread Aleksandar Lazic
Hi Fred.

Am 12.11.2018 um 15:38 schrieb Frederic Lecaille:
> Hello,
> 
> Here is a little series of patches to implement a new http-request
> action named "early-hint" to add HTTP 103 responses prior to any other
> response with headers whose values are defined by log-format rules, as
> this is done with "(add|del)-header" action.

Cool ;-) , what can I do with that feature?

Maybe there is some text missing in the configuration.txt patch?

0004-MINOR-doc-Add-information-about-early-hint-http-requ.patch

> Regards,
> 
> Fred.

Regards
Aleks