Re: [PATCH] cleanup: remove unused variable assignment (found by Coverity)
On Sat, May 16, 2020 at 10:45:24PM +0500, Илья Шипицин wrote: > Hello, > > can we apply that patch ? > it removes single assignment, fixes #593 > > > Cheers, > Ilya Shipitcin > From e922cfb5e6e60f573c8861d3e10e6736be601d47 Mon Sep 17 00:00:00 2001 > From: Ilya Shipitsin > Date: Sat, 16 May 2020 22:42:12 +0500 > Subject: [PATCH] CLEANUP: src/acl.c: remove unused assignment > > Coverity found unused variable assignment > > CID 1299671 (#1 of 1): Unused value (UNUSED_VALUE)assigned_pointer: > Assigning value from args[arg + 1] to word here, but that stored value is > overwritten before it can be used. > 958word = args[arg + 1]; > 959arg = arg_end; > --- I made a few changes in your patch, I replaced 'src/acl.c' by 'acl' in the subject, and I wrapped the body to 80 columns. Thanks, applied. -- William Lallemand
[PATCH] cleanup: remove unused variable assignment (found by Coverity)
Hello, can we apply that patch ? it removes single assignment, fixes #593 Cheers, Ilya Shipitcin From e922cfb5e6e60f573c8861d3e10e6736be601d47 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 16 May 2020 22:42:12 +0500 Subject: [PATCH] CLEANUP: src/acl.c: remove unused assignment Coverity found unused variable assignment CID 1299671 (#1 of 1): Unused value (UNUSED_VALUE)assigned_pointer: Assigning value from args[arg + 1] to word here, but that stored value is overwritten before it can be used. 958word = args[arg + 1]; 959arg = arg_end; --- src/acl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/acl.c b/src/acl.c index f3d7af789..fa8ae9238 100644 --- a/src/acl.c +++ b/src/acl.c @@ -955,7 +955,6 @@ struct acl_cond *parse_acl_cond(const char **args, struct list *known_acl, /* note that parse_acl() must have filled here */ goto out_free_suite; } - word = args[arg + 1]; arg = arg_end; } else { -- 2.26.2