Re: [PATCH 0/2] CI Updates
On Sat, Nov 21, 2020 at 02:55:58PM +0500, ??? wrote: > > Based on this, Ilya, do you have all the info you need and should I > > take this or does this need more discussion ? > > > > yes, I clarified it for myself Perfect, now merged, thanks all! Willy
Re: [PATCH 0/2] CI Updates
сб, 21 нояб. 2020 г. в 14:48, Willy Tarreau :
> On Fri, Nov 20, 2020 at 12:38:02PM +0100, Tim Düsterhus wrote:
> > > yes, I wonder how it is supposed to work.
> > > first, GH actions is supposed to run matrix.py in order to generate
> some
> > > scheduled jobs.
> >
> > It's simple, this part of the patch is responsible for that:
> >
> > -run: python3 .github/matrix.py
> > +run: python3 .github/matrix.py "${{ github.event_name }}"
> >
> > I just specify the event_name as the command line parameter to the
> > script and then read the command line parameter and store it in the
> > build_type variable :-)
> >
> > > I miss some documentation on that. I'll try to find myself (it should
> be
> > > documented I hope)
> > >
>
> Based on this, Ilya, do you have all the info you need and should I
> take this or does this need more discussion ?
>
yes, I clarified it for myself
>
> Thanks,
> Willy
>
Re: [PATCH 0/2] CI Updates
On Fri, Nov 20, 2020 at 12:38:02PM +0100, Tim Düsterhus wrote:
> > yes, I wonder how it is supposed to work.
> > first, GH actions is supposed to run matrix.py in order to generate some
> > scheduled jobs.
>
> It's simple, this part of the patch is responsible for that:
>
> -run: python3 .github/matrix.py
> +run: python3 .github/matrix.py "${{ github.event_name }}"
>
> I just specify the event_name as the command line parameter to the
> script and then read the command line parameter and store it in the
> build_type variable :-)
>
> > I miss some documentation on that. I'll try to find myself (it should be
> > documented I hope)
> >
Based on this, Ilya, do you have all the info you need and should I
take this or does this need more discussion ?
Thanks,
Willy
Re: [PATCH 0/2] CI Updates
Ilya,
Am 20.11.20 um 12:32 schrieb Илья Шипицин:
> if you mean the following part
>
> -<>-
> Within the matrix.py script it can now be detected whether the workflow is
> running on schedule by using:
>
> if build_type == "schedule":
> matrix.append(...)
> ---<->
>
>
> yes, I wonder how it is supposed to work.
> first, GH actions is supposed to run matrix.py in order to generate some
> scheduled jobs.
It's simple, this part of the patch is responsible for that:
-run: python3 .github/matrix.py
+run: python3 .github/matrix.py "${{ github.event_name }}"
I just specify the event_name as the command line parameter to the
script and then read the command line parameter and store it in the
build_type variable :-)
> I miss some documentation on that. I'll try to find myself (it should be
> documented I hope)
>
Best regards
Tim Düsterhus
Re: [PATCH 0/2] CI Updates
if you mean the following part -<>- Within the matrix.py script it can now be detected whether the workflow is running on schedule by using: if build_type == "schedule": matrix.append(...) ---<-> yes, I wonder how it is supposed to work. first, GH actions is supposed to run matrix.py in order to generate some scheduled jobs. I miss some documentation on that. I'll try to find myself (it should be documented I hope) пт, 20 нояб. 2020 г. в 16:27, Willy Tarreau : > Hi Ilya, > > On Fri, Nov 20, 2020 at 09:20:44AM +0500, ??? wrote: > > How it works? > > I mean if matrix is built on the fly, schedule is inside matrix, right? > How > > github can have prior knowledge when to run scheduled jobs then > > Isn't it what is explained in patch 2 ? I'm clueless on the CI so I could > be wrong, but I thought there were enough details there. > > Thanks, > Willy >
Re: [PATCH 0/2] CI Updates
Hi Ilya, On Fri, Nov 20, 2020 at 09:20:44AM +0500, ??? wrote: > How it works? > I mean if matrix is built on the fly, schedule is inside matrix, right? How > github can have prior knowledge when to run scheduled jobs then Isn't it what is explained in patch 2 ? I'm clueless on the CI so I could be wrong, but I thought there were enough details there. Thanks, Willy
Re: [PATCH 0/2] CI Updates
How it works? I mean if matrix is built on the fly, schedule is inside matrix, right? How github can have prior knowledge when to run scheduled jobs then On Fri, Nov 20, 2020, 4:16 AM Tim Duesterhus wrote: > Willy, > Ilya, > > find two patches improving the CI. > > 1) This lays the foundation to check the workflow trigger in the matrix >generator Python script, allowing us to move less important jobs into >a daily / weekly schedule. > > 2) This cleans up the Windows CI. I've made sure to re-use as much as > possible >from the VTest workflow, like I did for the compliance one. > >You can find the example output here: > > https://github.com/TimWolla/haproxy/runs/1427467730?check_suite_focus=true > > Best regards > > Tim Düsterhus (2): > CI: Pass the github.event_name to matrix.py > CI: Clean up Windows CI > > .github/matrix.py| 9 + > .github/workflows/vtest.yml | 2 +- > .github/workflows/windows-latest.yml | 20 -- > .github/workflows/windows.yml| 60 > 4 files changed, 70 insertions(+), 21 deletions(-) > delete mode 100644 .github/workflows/windows-latest.yml > create mode 100644 .github/workflows/windows.yml > > -- > 2.29.0 > >
[PATCH 0/2] CI Updates
Willy, Ilya, find two patches improving the CI. 1) This lays the foundation to check the workflow trigger in the matrix generator Python script, allowing us to move less important jobs into a daily / weekly schedule. 2) This cleans up the Windows CI. I've made sure to re-use as much as possible from the VTest workflow, like I did for the compliance one. You can find the example output here: https://github.com/TimWolla/haproxy/runs/1427467730?check_suite_focus=true Best regards Tim Düsterhus (2): CI: Pass the github.event_name to matrix.py CI: Clean up Windows CI .github/matrix.py| 9 + .github/workflows/vtest.yml | 2 +- .github/workflows/windows-latest.yml | 20 -- .github/workflows/windows.yml| 60 4 files changed, 70 insertions(+), 21 deletions(-) delete mode 100644 .github/workflows/windows-latest.yml create mode 100644 .github/workflows/windows.yml -- 2.29.0
