Re: [PR] Cleanup
On Wed, Oct 26, 2016 at 03:16:30PM +0200, Lukas Tribus wrote: > > Link: > > https://github.com/haproxy/haproxy/pull/42 > > This pull-request is from October 2015, I believe at least some of those > patches have been applied, others may not be relevant anymore; but I didn't > want to discard the whole series because I didn't carefully verify the > patches. Confirmed, I handled it with Erwan's help a few months ago. Thanks, willy
Re: [PR] Cleanup
Hello, Am 26.10.2016 um 15:06 schrieb PR Bot No-Reply: Dear list! Author: Erwan VeluNumber of patches: 8 This is an automated relay of the Github pull request: Cleanup Patch title(s): CLEANUP: don't ignore debian/ directory if present cfgparse: Protect free on NULL pointer proto_http: Removing useless variable assignation proto_http: Removing useless variable proto_http: Removing useless delta assignation dumpstats: Removing useless variables allocation payload: Removing useless pointer arithmetic dns: Removing usless variable & assignation Link: https://github.com/haproxy/haproxy/pull/42 This pull-request is from October 2015, I believe at least some of those patches have been applied, others may not be relevant anymore; but I didn't want to discard the whole series because I didn't carefully verify the patches. Thanks, Lukas
[PR] Cleanup
Dear list! Author: Erwan VeluNumber of patches: 8 This is an automated relay of the Github pull request: Cleanup Patch title(s): CLEANUP: don't ignore debian/ directory if present cfgparse: Protect free on NULL pointer proto_http: Removing useless variable assignation proto_http: Removing useless variable proto_http: Removing useless delta assignation dumpstats: Removing useless variables allocation payload: Removing useless pointer arithmetic dns: Removing usless variable & assignation Link: https://github.com/haproxy/haproxy/pull/42 Edit locally: wget https://github.com/haproxy/haproxy/pull/42.patch && vi 42.patch Apply locally: curl https://github.com/haproxy/haproxy/pull/42.patch | git am - Description: Please find in this PR my with contribution to the project. It does contains a few commits targeting a static analysis of possible mistakes or useless code. My changes looks like safe but as I'm new to that code, I could be wrong. Feel free to pick only some commits if some looks like too picky or useless for the project. That was my 2 cents applying to the current master tree. Cheers, Erwan Instructions: This github pull request will be closed automatically; patch should be reviewed on the haproxy mailing list (haproxy@formilux.org). Everyone is invited to comment, even the patch's author. Please keep the author and list CCed in replies. Please note that in absence of any response this pull request will be lost.