Re: [PATCH 1/4] mailer: increase default timeout to 10 seconds this allows the TCP connection to retry connecting when a packet is lost on the network
Hi Simon, On Wed, Feb 17, 2016 at 02:32:28PM +0900, Simon Horman wrote: > Hi Pieter, Hi Willy, > > On Tue, Feb 16, 2016 at 10:11:34PM +0100, P.Baauw wrote: > > Hi Willy, Simon, > > > > Op 16-2-2016 om 21:56 schreef Willy Tarreau: > > >Simon, > > > > > >are you OK with this series from Pieter ? > > Yes, they look good to me. > Thanks Pieter for the fixes/enhancements. > > Acked-by: Simon Horman Thanks. > My only request, which you are free to ignore, > would be to flesh out the changelog bodies a bit and shorten > the changelog subjects in cases where they are rather long. Yep I noticed this as well. I can handle this for this time, no need to respin one batch. Cheers, Willy
Re: [PATCH 1/4] mailer: increase default timeout to 10 seconds this allows the TCP connection to retry connecting when a packet is lost on the network
Hi Pieter, Hi Willy, On Tue, Feb 16, 2016 at 10:11:34PM +0100, P.Baauw wrote: > Hi Willy, Simon, > > Op 16-2-2016 om 21:56 schreef Willy Tarreau: > >Simon, > > > >are you OK with this series from Pieter ? Yes, they look good to me. Thanks Pieter for the fixes/enhancements. Acked-by: Simon Horman My only request, which you are free to ignore, would be to flesh out the changelog bodies a bit and shorten the changelog subjects in cases where they are rather long. > >Should we backport them to 1.6 ? They look like fixes but I'm uncertain. > Patches 1 and 4 i think should be backported to 1.6. I agree. > 1- allows the tcp connection to send multiple syn packets, so 1 lost packet > does not cause the mail to be lost. It changes the socket timeout from 2 to > 10 seconds, this allows for 3 syn packets to be send and waiting a little > for their reply. > 2- makes above time configurable, but i think the 10 seconds is a ok default > for most people. > 4- changes the line endings send in a email DATA part to this seems > to comply better with the rfc documentation. And works better with Exchange > 2013. > > p.s. > 3- (was a unrelated patch to resolver config parsing, discussed separately) > > Regards, > Pieter >
Re: [PATCH 1/4] mailer: increase default timeout to 10 seconds this allows the TCP connection to retry connecting when a packet is lost on the network
Hi Willy, Simon, Op 16-2-2016 om 21:56 schreef Willy Tarreau: Simon, are you OK with this series from Pieter ? Should we backport them to 1.6 ? They look like fixes but I'm uncertain. Patches 1 and 4 i think should be backported to 1.6. 1- allows the tcp connection to send multiple syn packets, so 1 lost packet does not cause the mail to be lost. It changes the socket timeout from 2 to 10 seconds, this allows for 3 syn packets to be send and waiting a little for their reply. 2- makes above time configurable, but i think the 10 seconds is a ok default for most people. 4- changes the line endings send in a email DATA part to this seems to comply better with the rfc documentation. And works better with Exchange 2013. p.s. 3- (was a unrelated patch to resolver config parsing, discussed separately) Regards, Pieter
Re: [PATCH 1/4] mailer: increase default timeout to 10 seconds this allows the TCP connection to retry connecting when a packet is lost on the network
Simon, are you OK with this series from Pieter ? Should we backport them to 1.6 ? They look like fixes but I'm uncertain. Thanks, Willy On Sat, Feb 13, 2016 at 04:35:58PM +0100, P.Baauw wrote: > > > From 4583d6c5a96413bc6b827863b2be8e0c5b68910b Mon Sep 17 00:00:00 2001 > From: Pieter Baauw > Date: Fri, 12 Feb 2016 14:35:20 +0100 > Subject: [PATCH 1/4] mailer: increase default timeout to 10 seconds this > allows the TCP connection to retry connecting when a packet is lost on the > network > > --- > include/common/defaults.h | 1 + > src/checks.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/common/defaults.h b/include/common/defaults.h > index d1994e8..1c971d9 100644 > --- a/include/common/defaults.h > +++ b/include/common/defaults.h > @@ -146,6 +146,7 @@ > > #define CHK_CONNTIME2000 > #define DEF_CHKINTR 2000 > +#define DEF_MAILALERTTIME 1 > #define DEF_FALLTIME3 > #define DEF_RISETIME2 > #define DEF_AGENT_FALLTIME1 > diff --git a/src/checks.c b/src/checks.c > index bc7eaa7..9d6d33e 100644 > --- a/src/checks.c > +++ b/src/checks.c > @@ -3108,7 +3108,7 @@ static int init_email_alert_checks(struct server *s) > > LIST_INIT(&q->email_alerts); > > - check->inter = DEF_CHKINTR; /* XXX: Would like to Skip to the > next alert, if any, ASAP. > + check->inter = DEF_MAILALERTTIME; /* XXX: Would like to Skip to > the next alert, if any, ASAP. >* But need enough time so that > timeouts don't occur >* during tcp check procssing. For > now just us an arbitrary default. */ > check->rise = DEF_AGENT_RISETIME; > -- > 2.7.0.windows.1 >