Re: Disabling regtests in Travis ?
On Tue, Jan 28, 2020 at 06:16:58PM +0500, ??? wrote: > ??, 28 ???. 2020 ?. ? 18:15, Willy Tarreau : > > > On Tue, Jan 28, 2020 at 06:02:16PM +0500, ??? wrote: > > > ??, 28 ???. 2020 ?. ? 16:02, Willy Tarreau : > > > > > > > On Tue, Jan 28, 2020 at 02:13:15PM +0500, ??? wrote: > > > > > btw, we can remove "allowed failure" since this test is slow and > > excluded > > > > > > > > > > https://travis-ci.com/haproxy/haproxy/jobs/280882138 > > > > > > > > My understanding of the commit message was that it was excluded because > > > > of issue #429. Am I wrong ? > > > > > > > > > > it was excluded 2 times. > > > > > > first, we marked openssl-1.0.2 as "allowed failure" because of #429 > > > second, it was excluded, because it is "slow" test > > > > Hmmm no, we instead disabled slow regtests, but I'm not seeing anything > > > > yep. > > Skip reg-tests/ssl/set_ssl_cert.vtc because its type 'slow' is excluded Ah got it. Well, that's just a coicidence because the problem met in this test is not that it is slow but that it fails on 1.0.2, so even if we were to re-enable slow tests later, it would fail again. Let's wait for #429 to be addressed first. Thanks, Willy
Re: Disabling regtests in Travis ?
вт, 28 янв. 2020 г. в 18:15, Willy Tarreau : > On Tue, Jan 28, 2020 at 06:02:16PM +0500, ??? wrote: > > ??, 28 ???. 2020 ?. ? 16:02, Willy Tarreau : > > > > > On Tue, Jan 28, 2020 at 02:13:15PM +0500, ??? wrote: > > > > btw, we can remove "allowed failure" since this test is slow and > excluded > > > > > > > > https://travis-ci.com/haproxy/haproxy/jobs/280882138 > > > > > > My understanding of the commit message was that it was excluded because > > > of issue #429. Am I wrong ? > > > > > > > it was excluded 2 times. > > > > first, we marked openssl-1.0.2 as "allowed failure" because of #429 > > second, it was excluded, because it is "slow" test > > Hmmm no, we instead disabled slow regtests, but I'm not seeing anything > yep. Skip reg-tests/ssl/set_ssl_cert.vtc because its type 'slow' is excluded > specific there under the allow_failures section : > > allow_failures: > - os: linux > arch: ppc64le > if: type == cron > compiler: gcc > env: TARGET=linux-glibc OPENSSL_VERSION=1.0.2u > > So my understanding is that it's still valid due to the error on > "set ssl cert". > > Or maybe you mean something different ? > > Willy >
Re: Disabling regtests in Travis ?
On Tue, Jan 28, 2020 at 06:02:16PM +0500, ??? wrote: > ??, 28 ???. 2020 ?. ? 16:02, Willy Tarreau : > > > On Tue, Jan 28, 2020 at 02:13:15PM +0500, ??? wrote: > > > btw, we can remove "allowed failure" since this test is slow and excluded > > > > > > https://travis-ci.com/haproxy/haproxy/jobs/280882138 > > > > My understanding of the commit message was that it was excluded because > > of issue #429. Am I wrong ? > > > > it was excluded 2 times. > > first, we marked openssl-1.0.2 as "allowed failure" because of #429 > second, it was excluded, because it is "slow" test Hmmm no, we instead disabled slow regtests, but I'm not seeing anything specific there under the allow_failures section : allow_failures: - os: linux arch: ppc64le if: type == cron compiler: gcc env: TARGET=linux-glibc OPENSSL_VERSION=1.0.2u So my understanding is that it's still valid due to the error on "set ssl cert". Or maybe you mean something different ? Willy
Re: Disabling regtests in Travis ?
вт, 28 янв. 2020 г. в 16:02, Willy Tarreau : > On Tue, Jan 28, 2020 at 02:13:15PM +0500, ??? wrote: > > btw, we can remove "allowed failure" since this test is slow and excluded > > > > https://travis-ci.com/haproxy/haproxy/jobs/280882138 > > My understanding of the commit message was that it was excluded because > of issue #429. Am I wrong ? > it was excluded 2 times. first, we marked openssl-1.0.2 as "allowed failure" because of #429 second, it was excluded, because it is "slow" test > > Willy >
Re: Disabling regtests in Travis ?
On Tue, Jan 28, 2020 at 02:13:15PM +0500, ??? wrote: > btw, we can remove "allowed failure" since this test is slow and excluded > > https://travis-ci.com/haproxy/haproxy/jobs/280882138 My understanding of the commit message was that it was excluded because of issue #429. Am I wrong ? Willy
Re: Disabling regtests in Travis ?
btw, we can remove "allowed failure" since this test is slow and excluded https://travis-ci.com/haproxy/haproxy/jobs/280882138 пн, 27 янв. 2020 г. в 17:35, Martin Grigorov : > > > On Fri, Jan 24, 2020 at 6:43 PM Willy Tarreau wrote: > >> On Fri, Jan 24, 2020 at 09:12:58PM +0500, ??? wrote: >> > >> + - make reg-tests VTEST_PROGRAM=../vtest/vtest >> > >> REGTESTS_TYPES=default,bug,devel >> > >> >> > > >> > > let us try that. >> >> OK, now pushed. >> >> > > I will have a look at "racy" tests. >> > > Maybe we'll enable them on Github Actions. >> > > >> > > >> > the good thing about Github Actions, it is possible to attach own build >> > agents. So, if we >> > have dedicated hardware and we not want to depend on travis-ci >> neighbours, >> > it might be an option. >> >> That's good to know, even if I doubt we'd need it, at least it >> opens possibilities. >> > > The regtests run fine on my ARM64 VM. I run them daily. > If HAProxy team decides to move to GitHub Actions and to use an external > build agent for ARM64 then just ping me! > > Regards, > Martin > > >> >> Willy >> >>
Re: Disabling regtests in Travis ?
On Fri, Jan 24, 2020 at 6:43 PM Willy Tarreau wrote: > On Fri, Jan 24, 2020 at 09:12:58PM +0500, ??? wrote: > > >> + - make reg-tests VTEST_PROGRAM=../vtest/vtest > > >> REGTESTS_TYPES=default,bug,devel > > >> > > > > > > let us try that. > > OK, now pushed. > > > > I will have a look at "racy" tests. > > > Maybe we'll enable them on Github Actions. > > > > > > > > the good thing about Github Actions, it is possible to attach own build > > agents. So, if we > > have dedicated hardware and we not want to depend on travis-ci > neighbours, > > it might be an option. > > That's good to know, even if I doubt we'd need it, at least it > opens possibilities. > The regtests run fine on my ARM64 VM. I run them daily. If HAProxy team decides to move to GitHub Actions and to use an external build agent for ARM64 then just ping me! Regards, Martin > > Willy > >
Re: Disabling regtests in Travis ?
On Fri, Jan 24, 2020 at 09:12:58PM +0500, ??? wrote: > >> + - make reg-tests VTEST_PROGRAM=../vtest/vtest > >> REGTESTS_TYPES=default,bug,devel > >> > > > > let us try that. OK, now pushed. > > I will have a look at "racy" tests. > > Maybe we'll enable them on Github Actions. > > > > > the good thing about Github Actions, it is possible to attach own build > agents. So, if we > have dedicated hardware and we not want to depend on travis-ci neighbours, > it might be an option. That's good to know, even if I doubt we'd need it, at least it opens possibilities. Willy
Re: Disabling regtests in Travis ?
пт, 24 янв. 2020 г. в 20:44, Илья Шипицин :
>
>
> пт, 24 янв. 2020 г. в 20:34, Willy Tarreau :
>
>> On Fri, Jan 24, 2020 at 04:31:07PM +0100, Willy Tarreau wrote:
>> > So I'm proposing that we try a last time to run with
>> > "REGTESTS_TYPES=default,bug,devel"
>>
>> That should probably give this :
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index bf4b82aa98..a82c27327d 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -112,7 +112,7 @@ script:
>>- ./haproxy -vv
>>- if [ "${TRAVIS_OS_NAME}" = "linux" ]; then ldd haproxy; fi
>>- if [ "${TRAVIS_OS_NAME}" = "osx" ]; then otool -L haproxy; fi
>> - - env VTEST_PROGRAM=../vtest/vtest make reg-tests
>> + - make reg-tests VTEST_PROGRAM=../vtest/vtest
>> REGTESTS_TYPES=default,bug,devel
>>
>
> let us try that.
>
> I will have a look at "racy" tests.
> Maybe we'll enable them on Github Actions.
>
>
the good thing about Github Actions, it is possible to attach own build
agents. So, if we
have dedicated hardware and we not want to depend on travis-ci neighbours,
it might be an option.
>
>
>>
>> after_failure:
>>- |
>>
>
Re: Disabling regtests in Travis ?
пт, 24 янв. 2020 г. в 20:34, Willy Tarreau :
> On Fri, Jan 24, 2020 at 04:31:07PM +0100, Willy Tarreau wrote:
> > So I'm proposing that we try a last time to run with
> > "REGTESTS_TYPES=default,bug,devel"
>
> That should probably give this :
>
> diff --git a/.travis.yml b/.travis.yml
> index bf4b82aa98..a82c27327d 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -112,7 +112,7 @@ script:
>- ./haproxy -vv
>- if [ "${TRAVIS_OS_NAME}" = "linux" ]; then ldd haproxy; fi
>- if [ "${TRAVIS_OS_NAME}" = "osx" ]; then otool -L haproxy; fi
> - - env VTEST_PROGRAM=../vtest/vtest make reg-tests
> + - make reg-tests VTEST_PROGRAM=../vtest/vtest
> REGTESTS_TYPES=default,bug,devel
>
let us try that.
I will have a look at "racy" tests.
Maybe we'll enable them on Github Actions.
>
> after_failure:
>- |
>
Re: Disabling regtests in Travis ?
On Fri, Jan 24, 2020 at 04:31:07PM +0100, Willy Tarreau wrote:
> So I'm proposing that we try a last time to run with
> "REGTESTS_TYPES=default,bug,devel"
That should probably give this :
diff --git a/.travis.yml b/.travis.yml
index bf4b82aa98..a82c27327d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -112,7 +112,7 @@ script:
- ./haproxy -vv
- if [ "${TRAVIS_OS_NAME}" = "linux" ]; then ldd haproxy; fi
- if [ "${TRAVIS_OS_NAME}" = "osx" ]; then otool -L haproxy; fi
- - env VTEST_PROGRAM=../vtest/vtest make reg-tests
+ - make reg-tests VTEST_PROGRAM=../vtest/vtest
REGTESTS_TYPES=default,bug,devel
after_failure:
- |
