Re: regression with patch 19e8aa58 "BUG/MINOR: server: Remove FQDN requirement for using init-addr and state file"

2017-09-06 Thread Willy Tarreau
On Wed, Sep 06, 2017 at 02:16:34PM +0200, Nenad Merdanovic wrote:
> Can you please revert this patch? It's not a good way to fix the issue we
> were experiencing before. It will need a bigger rewrite, because the logic
> in srv_iterate_initaddr needs to be changed.

OK now done. Thanks for your fast response.

Willy



Re: regression with patch 19e8aa58 "BUG/MINOR: server: Remove FQDN requirement for using init-addr and state file"

2017-09-06 Thread Nenad Merdanovic

Hello Willy,

On 9/6/2017 2:03 PM, Willy Tarreau wrote:

On Wed, Sep 06, 2017 at 01:10:26PM +0200, Emmanuel Hocdet wrote:

Hi,

server configuration now break with:

cfg sample:
listen tls
[...]
server bla 127.0.0.1:8080

[ALERT] 248/130258 (21960) : parsing [/etc/haproxy/test.cfg:53] : 'server bla' 
: no method found to resolve address '(null)'
[ALERT] 248/130258 (21960) : Failed to initialize server(s) addr.


G Thanks Manu. I think that after 1.8 we'll declare it illegal
to introduce new bugs. Surely this will help... oh well, it may prevent
me from approaching the keyboard :-/

Nenad, could you please have a look, since it was meant to fix another
issue ?


Can you please revert this patch? It's not a good way to fix the issue 
we were experiencing before. It will need a bigger rewrite, because the 
logic in srv_iterate_initaddr needs to be changed.


Thanks,
nenad



Thanks,
Willy





Re: regression with patch 19e8aa58 "BUG/MINOR: server: Remove FQDN requirement for using init-addr and state file"

2017-09-06 Thread Willy Tarreau
On Wed, Sep 06, 2017 at 01:10:26PM +0200, Emmanuel Hocdet wrote:
> Hi,
> 
> server configuration now break with:
> 
> cfg sample:
> listen tls
> [...]
> server bla 127.0.0.1:8080
> 
> [ALERT] 248/130258 (21960) : parsing [/etc/haproxy/test.cfg:53] : 'server 
> bla' : no method found to resolve address '(null)'
> [ALERT] 248/130258 (21960) : Failed to initialize server(s) addr.

G Thanks Manu. I think that after 1.8 we'll declare it illegal
to introduce new bugs. Surely this will help... oh well, it may prevent
me from approaching the keyboard :-/

Nenad, could you please have a look, since it was meant to fix another
issue ?

Thanks,
Willy



regression with patch 19e8aa58 "BUG/MINOR: server: Remove FQDN requirement for using init-addr and state file"

2017-09-06 Thread Emmanuel Hocdet
Hi,

server configuration now break with:

cfg sample:
listen tls
[…]
server bla 127.0.0.1:8080

[ALERT] 248/130258 (21960) : parsing [/etc/haproxy/test.cfg:53] : 'server bla' 
: no method found to resolve address '(null)'
[ALERT] 248/130258 (21960) : Failed to initialize server(s) addr.

++
Manu