Re: resolve memory leak in contrib/halog/halog.c

[Willy Tarreau]

Hi,

On Tue, Oct 03, 2017 at 10:14:44AM +0500,  ??? wrote:
> Ack/Nack ?

sorry, I didn't notice it. Now applied, thanks!

Willy

Re: resolve memory leak in contrib/halog/halog.c

[Илья Шипицин]

Ack/Nack ?

22 сент. 2017 г. 22:44 пользователь "Илья Шипицин" 
написал:

> Hello,
>
>
> [contrib/halog/halog.c:1572]: (error) Memory leak: ustat
>

resolve memory leak in contrib/halog/halog.c

[Илья Шипицин]

Hello,


[contrib/halog/halog.c:1572]: (error) Memory leak: ustat
From e58f1f8989715b2fa0c47c9169985d665c32c487 Mon Sep 17 00:00:00 2001
From: Ilya Shipitsin 
Date: Fri, 22 Sep 2017 22:33:16 +0500
Subject: [PATCH] BUG/MINOR: contrib/halog: fixing small memory leak

Issue was identified by cppcheck
---
 contrib/halog/halog.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/contrib/halog/halog.c b/contrib/halog/halog.c
index fc927bdd..cb815d8c 100644
--- a/contrib/halog/halog.c
+++ b/contrib/halog/halog.c
@@ -1569,6 +1569,7 @@ void filter_count_url(const char *accept_field, const char *time_field, struct t
 
 	if (unlikely(!*e)) {
 		truncated_line(linenum, line);
+		free(ustat);
 		return;
 	}
 
-- 
2.13.3