Re: [Harbour] SF.net SVN: harbour-project:[12249] trunk/harbour
Hi, 2009-08-21 19:19 UTC-0800 Pritpal Bedi (prit...@vouchcac.com) * contrib/hbwin/axcore.c + __AXDOVERB(), a very important function for in-process active-x controls There are a few things I do not like in this: 1) Passing of the message is not supported in this function. I understand that it could be a problem of missing agreement on passing C structures in Harbour level, but MSDN (http://msdn.microsoft.com/en-us/library/ms694508%28VS.85%29.aspx) says, that if message is not passed, C parameter should be set to NULL, but not a MSG structure stuffed with zero bytes: If an end user invokes a verb by some means other than selecting a command from a menu (say, by double-clicking or, more rarely, single-clicking an object), the object's container should pass a pointer to a Windows MSG structure containing the appropriate message. For example, if the end user invokes a verb by double-clicking the object, the container should pass a MSG structure containing WM_LBUTTONDBLCLK, WM_MBUTTONDBLCLK, or WM_RBUTTONDBLCLK. If the container passes no message, lpmsg should be set to NULL. 2) __AXDOVERB() calls GetClientSite method. http://msdn.microsoft.com/en-us/library/ms692603%28VS.85%29.aspx says: Each time an object receives a call to IOleObject::GetClientSite, it must increase the reference count on ppClientSite. It is the caller's responsibility to call Release when it is done with ppClientSite. I do not see Release() method call after DoVerb(). WARNING: I do not even know that client site is, so my remarks are based on docs only and could be erroneous. Regards, Mindaugas ___ Harbour mailing list Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
Re: [Harbour] SF.net SVN: harbour-project:[12249] trunk/harbour
Hi Pritpal, Thank you. There is one more issue in wvgsink.c. It uses HVM internals in hb_itemPushList(), which breaks a very important rule and may cause all sorts of problems. Would it be possible to somehow remove it, or replace it with a method based on documented Harbour APIs? I'm talking about contrib/gtwvg/wvgsink.c lines 95-97 and line 105. Brgds, Viktor On 2009.08.22., at 4:29, vouch...@users.sourceforge.net wrote: Revision: 12249 http://harbour-project.svn.sourceforge.net/harbour-project/?rev=12249view=rev Author: vouchcac Date: 2009-08-22 02:29:05 + (Sat, 22 Aug 2009) Log Message: --- 2009-08-21 19:19 UTC-0800 Pritpal Bedi (prit...@vouchcac.com) * contrib/gtwvg/wvgax.prg * contrib/gtwvg/wvgsink.c ! Code parts used fron axcore.c, deleted from these files. * contrib/hbwin/axcore.c + __AXDOVERB(), a very important function for in-process active-x controls Modified Paths: -- trunk/harbour/ChangeLog trunk/harbour/contrib/gtwvg/wvgax.prg trunk/harbour/contrib/gtwvg/wvgsink.c trunk/harbour/contrib/hbwin/axcore.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Harbour mailing list Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour ___ Harbour mailing list Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
Re: [Harbour] SF.net SVN: harbour-project:[12249] trunk/harbour
Hi Pritpal, Nice! Thank you very much. Brgds, Viktor On 2009.08.22., at 9:29, Pritpal Bedi wrote: Viktor Szakáts wrote: Hi Pritpal, Thank you. There is one more issue in wvgsink.c. It uses HVM internals in hb_itemPushList(), which breaks a very important rule and may cause all sorts of problems. Would it be possible to somehow remove it, or replace it with a method based on documented Harbour APIs? I'm talking about contrib/gtwvg/wvgsink.c lines 95-97 and line 105. Done. Regards Pritpal Bedi -- View this message in context: http://www.nabble.com/SF.net-SVN%3A-harbour-project%3A-12249--trunk-harbour-tp25090027p25091363.html Sent from the Harbour - Dev mailing list archive at Nabble.com. ___ Harbour mailing list Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour ___ Harbour mailing list Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
[Harbour] SF.net SVN: harbour-project:[12249] trunk/harbour
Revision: 12249 http://harbour-project.svn.sourceforge.net/harbour-project/?rev=12249view=rev Author: vouchcac Date: 2009-08-22 02:29:05 + (Sat, 22 Aug 2009) Log Message: --- 2009-08-21 19:19 UTC-0800 Pritpal Bedi (prit...@vouchcac.com) * contrib/gtwvg/wvgax.prg * contrib/gtwvg/wvgsink.c ! Code parts used fron axcore.c, deleted from these files. * contrib/hbwin/axcore.c + __AXDOVERB(), a very important function for in-process active-x controls Modified Paths: -- trunk/harbour/ChangeLog trunk/harbour/contrib/gtwvg/wvgax.prg trunk/harbour/contrib/gtwvg/wvgsink.c trunk/harbour/contrib/hbwin/axcore.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Harbour mailing list Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
