Re: [Harbour] SF.net SVN: harbour-project:[13149] trunk/harbour
On Mon, 07 Dec 2009, Szak�ts Viktor wrote: Hi, > Since the reference to hb_set*() function is hidden > inside a macro defined in hbwince.h (ie. it's a macro > implementation detail, which user code shouldn't be aware > of), hbset.h should be #included from the header which > defines the macro, not the final .c source which uses the > macro. AFAIR we have such situation in few places. I do not like it but also I do not see big problem with it. > Though if I put hbset.h into hbwince.h it gives a lot of > errors on compile. I can't find out why or where to place > it to avoid it. hbwince.h is always included in windows builds. If you will add #include "hbset.h" to this file then you will force including hbset.h in whole code. I do not think it's good idea. Anyhow if you want to make it then you should move #include "hbwince.h" from hbdefs.h to hbapi.h just after definition necessary for all other included files. As alternative you can move all UNICODE windows macros from hbwince.h to separate file, i.e. hbwinuni.h or hbwinuc.h which will include hbset.h and will have to be include explicitly by any code which needs to use them. This is probably the cleanest solution. best regards, Przemek ___ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
Re: [Harbour] SF.net SVN: harbour-project:[13149] trunk/harbour
>>; TOFIX: I'm getting this warning: >> warning: implicit declaration of function 'hb_setGetOSCP' >> and it's probably too late, but I couldn't find a way to >> include hbset.h without errors or with least side-effects. >> Przemek, could you help? > > I'm not sure I know what is the the exact problem. > It's enough to add #include "hbset.h" to wapi_shellapi.c. Since the reference to hb_set*() function is hidden inside a macro defined in hbwince.h (ie. it's a macro implementation detail, which user code shouldn't be aware of), hbset.h should be #included from the header which defines the macro, not the final .c source which uses the macro. Though if I put hbset.h into hbwince.h it gives a lot of errors on compile. I can't find out why or where to place it to avoid it. >> * src/rdd/dbcmd.c >> * src/rdd/wafunc.c >>+ Moved recently implemented codepage defaulting logic (_SET_DBCODEPAGE) >> to lower lever functions. >> Please review me. > > It looks OK, thank you very much. Thanks. Brgds, Viktor ___ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
Re: [Harbour] SF.net SVN: harbour-project:[13149] trunk/harbour
On Mon, 07 Dec 2009, vszak...@users.sourceforge.net wrote: Hi, > ; TOFIX: I'm getting this warning: >warning: implicit declaration of function 'hb_setGetOSCP' > and it's probably too late, but I couldn't find a way to > include hbset.h without errors or with least side-effects. > Przemek, could you help? I'm not sure I know what is the the exact problem. It's enough to add #include "hbset.h" to wapi_shellapi.c. > * src/rdd/dbcmd.c > * src/rdd/wafunc.c > + Moved recently implemented codepage defaulting logic (_SET_DBCODEPAGE) > to lower lever functions. > Please review me. It looks OK, thank you very much. best regards, Przemek ___ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
Re: [Harbour] SF.net SVN: harbour-project:[13149] trunk/harbour
On Mon, 7 Dec 2009, vszak...@users.sourceforge.net wrote: hi, [libpng] > * Updated to 1.2.41 (from 1.2.40) broke linux x win/watcom cpp ! Building Harbour 2.0.0beta3 from source - http://www.harbour-project.org ! MAKE: make 3.81 /bin/sh ! HB_INSTALL_PREFIX: /home/ice/w/xhb/hbci/inst/win/watcom/cpp ! HB_BUILD_DEBUG: yes ! HB_BUILD_OPTIM: no ! HB_BUILD_MODE: cpp ! HB_BUILD_EXTDEF: no ! HB_CONTRIBLIBS: no ! HB_HOST_PLAT: linux (x86_64) HB_SHELL: sh ! HB_PLATFORM: win (x86) ! HB_COMPILER: watcom ! HB_BIN_COMPILE not specified. Automatically set to: /usr/bin ! Component: 'zlib' found in /home/ice/w/xhb/hbci/harbour-build/external/zlib (local) ! Component: 'pcre' found in /home/ice/w/xhb/hbci/harbour-build/external/pcre (local) ! Component: 'openssl' not supported with watcom compiler ! Component: 'gpm' not supported on win platform ! Component: 'slang' not found ! Component: 'curses' not found ! Component: 'x11' not found ! Component: 'wattcp/watt-32' not supported on win platform ! REVISION: 13150 make[2]: Nothing to be done for `all'. make[1]: Nothing to be done for `all'. ! 'libhpdf' library skipped (platform or compiler not supported) wcc386 -zq -bt=nt -bm -w0 -3s -i. -i../../../../../include -d2 -DHB_TR_LEVEL_DEBUG -I/home/ice/w/xhb/hbci/harbour-build/external/zlib -fo=png.obj ../../../png.c wcc386 -zq -bt=nt -bm -w0 -3s -i. -i../../../../../include -d2 -DHB_TR_LEVEL_DEBUG -I/home/ice/w/xhb/hbci/harbour-build/external/zlib -fo=pngerror.obj ../../../pngerror.c wcc386 -zq -bt=nt -bm -w0 -3s -i. -i../../../../../include -d2 -DHB_TR_LEVEL_DEBUG -I/home/ice/w/xhb/hbci/harbour-build/external/zlib -fo=pnggccrd.obj ../../../pnggccrd.c wcc386 -zq -bt=nt -bm -w0 -3s -i. -i../../../../../include -d2 -DHB_TR_LEVEL_DEBUG -I/home/ice/w/xhb/hbci/harbour-build/external/zlib -fo=pngget.obj ../../../pngget.c wcc386 -zq -bt=nt -bm -w0 -3s -i. -i../../../../../include -d2 -DHB_TR_LEVEL_DEBUG -I/home/ice/w/xhb/hbci/harbour-build/external/zlib -fo=pngmem.obj ../../../pngmem.c ../../../pngmem.c(447): Error! E1057: Modifiers disagree with previous definition of 'png_calloc' ../../../pngmem.c(447): Note! I2002: 'png_calloc' defined in: ../../../png.h(3754) make[3]: *** [pngmem.obj] Error 1 make[2]: *** [descend] Error 2 make[1]: *** [libpng] Error 2 make: *** [external] Error 2 -- [-] mkdir /nonexistent ___ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
[Harbour] SF.net SVN: harbour-project:[13149] trunk/harbour
Revision: 13149 http://harbour-project.svn.sourceforge.net/harbour-project/?rev=13149&view=rev Author: vszakats Date: 2009-12-07 02:17:37 + (Mon, 07 Dec 2009) Log Message: --- 2009-12-07 02:58 UTC+0100 Viktor Szakats (harbour.01 syenar.hu) * include/hbwince.h + Added following macros to help transitioning to new method of CP conversion when interfacing with Windows API (both UNICODE and non-UNICODE): HB_PARSTR( n, h, len ) HB_RETSTR( str ) HB_RETSTRLEN( str, len ) HB_STORSTR( str, n ) HB_STORSTRLEN( str, len, n ) ; The goal is to replace HB_TCHAR_*() macros and hb_osEncodeCP() call with above ones. This will allow to use any CPs (even UTF8) on the .prg level and transparently interface with Windows with proper CP translation. We will probably need a few more macros to store strings in array elements f.e., but this is enough for a start. * contrib/hbwin/wapi_shellapi.c + Experimental: WAPI_SHELLEXECUTE() converted to use above new macros. It results in much cleaner code. Minor incompatibility: 3rd parameter is now passed as-is, so if non-string is passed it gets passed to Windows as NULL, which isn't a valid input parameter. ; NOTE: Probably it will useful to have HB_PARSTRDEF() which also accepts a default value to be used when non-string parameter was passed. (to replace old hb_parcx() calls). Is it possible to add such function or any other ways to solve that? ; TOFIX: I'm getting this warning: warning: implicit declaration of function 'hb_setGetOSCP' and it's probably too late, but I couldn't find a way to include hbset.h without errors or with least side-effects. Przemek, could you help? * contrib/hbwin/win_prn1.c * Formatting. * src/rdd/dbcmd.c * src/rdd/wafunc.c + Moved recently implemented codepage defaulting logic (_SET_DBCODEPAGE) to lower lever functions. Please review me. * external/libpng/pngrio.c * external/libpng/pngerror.c * external/libpng/pngconf.h * external/libpng/pngwrite.c * external/libpng/pngset.c * external/libpng/pngpread.c * external/libpng/pngwtran.c * external/libpng/LICENSE * external/libpng/pngwio.c * external/libpng/pngrutil.c * external/libpng/pngwutil.c * external/libpng/pngread.c * external/libpng/pngmem.c * external/libpng/png.c * external/libpng/pngget.c * external/libpng/pnggccrd.c * external/libpng/png.h * external/libpng/pngrtran.c * external/libpng/pngtrans.c * Updated to 1.2.41 (from 1.2.40) Modified Paths: -- trunk/harbour/ChangeLog trunk/harbour/contrib/hbwin/wapi_shellapi.c trunk/harbour/contrib/hbwin/win_prn1.c trunk/harbour/external/libpng/LICENSE trunk/harbour/external/libpng/png.c trunk/harbour/external/libpng/png.h trunk/harbour/external/libpng/pngconf.h trunk/harbour/external/libpng/pngerror.c trunk/harbour/external/libpng/pnggccrd.c trunk/harbour/external/libpng/pngget.c trunk/harbour/external/libpng/pngmem.c trunk/harbour/external/libpng/pngpread.c trunk/harbour/external/libpng/pngread.c trunk/harbour/external/libpng/pngrio.c trunk/harbour/external/libpng/pngrtran.c trunk/harbour/external/libpng/pngrutil.c trunk/harbour/external/libpng/pngset.c trunk/harbour/external/libpng/pngtrans.c trunk/harbour/external/libpng/pngwio.c trunk/harbour/external/libpng/pngwrite.c trunk/harbour/external/libpng/pngwtran.c trunk/harbour/external/libpng/pngwutil.c trunk/harbour/include/hbwince.h trunk/harbour/src/rdd/dbcmd.c trunk/harbour/src/rdd/wafunc.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
