Re: [Harbour] SF.net SVN: harbour-project:[13729] trunk/harbour

2010-01-29 Thread Mindaugas Kavaliauskas 

Hi,


dru...@users.sourceforge.net wrote:

2010-01-28 23:24 UTC+0100 Przemyslaw Czerpak (druzus/at/priv.onet.pl)
  * harbour/src/rdd/dbfcdx/dbfcdx1.c
+ enabled automatic template order setting in Harbour SIXCDX RDD using
  the same method as SIX3 SIXCDX RDD seems to use: by checking leading
  character of key expression for: sxChar(, sxDate(, sxNum( and
  sxLog(


I'm not a good index locking and dbfcdx driver internals guru, but new 
code looks like a little buggy.


dbfcdx1.c line 8414 has
  hb_cdxIndexLockWrite( pTag-pIndex );
but line 8437
  hb_cdxIndexUnLockWrite( pTag-pIndex );
is protected by line 8434
  if( pKey )

I guess if pKey == NULL index remains locked!


The same for lines 8465 and 8496.


Regards,
Mindaugas
___
Harbour mailing list (attachment size limit: 40KB)
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

Re: [Harbour] SF.net SVN: harbour-project:[13729] trunk/harbour

2010-01-29 Thread Przemysław Czerpak 
On Fri, 29 Jan 2010, Mindaugas Kavaliauskas wrote:

Hi,

 dru...@users.sourceforge.net wrote:
 2010-01-28 23:24 UTC+0100 Przemyslaw Czerpak (druzus/at/priv.onet.pl)
   * harbour/src/rdd/dbfcdx/dbfcdx1.c
 + enabled automatic template order setting in Harbour SIXCDX RDD using
   the same method as SIX3 SIXCDX RDD seems to use: by checking leading
   character of key expression for: sxChar(, sxDate(, sxNum( and
   sxLog(
 I'm not a good index locking and dbfcdx driver internals guru, but
 new code looks like a little buggy.
 dbfcdx1.c line 8414 has
   hb_cdxIndexLockWrite( pTag-pIndex );
 but line 8437
   hb_cdxIndexUnLockWrite( pTag-pIndex );
 is protected by line 8434
   if( pKey )
 I guess if pKey == NULL index remains locked!
 The same for lines 8465 and 8496.

Yes. My fault. Thank you very much for checking it.

best regards,
Przemek
___
Harbour mailing list (attachment size limit: 40KB)
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour

[Harbour] SF.net SVN: harbour-project:[13729] trunk/harbour

2010-01-28 Thread druzus 
Revision: 13729
  
http://harbour-project.svn.sourceforge.net/harbour-project/?rev=13729view=rev
Author:   druzus
Date: 2010-01-28 22:25:09 + (Thu, 28 Jan 2010)

Log Message:
---
2010-01-28 23:24 UTC+0100 Przemyslaw Czerpak (druzus/at/priv.onet.pl)
  * harbour/src/rdd/dbfcdx/dbfcdx1.c
+ enabled automatic template order setting in Harbour SIXCDX RDD using
  the same method as SIX3 SIXCDX RDD seems to use: by checking leading
  character of key expression for: sxChar(, sxDate(, sxNum( and
  sxLog(
  Warning: This code is enabled only for SIXCDX RDD and DBFCDX was not
   modified.
* disabled RTE in SIXCDX when key add/del operation are executed
  for non custom indexes and
* do not add keys with different type to template indexes in SIXCDX
  RDD for strict SIX3 compatibility.

  * harbour/doc/cmpopt.txt
+ added information about missing in Clipper expression optimization
  in LOCAL, PRIVATE and PUBLIC variable declaration. Clipper optimize
  only expressions used in STATIC declarations.

Modified Paths:
--
trunk/harbour/ChangeLog
trunk/harbour/doc/cmpopt.txt
trunk/harbour/src/rdd/dbfcdx/dbfcdx1.c


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.
___
Harbour mailing list (attachment size limit: 40KB)
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour