Re: [Harbour] SF.net SVN: harbour-project:[14029] trunk/harbour
On Tue, Mar 2, 2010 at 10:46 AM, Viktor Szakáts wrote: > Disabling "GUI window close button" is a GT speciality > ... > in practice. I would also add that every change in gtwvt must be synced with gtxwc. If the change is not portable it needs to be "explicit" and documented. best regards, Lorenzo ___ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
Re: [Harbour] SF.net SVN: harbour-project:[14029] trunk/harbour
>> Please revert this. The behavior was intentionally
>> designed to be controlled by hb_GTInfo( HB_GTI_CLOSABLE ),
>> (instead of SETCANCEL()).
>
> Sorry but as you've seen the development list has been off-line many hours.
> You've done a reversal before I can read the messages.
>
> Could you explain what is the intention of change because .-
>
> 2008-06-25 11:49 UTC+0200 Viktor Szakats (harbour.01 syenar.hu)
> * source/rtl/gtwvt/gtwvt.c
> * Slightly changed the way CLOSE button works.
> Now the close button, if enabled, will always
> force a shutdown. So this setting is made independent
> of SetCancel(). I choose this because there might
> be cases when we need to use in app code, yet
> we want to allow closing the window. Previously it was
> also easy to create confusing scenarios by using various
> combinations of HB_GTI_CLOSABLE + SetCancel(). Another
> kind of fix - without the advantage above - would be
> to fully sync SetCancel() with HB_GTI_CLOSABLE.
>
> It's very unclear and before the change SetCancel() was respected.
>
> You say: "I choose this because there might be cases when we need to use
> in app code, yet we want to allow closing the window."
>
> Sorry but I don't understand. You change the behavior of GTWVT with
> SetCancel() respect to GTWIN and GTWVG for something that you can do in your
> code with .-
>
> hb_gtInfo( HB_GTI_NOTIFIERBLOCK, {|e| iif( e == HB_GTE_CLOSE, SetCancel(.T.),
> nil ), 0} )
Disabling "GUI window close button" is a GT speciality
feature and as such it should be best controlled by a
GT speciality option. Otherwise the code hides a platform / GT
difference which just cannot be hidden. IOW we should
not make the impression if SETCANCEL() always disables
windows-close behavior, since this is not true and cannot
be true in real life (see GTWIN f.e.). IMO this is two
different problem and as such they need separate control.
If've been experimenting with this for weeks at the time,
and the solution which you re-implemented was also
unsatisfactory in real life, and it was confusing.
I use SETCANCEL() regularly, as I do need
as regular key combination, yet I don't want to cripple
the window to have non-working close functionality.
It's also very confusing because the close button is
_there_, it just doesn't work. When you use HB_GTI_CLOSABLE,
there is clear visual evidence that the close button
is disabled, since it's grayed out. But, such feature
is inherently GT/platform dependent, so it's not good
to use SETCANCEL(), which is fully portable.
BTW, I finally settled with presenting a dialog when
close button is pressed, because even graying out the
close button didn't look like a very good idea either
in practice.
Brgds,
Viktor
___
Harbour mailing list (attachment size limit: 40KB)
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour
Re: [Harbour] SF.net SVN: harbour-project:[14029] trunk/harbour
Hi Viktor,
Please revert this. The behavior was intentionally
designed to be controlled by hb_GTInfo( HB_GTI_CLOSABLE ),
(instead of SETCANCEL()).
Sorry but as you've seen the development list has been off-line many hours.
You've done a reversal before I can read the messages.
Could you explain what is the intention of change because .-
2008-06-25 11:49 UTC+0200 Viktor Szakats (harbour.01 syenar.hu)
* source/rtl/gtwvt/gtwvt.c
* Slightly changed the way CLOSE button works.
Now the close button, if enabled, will always
force a shutdown. So this setting is made independent
of SetCancel(). I choose this because there might
be cases when we need to use in app code, yet
we want to allow closing the window. Previously it was
also easy to create confusing scenarios by using various
combinations of HB_GTI_CLOSABLE + SetCancel(). Another
kind of fix - without the advantage above - would be
to fully sync SetCancel() with HB_GTI_CLOSABLE.
It's very unclear and before the change SetCancel() was respected.
You say: "I choose this because there might be cases when we need to use in app code, yet we want to allow closing the
window."
Sorry but I don't understand. You change the behavior of GTWVT with SetCancel() respect to GTWIN and GTWVG for something that
you can do in your code with .-
hb_gtInfo( HB_GTI_NOTIFIERBLOCK, {|e| iif( e == HB_GTE_CLOSE, SetCancel(.T.),
nil ), 0} )
Best regards,
--
Xavi
El 01/03/2010 9:32, Viktor Szakáts escribió:
Hi Xavi,
Please revert this. The behavior was intentionally
designed to be controlled by hb_GTInfo( HB_GTI_CLOSABLE ),
(instead of SETCANCEL()).
Brgds,
Viktor
On 2010 Mar 1, at 04:06, jara...@users.sourceforge.net wrote:
Revision: 14029
http://harbour-project.svn.sourceforge.net/harbour-project/?rev=14029&view=rev
Author: jarabal
Date: 2010-03-01 03:06:26 + (Mon, 01 Mar 2010)
Log Message:
---
2010-03-01 04:05 UTC+0100 Xavi (jarabal/at/gmail.com)
* harbour/src/rtl/gtwvt/gtwvt.c
! Fixing WM_CLOSE event (Clicked 'X' on system menu)
to avoid irregular shutdown with SETCANCEL( .F. )
REQUEST HB_GT_WVT_DEFAULT
ANNOUNCE HB_GTSYS
PROCEDURE Main()
SetCancel(.F.)
? "Click [X] Not close windows"
while( LastKey() != 27 )
Inkey( 1 )
enddo
RETURN
Modified Paths:
--
trunk/harbour/ChangeLog
trunk/harbour/src/rtl/gtwvt/gtwvt.c
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
___
Harbour mailing list (attachment size limit: 40KB)
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour
___
Harbour mailing list (attachment size limit: 40KB)
Harbour@harbour-project.org
http://lists.harbour-project.org/mailman/listinfo/harbour
Re: [Harbour] SF.net SVN: harbour-project:[14029] trunk/harbour
Details here: 2008-06-25 11:49 UTC+0200 Viktor Szakats (harbour.01 syenar.hu) Brgds, Viktor On 2010 Mar 1, at 09:32, Viktor Szakáts wrote: > Hi Xavi, > > Please revert this. The behavior was intentionally > designed to be controlled by hb_GTInfo( HB_GTI_CLOSABLE ), > (instead of SETCANCEL()). > > Brgds, > Viktor > > On 2010 Mar 1, at 04:06, jara...@users.sourceforge.net wrote: > >> Revision: 14029 >> >> http://harbour-project.svn.sourceforge.net/harbour-project/?rev=14029&view=rev >> Author: jarabal >> Date: 2010-03-01 03:06:26 + (Mon, 01 Mar 2010) >> >> Log Message: >> --- >> 2010-03-01 04:05 UTC+0100 Xavi (jarabal/at/gmail.com) >> * harbour/src/rtl/gtwvt/gtwvt.c >> ! Fixing WM_CLOSE event (Clicked 'X' on system menu) >> to avoid irregular shutdown with SETCANCEL( .F. ) >> >> REQUEST HB_GT_WVT_DEFAULT >> ANNOUNCE HB_GTSYS >> PROCEDURE Main() >>SetCancel(.F.) >>? "Click [X] Not close windows" >>while( LastKey() != 27 ) >> Inkey( 1 ) >>enddo >> RETURN >> >> Modified Paths: >> -- >> trunk/harbour/ChangeLog >> trunk/harbour/src/rtl/gtwvt/gtwvt.c >> >> >> This was sent by the SourceForge.net collaborative development platform, the >> world's largest Open Source development site. >> ___ >> Harbour mailing list (attachment size limit: 40KB) >> Harbour@harbour-project.org >> http://lists.harbour-project.org/mailman/listinfo/harbour > ___ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
Re: [Harbour] SF.net SVN: harbour-project:[14029] trunk/harbour
Hi Xavi, Please revert this. The behavior was intentionally designed to be controlled by hb_GTInfo( HB_GTI_CLOSABLE ), (instead of SETCANCEL()). Brgds, Viktor On 2010 Mar 1, at 04:06, jara...@users.sourceforge.net wrote: > Revision: 14029 > > http://harbour-project.svn.sourceforge.net/harbour-project/?rev=14029&view=rev > Author: jarabal > Date: 2010-03-01 03:06:26 + (Mon, 01 Mar 2010) > > Log Message: > --- > 2010-03-01 04:05 UTC+0100 Xavi (jarabal/at/gmail.com) > * harbour/src/rtl/gtwvt/gtwvt.c >! Fixing WM_CLOSE event (Clicked 'X' on system menu) > to avoid irregular shutdown with SETCANCEL( .F. ) > > REQUEST HB_GT_WVT_DEFAULT > ANNOUNCE HB_GTSYS > PROCEDURE Main() > SetCancel(.F.) > ? "Click [X] Not close windows" > while( LastKey() != 27 ) >Inkey( 1 ) > enddo > RETURN > > Modified Paths: > -- >trunk/harbour/ChangeLog >trunk/harbour/src/rtl/gtwvt/gtwvt.c > > > This was sent by the SourceForge.net collaborative development platform, the > world's largest Open Source development site. > ___ > Harbour mailing list (attachment size limit: 40KB) > Harbour@harbour-project.org > http://lists.harbour-project.org/mailman/listinfo/harbour ___ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
[Harbour] SF.net SVN: harbour-project:[14029] trunk/harbour
Revision: 14029 http://harbour-project.svn.sourceforge.net/harbour-project/?rev=14029&view=rev Author: jarabal Date: 2010-03-01 03:06:26 + (Mon, 01 Mar 2010) Log Message: --- 2010-03-01 04:05 UTC+0100 Xavi (jarabal/at/gmail.com) * harbour/src/rtl/gtwvt/gtwvt.c ! Fixing WM_CLOSE event (Clicked 'X' on system menu) to avoid irregular shutdown with SETCANCEL( .F. ) REQUEST HB_GT_WVT_DEFAULT ANNOUNCE HB_GTSYS PROCEDURE Main() SetCancel(.F.) ? "Click [X] Not close windows" while( LastKey() != 27 ) Inkey( 1 ) enddo RETURN Modified Paths: -- trunk/harbour/ChangeLog trunk/harbour/src/rtl/gtwvt/gtwvt.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Harbour mailing list (attachment size limit: 40KB) Harbour@harbour-project.org http://lists.harbour-project.org/mailman/listinfo/harbour
