Re: [HarfBuzz] Dotted circles in harfbuzz
Hi, Looks like this is fixing the crash, -glyphString[slen++] = C_DOTTED_CIRCLE; +//glyphString[slen++] = C_DOTTED_CIRCLE; // Don't hardcode dotted circle when base glyph is blank + item-attributes[slen-1].dontPrint = true; // FIXME this will hide all dotted circle -- Regards, Vignesh. ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/harfbuzz
[HarfBuzz] Dotted circles in harfbuzz
Hi All, I was checking a thai webpage which has a virtual keyboard, https://www.branah.com/thai When I open this website in chrome, I do not see the dotted circles in keyboard and when top level thai characters are typed nothing appears in text area. Using a sample application (facybroswer) dotted circle is seen in the keyboard and when the top level thai characters are typed, it is seen in the text area along with dotted circle. The Qt version used is Qt 4.7.4. I see the dotted circle was added in harbuzz (harfbuzz old) bundled with Qt with the below patch, From 44f415aafaf7eec56b31468a58e0ca768bbc082d Mon Sep 17 00:00:00 2001 From: Jiang Jiang jiang.ji...@nokia.com Date: Mon, 16 Jan 2012 15:39:56 +0100 Subject: [PATCH] Fix isolated Thai SARA AM handling If I remove this patch the dotted circle is not seen. But when the first level vocal is entered nothing appears in the text area and the application crashes. So my questions are, 1) Is this dotted circle a standard feature in harbuzz or any qt web browsers. 2) Is it possbile to make the behaviour similar to chrome? Dotted circle hidden and no characters should be seen when top level thai characters are pressed. Thanks for any pointers. Regards, Vignesh. ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/harfbuzz
Re: [HarfBuzz] Dotted circles in harfbuzz
I suggested to Vignesh off the mailing list to apply the following patch: http://pastebin.com/e3tJRYMP i.e just adding: glyphString[slen++] = C_DOTTED_CIRCLE; + item-attributes[slen-1].dontPrint = true; // FIXME this will hide all dotted circle However he found that this causes a crash. I wasn't sure of the correct fix for this. John On 24 June 2015 at 13:19, Vignesh Raman rvignesh.ra...@gmail.com wrote: Hi All, I was checking a thai webpage which has a virtual keyboard, https://www.branah.com/thai When I open this website in chrome, I do not see the dotted circles in keyboard and when top level thai characters are typed nothing appears in text area. Using a sample application (facybroswer) dotted circle is seen in the keyboard and when the top level thai characters are typed, it is seen in the text area along with dotted circle. The Qt version used is Qt 4.7.4. I see the dotted circle was added in harbuzz (harfbuzz old) bundled with Qt with the below patch, From 44f415aafaf7eec56b31468a58e0ca768bbc082d Mon Sep 17 00:00:00 2001 From: Jiang Jiang jiang.ji...@nokia.com Date: Mon, 16 Jan 2012 15:39:56 +0100 Subject: [PATCH] Fix isolated Thai SARA AM handling If I remove this patch the dotted circle is not seen. But when the first level vocal is entered nothing appears in the text area and the application crashes. So my questions are, 1) Is this dotted circle a standard feature in harbuzz or any qt web browsers. 2) Is it possbile to make the behaviour similar to chrome? Dotted circle hidden and no characters should be seen when top level thai characters are pressed. Thanks for any pointers. Regards, Vignesh. ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/harfbuzz ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/harfbuzz
