[jira] Updated: (HARMONY-185) linux native sources use uninitialized variables

2006-03-07 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-185?page=all ]

Mark Hindess updated HARMONY-185:
-

Attachment: avoid.uninitialized.variable.warnings

 linux native sources use uninitialized variables
 

  Key: HARMONY-185
  URL: http://issues.apache.org/jira/browse/HARMONY-185
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: avoid.uninitialized.variable.warnings

 I will attach a patch to fix some of these.  (This is part of a broader 
 attempt to clean up the warnings generated when compiling with 'gcc -Wall'.  
 Some of them are trivial, some are false positives and some are arguably real 
 bugs.)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-92) Suggestion: Move com.ibm.platform from NIO to LUNI

2006-03-07 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-92?page=comments#action_12369215 ] 

Mark Hindess commented on HARMONY-92:
-

Looks good.  Thanks Tim.


 Suggestion: Move com.ibm.platform from NIO to LUNI
 --

  Key: HARMONY-92
  URL: http://issues.apache.org/jira/browse/HARMONY-92
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Richard Liang
 Assignee: Tim Ellison
  Attachments: 06.remove-obsolete.sh, new.refactor.tar.gz, 
 refactor_platform.zip

 Hello Tim,
 As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages 
 com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As 
 these packages are used by java.net, as well as java.nio.channels. I will 
 post the proposed fix soon :-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-171) Move more shared code from win/linux natives.

2006-03-07 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-171?page=comments#action_12369238 
] 

Mark Hindess commented on HARMONY-171:
--

Oops.  There is a typo in the 01 script:

  svn remove native-src/win.IA32/archive/zip.c

should read:

  svn remove native-src/linux.IA32/archive/zip.c


 Move more shared code from win/linux natives.
 -

  Key: HARMONY-171
  URL: http://issues.apache.org/jira/browse/HARMONY-171
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Minor
  Attachments: 01.shared.moves.sh, 02.shared.diff

 Thanks to Oliver's changes (HARMONY-155) there are now more identical files 
 in the win/linux native trees.  I'll attach a patch to move them to the 
 shared tree.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-174) Change windows native clean to be less verbose/confusing

2006-03-06 Thread Mark Hindess (JIRA)
Change windows native clean to be less verbose/confusing


 Key: HARMONY-174
 URL: http://issues.apache.org/jira/browse/HARMONY-174
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


As discussed on the list.  Change delete on windows to be more like rm -f on 
linux.  Will attach the trivial patch.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-174) Change windows native clean to be less verbose/confusing

2006-03-06 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-174?page=all ]

Mark Hindess updated HARMONY-174:
-

Attachment: change.win.del.to.be.more.like.linux.rm.-f

Trivial patch to make delete more like unix rm -f.


 Change windows native clean to be less verbose/confusing
 

  Key: HARMONY-174
  URL: http://issues.apache.org/jira/browse/HARMONY-174
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: change.win.del.to.be.more.like.linux.rm.-f

 As discussed on the list.  Change delete on windows to be more like rm -f 
 on linux.  Will attach the trivial patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-175) natives contain duplicate of convertToPlatform function

2006-03-06 Thread Mark Hindess (JIRA)
natives contain duplicate of convertToPlatform function
---

 Key: HARMONY-175
 URL: http://issues.apache.org/jira/browse/HARMONY-175
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Minor


OSFileSystem.c contains a duplicate of the convertToPlatform function that is 
in common/iohelp.c.  Will attach a patch.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-175) natives contain duplicate of convertToPlatform function

2006-03-06 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-175?page=all ]

Mark Hindess updated HARMONY-175:
-

Attachment: remove.duplicate.convertToPlatform

This patch removes the duplicate convertToPlatform function - it assumes 
OSFileSystem.c has been moved by application of HARMONY-92.


 natives contain duplicate of convertToPlatform function
 ---

  Key: HARMONY-175
  URL: http://issues.apache.org/jira/browse/HARMONY-175
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Minor
  Attachments: remove.duplicate.convertToPlatform

 OSFileSystem.c contains a duplicate of the convertToPlatform function that is 
 in common/iohelp.c.  Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-176) Linux natives rely on implicit declarations of system functions

2006-03-06 Thread Mark Hindess (JIRA)
Linux natives rely on implicit declarations of system functions
---

 Key: HARMONY-176
 URL: http://issues.apache.org/jira/browse/HARMONY-176
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


Appropriate headers should be included to avoid assumptions about system 
functions.  Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-176) Linux natives rely on implicit declarations of system functions

2006-03-06 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-176?page=all ]

Mark Hindess updated HARMONY-176:
-

Attachment: explicit.function.declarations

This patch adds #includes of appropriate systems header files to pull in 
explicit declarations of system functions used.


 Linux natives rely on implicit declarations of system functions
 ---

  Key: HARMONY-176
  URL: http://issues.apache.org/jira/browse/HARMONY-176
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: explicit.function.declarations

 Appropriate headers should be included to avoid assumptions about system 
 functions.  Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-177) redundant files: native-src

2006-03-06 Thread Mark Hindess (JIRA)
redundant files: native-src
---

 Key: HARMONY-177
 URL: http://issues.apache.org/jira/browse/HARMONY-177
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


The following files are redundant.  I wont bother attaching a patch.

native-src/linux.IA32/port/ut_hyprt.inc
native-src/win.IA32/port/ut_hyprt.inc 
native-src/win.IA32/archive/iohelp.c
native-src/win.IA32/archive/iohelp.h


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-183) refactor linux specific parts of nethelp.c then make it shared code

2006-03-06 Thread Mark Hindess (JIRA)
refactor linux specific parts of nethelp.c then make it shared code
---

 Key: HARMONY-183
 URL: http://issues.apache.org/jira/browse/HARMONY-183
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Minor


nethelp.c in win and linux natives are identical apart from a linux specific 
function.  I'd suggest moving the linux specific function to a new file, 
OSNetworkSystemLinux.c, then making nethelp.c a shared source file.  I'll 
attach a patch shortly.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-92) Suggestion: Move com.ibm.platform from NIO to LUNI

2006-03-05 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-92?page=all ]

Mark Hindess updated HARMONY-92:


Attachment: new.refactor.tar.gz

I've created a new version of these changes (from scratch to avoid provenance 
issues giving Geir headaches).

There are scripts and patches numbered in order that they should be applied.  
It's broken down in to two stages - the nio to luni move and the rename.  Check 
the README for details.

Richard,  let me know if I've missed anything.  Thanks.


 Suggestion: Move com.ibm.platform from NIO to LUNI
 --

  Key: HARMONY-92
  URL: http://issues.apache.org/jira/browse/HARMONY-92
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Richard Liang
  Attachments: new.refactor.tar.gz, refactor_platform.zip

 Hello Tim,
 As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages 
 com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As 
 these packages are used by java.net, as well as java.nio.channels. I will 
 post the proposed fix soon :-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-92) Suggestion: Move com.ibm.platform from NIO to LUNI

2006-03-05 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-92?page=all ]

Mark Hindess updated HARMONY-92:


Attachment: 06.remove-obsolete.sh

If you apply my changes then a number of files are no longer required.  The 06 
script removes them.


 Suggestion: Move com.ibm.platform from NIO to LUNI
 --

  Key: HARMONY-92
  URL: http://issues.apache.org/jira/browse/HARMONY-92
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Richard Liang
  Attachments: 06.remove-obsolete.sh, new.refactor.tar.gz, 
 refactor_platform.zip

 Hello Tim,
 As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages 
 com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As 
 these packages are used by java.net, as well as java.nio.channels. I will 
 post the proposed fix soon :-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-171) Move more shared code from win/linux natives.

2006-03-05 Thread Mark Hindess (JIRA)
Move more shared code from win/linux natives.
-

 Key: HARMONY-171
 URL: http://issues.apache.org/jira/browse/HARMONY-171
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Minor


Thanks to Oliver's changes (HARMONY-155) there are now more identical files in 
the win/linux native trees.  I'll attach a patch to move them to the shared 
tree.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-171) Move more shared code from win/linux natives.

2006-03-05 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-171?page=all ]

Mark Hindess updated HARMONY-171:
-

Attachment: 01.shared.moves.sh
02.shared.diff

The 01 script moves the files and the 02 diff will then fix up the makefiles to 
pick up the files from the shared tree.  (Note this patch assumes that my 
changes in HARMONY-92 have been applied - otherwise there are rejects in the 
luni makefile.)


 Move more shared code from win/linux natives.
 -

  Key: HARMONY-171
  URL: http://issues.apache.org/jira/browse/HARMONY-171
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Minor
  Attachments: 01.shared.moves.sh, 02.shared.diff

 Thanks to Oliver's changes (HARMONY-155) there are now more identical files 
 in the win/linux native trees.  I'll attach a patch to move them to the 
 shared tree.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-167) java.io.ObjectStreamField.getUnshared() should be isUnshared()

2006-03-04 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-167?page=all ]

Mark Hindess updated HARMONY-167:
-

Attachment: getunshared.should.be.isunshared.diff

Trivial rename of getUnshared() to isUnshared().


 java.io.ObjectStreamField.getUnshared() should be isUnshared()
 --

  Key: HARMONY-167
  URL: http://issues.apache.org/jira/browse/HARMONY-167
  Project: Harmony
 Type: Bug
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Minor
  Attachments: getunshared.should.be.isunshared.diff

 According to the spec there should be an isUnshared() method.  There is a 
 getUnshared() method which isn't in the spec so I assume this is an error?  
 Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-167) java.io.ObjectStreamField.getUnshared() should be isUnshared()

2006-03-04 Thread Mark Hindess (JIRA)
java.io.ObjectStreamField.getUnshared() should be isUnshared()
--

 Key: HARMONY-167
 URL: http://issues.apache.org/jira/browse/HARMONY-167
 Project: Harmony
Type: Bug
  Components: Classlib  
Reporter: Mark Hindess
Priority: Minor


According to the spec there should be an isUnshared() method.  There is a 
getUnshared() method which isn't in the spec so I assume this is an error?  
Will attach a patch.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-157) snapshot tar.gz has wrong permissions on java executable

2006-03-02 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-157?page=all ]

Mark Hindess updated HARMONY-157:
-

Attachment: snapshot.file.mode.fix.diff

Fixes mode of deploy/jre/bin/java in snapshot tar.


 snapshot tar.gz has wrong permissions on java executable
 

  Key: HARMONY-157
  URL: http://issues.apache.org/jira/browse/HARMONY-157
  Project: Harmony
 Type: Bug
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Minor
  Attachments: snapshot.file.mode.fix.diff

 I'll attach a patch to fix the snapshot target make/build.xml.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-157) snapshot tar.gz has wrong permissions on java executable

2006-03-02 Thread Mark Hindess (JIRA)
snapshot tar.gz has wrong permissions on java executable


 Key: HARMONY-157
 URL: http://issues.apache.org/jira/browse/HARMONY-157
 Project: Harmony
Type: Bug
  Components: Classlib  
Reporter: Mark Hindess
Priority: Minor
 Attachments: snapshot.file.mode.fix.diff

I'll attach a patch to fix the snapshot target make/build.xml.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-145) windows natives should use the shared files created by HARMONY-132

2006-03-01 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-145?page=all ]

Mark Hindess updated HARMONY-145:
-

Attachment: win.move.to.shared.auth.makefile

Oops.  I accidentally missed the auth/makefile changes from the first patch.  
This patch fixes that oversight.
(md5sun=795a2d34f282c4d26798e3543aaf73f2)


 windows natives should use the shared files created by HARMONY-132
 --

  Key: HARMONY-145
  URL: http://issues.apache.org/jira/browse/HARMONY-145
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: win.move.to.shared, win.move.to.shared.auth.makefile

 The windows native build should be changed to share the common files created 
 by HARMONY-132.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-131) More extensive refactoring of linux makefiles

2006-03-01 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-131?page=comments#action_12368331 
] 

Mark Hindess commented on HARMONY-131:
--

Looks good. Thanks Tim.


 More extensive refactoring of linux makefiles
 -

  Key: HARMONY-131
  URL: http://issues.apache.org/jira/browse/HARMONY-131
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: linux.makefile.refactoring

 There's still a lot of duplication in the linux makefiles.  I've attempted to 
 remove as much as possible.  I'l attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-144) Refactoring of windows makefiles.

2006-03-01 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-144?page=comments#action_12368333 
] 

Mark Hindess commented on HARMONY-144:
--

Looks good.


 Refactoring of windows makefiles.
 -

  Key: HARMONY-144
  URL: http://issues.apache.org/jira/browse/HARMONY-144
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: win.makefile.refactoring

 There's still a lot of duplication in the linux makefiles. I've attempted to 
 remove as much as possible. I'l attach a patch shortly.   This is the windows 
 equivalent of HARMONY-131.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-145) windows natives should use the shared files created by HARMONY-132

2006-03-01 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-145?page=comments#action_12368335 
] 

Mark Hindess commented on HARMONY-145:
--

Looks good.


 windows natives should use the shared files created by HARMONY-132
 --

  Key: HARMONY-145
  URL: http://issues.apache.org/jira/browse/HARMONY-145
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: win.move.to.shared, win.move.to.shared.auth.makefile

 The windows native build should be changed to share the common files created 
 by HARMONY-132.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-144) Refactoring of windows makefiles.

2006-02-28 Thread Mark Hindess (JIRA)
Refactoring of windows makefiles.
-

 Key: HARMONY-144
 URL: http://issues.apache.org/jira/browse/HARMONY-144
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


There's still a lot of duplication in the linux makefiles. I've attempted to 
remove as much as possible. I'l attach a patch shortly.   This is the windows 
equivalent of HARMONY-131.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-144) Refactoring of windows makefiles.

2006-02-28 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-144?page=all ]

Mark Hindess updated HARMONY-144:
-

Attachment: win.makefile.refactoring

Refactoring to make it easier to make the shared code changes. 
(md5sum=374799bd5d3569cdf8777fb856361f5d)


 Refactoring of windows makefiles.
 -

  Key: HARMONY-144
  URL: http://issues.apache.org/jira/browse/HARMONY-144
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: win.makefile.refactoring

 There's still a lot of duplication in the linux makefiles. I've attempted to 
 remove as much as possible. I'l attach a patch shortly.   This is the windows 
 equivalent of HARMONY-131.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-136) Cannot make libvmi.so and libhytext.so on linux

2006-02-27 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-136?page=comments#action_12367930 
] 

Mark Hindess commented on HARMONY-136:
--

I can reproduce this on make v3.79.1 but not on v3.80.  I'm pretty sure it must 
be a bug in the make parser.  It's falling over on the --start-group \\r\n 
sequence which also appears in most of the other dll makefiles.  A trivial 
change such as joining --start-group \\r\n -lhyzip \\r\n to a the single line 
--start-group -lhyzip \\r\n fixes the problem.

On the plus side, this problem occur when I use the latest trunk with my 
outstanding JIRA patches applied.  But I don't think this is something we can 
easily code to avoid so it might be best upgrading anyway.

Just grabbing ftp://ftp.gnu.org/gnu/make/make-3.80.tar.bz2 and replacing 
/usr/bin/make with a version built from that source should help avoid this kind 
of problem in future.


 Cannot make libvmi.so and libhytext.so on linux
 ---

  Key: HARMONY-136
  URL: http://issues.apache.org/jira/browse/HARMONY-136
  Project: Harmony
 Type: Bug
   Components: Classlib
 Reporter: Richard Liang


 Hello,
 When trying to build Harmony native code on my redhat linux (RHEL 3), I fail 
 to make the libvmi.so. But after I convert the makefile(revision=379478) to 
 unix format using dos2unix, the make is successful. The same problem occurs 
 in module text.
 in /native-src/linux.IA32/vmi/
 issue command: make 
 output:
 cc -fpic  -DLINUX -D_REENTRANT -O1 -march=pentium3 -DIPv6_FUNCTION_SUPPORT  
 -DHYX86 -I../include-c -o vmi_copyright.o vmi_copyright.c
 cc -fpic  -DLINUX -D_REENTRANT -O1 -march=pentium3 -DIPv6_FUNCTION_SUPPORT  
 -DHYX86 -I../include-c -o vmi.o vmi.c
 cc  -shared  -Wl,-Map=vmi.map \
 -Wl,--version-script,vmi.exp -Wl,-soname=libvmi.so \
  -L.  -L../lib -L.. -o ../libvmi.so \
 vmi_copyright.o vmi.o -Xlinker --start-group \
 : No such file or directory
 make: *** [../libvmi.so] Error 1
 issue command: dos2unix makefile
 issue command: make
 output:
 cc  -shared  -Wl,-Map=vmi.map \
 -Wl,--version-script,vmi.exp -Wl,-soname=libvmi.so \
  -L.  -L../lib -L.. -o ../libvmi.so \
 vmi_copyright.o vmi.o -Xlinker --start-group \
 -lhyzip \
 -lhypool -Xlinker --end-group  -lc -lm -ldl

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-135) unnecessary inconsistencies between linux and windows code

2006-02-27 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-135?page=comments#action_12367966 
] 

Mark Hindess commented on HARMONY-135:
--

Looks as expected.


 unnecessary inconsistencies between linux and windows code
 --

  Key: HARMONY-135
  URL: http://issues.apache.org/jira/browse/HARMONY-135
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: win.linux.inconsistencies

 There are a few unnecessary inconsistencies between the linux and windows 
 code that really should be the same. Patch to follow.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-130) linux.ia32 auth natives are build as a background task

2006-02-27 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-130?page=comments#action_12367967 
] 

Mark Hindess commented on HARMONY-130:
--

That's better.  Now it actually stops if make in auth breaks.


 linux.ia32 auth natives are build as a background task
 --

  Key: HARMONY-130
  URL: http://issues.apache.org/jira/browse/HARMONY-130
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: do.not.background.auth.make.diff

 I was going to suggest simply changing the single '' to a double '' in the 
 line :
   ( cd auth  $(MAKE)   cd .. )
 but since the brackets start a subshell then the cd .. is redundant so I'll 
 submit a patch to remove them and fix the bug.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-133) missing declaration of abort in linux native sig/jsiglinux.c

2006-02-27 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-133?page=comments#action_12368001 
] 

Mark Hindess commented on HARMONY-133:
--

That's fixed it. Thanks.



 missing declaration of abort in linux native sig/jsiglinux.c
 

  Key: HARMONY-133
  URL: http://issues.apache.org/jira/browse/HARMONY-133
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: missing.abort.function.declaration

 Just spotted this trivial to fix warning while working on the linux natives.  
 Patch to follow.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-134) uninitialised variables in goto bail code path in linux native launcher/main.c

2006-02-27 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-134?page=comments#action_12368019 
] 

Mark Hindess commented on HARMONY-134:
--

Looks good. Thanks Tim.


 uninitialised variables in goto bail code path in linux native 
 launcher/main.c
 

  Key: HARMONY-134
  URL: http://issues.apache.org/jira/browse/HARMONY-134
  Project: Harmony
 Type: Bug
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: linux.uninitialised.variables

 Another trivial issue spotted while working on the linux natives.  The 
 variables vmiPath and propertiesFileName are used uninitialised if one of the 
 early goto bail code paths is taken.  Patch to follow.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-125) Removed duplicate header files.

2006-02-27 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-125?page=comments#action_12368079 
] 

Mark Hindess commented on HARMONY-125:
--

Looks good. Thanks Tim.


 Removed duplicate header files.
 ---

  Key: HARMONY-125
  URL: http://issues.apache.org/jira/browse/HARMONY-125
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial


 The header files:
   win.IA32/archive/jcl.h
   win.IA32/math/jcl.h
   linux.IA32/nio/jcl.h
 are duplicates of the *.IA32/common/jcl.h header files and can be removed 
 without affecting the resulting code.
 I wont attach a patch since it's too trivial.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-131) More extensive refactoring of linux makefiles

2006-02-26 Thread Mark Hindess (JIRA)
More extensive refactoring of linux makefiles
-

 Key: HARMONY-131
 URL: http://issues.apache.org/jira/browse/HARMONY-131
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


There's still a lot of duplication in the linux makefiles.  I've attempted to 
remove as much as possible.  I'l attach a patch shortly.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-131) More extensive refactoring of linux makefiles

2006-02-26 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-131?page=all ]

Mark Hindess updated HARMONY-131:
-

Attachment: linux.makefile.refactoring

I wanted to remove as much redundancy as possible while only using make 
variables that are common to both GNU make and nmake.  In order to do this I 
renamed the hy*.exp file to libhy*.exp to match the basename of the matching 
libhy*.so file.  I also
dropped making the vmi.map file though I can put this back if we need it later.
(md5sum=772e1aa8072e9e2f2107cb66307ba309)


 More extensive refactoring of linux makefiles
 -

  Key: HARMONY-131
  URL: http://issues.apache.org/jira/browse/HARMONY-131
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: linux.makefile.refactoring

 There's still a lot of duplication in the linux makefiles.  I've attempted to 
 remove as much as possible.  I'l attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-132) Move shared native code to out of linux tree

2006-02-26 Thread Mark Hindess (JIRA)
Move shared native code to out of linux tree


 Key: HARMONY-132
 URL: http://issues.apache.org/jira/browse/HARMONY-132
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


There are 11 files that are identical between the linux and windows trees.  
There are a further 81 files that are identical if you ignore comments and 
whitespace.  These should be moved to a shared tree (I would use common but we 
have a common subdirectory and that would get confusing.)

This task is the first half of the work - that is, moving the code out of the 
linux tree to a shared tree.  There's not much benefit until the windows native 
makefiles are updated too but I'll get to that soon.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-132) Move shared native code to out of linux tree

2006-02-26 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-132?page=all ]

Mark Hindess updated HARMONY-132:
-

Attachment: linux.move.to.shared

This patch moves the 92 identical files out of the linux tree to a new 
shared tree and modifies the linux makefiles accordingly.  It uses one GNU 
make specific macro function, notdir, which we could do without but would 
mean defining an extra variable in the makefiles in each of the sub-directories 
- which I guess I'll have to do on windows since there isn't an equivalent.

(md5sum=d9af4b756778e4743494f0d3ded8)


 Move shared native code to out of linux tree
 

  Key: HARMONY-132
  URL: http://issues.apache.org/jira/browse/HARMONY-132
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: linux.move.to.shared

 There are 11 files that are identical between the linux and windows trees.  
 There are a further 81 files that are identical if you ignore comments and 
 whitespace.  These should be moved to a shared tree (I would use common but 
 we have a common subdirectory and that would get confusing.)
 This task is the first half of the work - that is, moving the code out of the 
 linux tree to a shared tree.  There's not much benefit until the windows 
 native makefiles are updated too but I'll get to that soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-133) missing declaration of abort in linux native sig/jsiglinux.c

2006-02-26 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-133?page=all ]

Mark Hindess updated HARMONY-133:
-

Attachment: missing.abort.function.declaration

Include stdlib.h to pick up abort() declaration. 
(md5sum=79671e528d2d9c312d5f9280f5c52886)


 missing declaration of abort in linux native sig/jsiglinux.c
 

  Key: HARMONY-133
  URL: http://issues.apache.org/jira/browse/HARMONY-133
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: missing.abort.function.declaration

 Just spotted this trivial to fix warning while working on the linux natives.  
 Patch to follow.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-134) uninitialised variables in goto bail code path in linux native launcher/main.c

2006-02-26 Thread Mark Hindess (JIRA)
uninitialised variables in goto bail code path in linux native launcher/main.c


 Key: HARMONY-134
 URL: http://issues.apache.org/jira/browse/HARMONY-134
 Project: Harmony
Type: Bug
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


Another trivial issue spotted while working on the linux natives.  The 
variables vmiPath and propertiesFileName are used uninitialised if one of the 
early goto bail code paths is taken.  Patch to follow.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-134) uninitialised variables in goto bail code path in linux native launcher/main.c

2006-02-26 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-134?page=all ]

Mark Hindess updated HARMONY-134:
-

Attachment: linux.uninitialised.variables

Oops.  Forgot this affects windows too.  So this patch fixes windows and linux 
code.  It initialises the two variables to NULL.  (I also add brackets to 
around a few assignments in if/while conditions to remove to compiler warnings.
(md5sum=256e23dbf5b16660c8541b7515a66582)


 uninitialised variables in goto bail code path in linux native 
 launcher/main.c
 

  Key: HARMONY-134
  URL: http://issues.apache.org/jira/browse/HARMONY-134
  Project: Harmony
 Type: Bug
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: linux.uninitialised.variables

 Another trivial issue spotted while working on the linux natives.  The 
 variables vmiPath and propertiesFileName are used uninitialised if one of the 
 early goto bail code paths is taken.  Patch to follow.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-135) unnecessary inconsistencies between linux and windows code

2006-02-26 Thread Mark Hindess (JIRA)
unnecessary inconsistencies between linux and windows code
--

 Key: HARMONY-135
 URL: http://issues.apache.org/jira/browse/HARMONY-135
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial
 Attachments: win.linux.inconsistencies

There are a few unnecessary inconsistencies between the linux and windows code 
that really should be the same. Patch to follow.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-135) unnecessary inconsistencies between linux and windows code

2006-02-26 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-135?page=all ]

Mark Hindess updated HARMONY-135:
-

Attachment: win.linux.inconsistencies

Trivial fixes.  (md5sum=9d8c09a39d39a40780a139777220d4d8)

 unnecessary inconsistencies between linux and windows code
 --

  Key: HARMONY-135
  URL: http://issues.apache.org/jira/browse/HARMONY-135
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: win.linux.inconsistencies

 There are a few unnecessary inconsistencies between the linux and windows 
 code that really should be the same. Patch to follow.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-115) set appropriate svn:ignore properties

2006-02-25 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-115?page=all ]

Mark Hindess updated HARMONY-115:
-

Attachment: svn.ignore.tar.gz

Sorry, Tim.  I was using a tar file to copy files to/from my windows test box 
and I must have uploaded that tar rather than the full one in error.  This one 
contains the remaining svn.ignore files and the script. 
(md5sum=7d0877ca0a98fae9037d67bc9826ee72)


 set appropriate svn:ignore properties
 -

  Key: HARMONY-115
  URL: http://issues.apache.org/jira/browse/HARMONY-115
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: svn.ig.tar.gz, svn.ignore.tar.gz

 We should set svn:ignore properties to ignore generated files so that svn 
 status output is less verbose.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-129) README should not mention the old native-src/*/build.log file

2006-02-25 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-129?page=comments#action_12367816 
] 

Mark Hindess commented on HARMONY-129:
--

Looks good. Thanks.


 README should not mention the old native-src/*/build.log file
 -

  Key: HARMONY-129
  URL: http://issues.apache.org/jira/browse/HARMONY-129
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: fix.readme.to.reflect.build.log.removal.diff

 I'll attach a patch to fix the README.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-128) windows makefile housekeeping

2006-02-25 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-128?page=comments#action_12367817 
] 

Mark Hindess commented on HARMONY-128:
--

Looks good.


 windows makefile housekeeping
 -

  Key: HARMONY-128
  URL: http://issues.apache.org/jira/browse/HARMONY-128
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: win.makefile.housekeeping.diff

 I've cleaned up the windows makefiles to make the changes to the linux ones.  
 I'll attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-112) native-src/build.xml should have clean-overlay-oss target

2006-02-24 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-112?page=comments#action_12367643 
] 

Mark Hindess commented on HARMONY-112:
--

Looks good.

Since clean wasn't really complete before it's probably best if people make 
sure they manually wipe and recheck out both the zlib and fdlibm directories to 
avoid picking up obsolete files.

(Aside: when looking at the comment history I see the text I'll create the 
svn:ignore proper200 OKhe 'dist' dirs.. ;-( )


 native-src/build.xml should have clean-overlay-oss target
 -

  Key: HARMONY-112
  URL: http://issues.apache.org/jira/browse/HARMONY-112
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
  Attachments: improved.native.clean.diff

 There should really be a clean-overlay-oss target to remove the files 
 generated by the overlay-oss target.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-125) Removed duplicate header files.

2006-02-24 Thread Mark Hindess (JIRA)
Removed duplicate header files.
---

 Key: HARMONY-125
 URL: http://issues.apache.org/jira/browse/HARMONY-125
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


The header files:

  win.IA32/archive/jcl.h
  win.IA32/math/jcl.h
  linux.IA32/nio/jcl.h

are duplicates of the *.IA32/common/jcl.h header files and can be removed 
without affecting the resulting code.

I wont attach a patch since it's too trivial.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-126) fdlbm and zlib clean is incomplete

2006-02-24 Thread Mark Hindess (JIRA)
fdlbm and zlib clean is incomplete
--

 Key: HARMONY-126
 URL: http://issues.apache.org/jira/browse/HARMONY-126
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


Oops.  The clean targets are incomplete after HARMONY-116.  Sorry.
Will attach a patch.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-126) fdlbm and zlib clean is incomplete

2006-02-24 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-126?page=all ]

Mark Hindess updated HARMONY-126:
-

Attachment: fix.makefiles.to.remove.dist.object.files.diff

This patch fixes my oversight of not cleaning {zlib,fdlibm}/dist/*.{o,obj}.  
(md5sum=16cc8589ce738e4891471a1b3d86c1ac)

 fdlbm and zlib clean is incomplete
 --

  Key: HARMONY-126
  URL: http://issues.apache.org/jira/browse/HARMONY-126
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: fix.makefiles.to.remove.dist.object.files.diff

 Oops.  The clean targets are incomplete after HARMONY-116.  Sorry.
 Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-126) fdlbm and zlib clean is incomplete

2006-02-24 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-126?page=comments#action_12367656 
] 

Mark Hindess commented on HARMONY-126:
--

Looks good.  At least one of us spotted it before anyone else noticed. ;-)


 fdlbm and zlib clean is incomplete
 --

  Key: HARMONY-126
  URL: http://issues.apache.org/jira/browse/HARMONY-126
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: fix.makefiles.to.remove.dist.object.files.diff

 Oops.  The clean targets are incomplete after HARMONY-116.  Sorry.
 Will attach a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-128) windows makefile housekeeping

2006-02-24 Thread Mark Hindess (JIRA)
windows makefile housekeeping
-

 Key: HARMONY-128
 URL: http://issues.apache.org/jira/browse/HARMONY-128
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


I've cleaned up the windows makefiles to make the changes to the linux ones.  
I'll attach a patch shortly.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-129) README should not mention the old native-src/*/build.log file

2006-02-24 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-129?page=all ]

Mark Hindess updated HARMONY-129:
-

Attachment: fix.readme.to.reflect.build.log.removal.diff

I suppose I could have removed the example completely but it seemed wrong to 
remove potentially useful information.
(md5sum=40635c3da68bf19b50cf57295c85b0b9)


 README should not mention the old native-src/*/build.log file
 -

  Key: HARMONY-129
  URL: http://issues.apache.org/jira/browse/HARMONY-129
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: fix.readme.to.reflect.build.log.removal.diff

 I'll attach a patch to fix the README.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-130) linux.ia32 auth natives are build as a background task

2006-02-24 Thread Mark Hindess (JIRA)
linux.ia32 auth natives are build as a background task
--

 Key: HARMONY-130
 URL: http://issues.apache.org/jira/browse/HARMONY-130
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


I was going to suggest simply changing the single '' to a double '' in the 
line :

  ( cd auth  $(MAKE)   cd .. )

but since the brackets start a subshell then the cd .. is redundant so I'll 
submit a patch to remove them and fix the bug.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-130) linux.ia32 auth natives are build as a background task

2006-02-24 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-130?page=all ]

Mark Hindess updated HARMONY-130:
-

Attachment: do.not.background.auth.make.diff

Fix background job and clean up redundant cd .. commands. 
(md5sum=e7e0bda74870b56caa283ea1295fe2ff)

 linux.ia32 auth natives are build as a background task
 --

  Key: HARMONY-130
  URL: http://issues.apache.org/jira/browse/HARMONY-130
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: do.not.background.auth.make.diff

 I was going to suggest simply changing the single '' to a double '' in the 
 line :
   ( cd auth  $(MAKE)   cd .. )
 but since the brackets start a subshell then the cd .. is redundant so I'll 
 submit a patch to remove them and fix the bug.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-116) strange exec behaviour with harmony vme/classlib

2006-02-23 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-116?page=all ]

Mark Hindess updated HARMONY-116:
-

Attachment: exec.fix.diff

This patch fixes the issue for me. (md5sum=d5ec952b7accaa98299d2b2063b88d3c)


 strange exec behaviour with harmony vme/classlib
 

  Key: HARMONY-116
  URL: http://issues.apache.org/jira/browse/HARMONY-116
  Project: Harmony
 Type: Bug
  Environment: Linux, VME v1, classlib r379730
 Reporter: Mark Hindess
  Attachments: ExecWithEnvTest.java, exec-path-broken.tar.gz, exec.fix.diff

 I'm seeing very odd behaviour from ant exec tasks that set environment 
 variables - such as the one in the security natives.  The exec is failing 
 with failed to execute command.  Worse still if I create a matching 
 executable in the basedir then that gets executed even if basedir is not in 
 the path.  This would be a potential security problem in other situations.  
 I'll attach a test case shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-116) strange exec behaviour with harmony vme/classlib

2006-02-22 Thread Mark Hindess (JIRA)
strange exec behaviour with harmony vme/classlib


 Key: HARMONY-116
 URL: http://issues.apache.org/jira/browse/HARMONY-116
 Project: Harmony
Type: Bug
 Environment: Linux, VME v1, classlib r379730
Reporter: Mark Hindess


I'm seeing very odd behaviour from ant exec tasks that set environment 
variables - such as the one in the security natives.  The exec is failing with 
failed to execute command.  Worse still if I create a matching executable in 
the basedir then that gets executed even if basedir is not in the path.  This 
would be a potential security problem in other situations.  I'll attach a test 
case shortly.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-116) strange exec behaviour with harmony vme/classlib

2006-02-22 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-116?page=all ]

Mark Hindess updated HARMONY-116:
-

Attachment: exec-path-broken.tar.gz

When running ant on the sun jvm gcc is correctly executed both times.  Running 
ant on harmony then the failure case executes the wrong command (or just fails 
if you remove the dummy gcc from the basedir).


 strange exec behaviour with harmony vme/classlib
 

  Key: HARMONY-116
  URL: http://issues.apache.org/jira/browse/HARMONY-116
  Project: Harmony
 Type: Bug
  Environment: Linux, VME v1, classlib r379730
 Reporter: Mark Hindess
  Attachments: exec-path-broken.tar.gz

 I'm seeing very odd behaviour from ant exec tasks that set environment 
 variables - such as the one in the security natives.  The exec is failing 
 with failed to execute command.  Worse still if I create a matching 
 executable in the basedir then that gets executed even if basedir is not in 
 the path.  This would be a potential security problem in other situations.  
 I'll attach a test case shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-116) strange exec behaviour with harmony vme/classlib

2006-02-22 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-116?page=all ]

Mark Hindess updated HARMONY-116:
-

Attachment: ExecWithEnvTest.java

Narrowed this down to a simpler test case.  On RI I get:

bash$ sun java ExecWithEnvTest
java version 1.4.2_05
java version 1.4.2_05

and on Harmony I get:

bash$ hy java ExecWithEnvTest
java version 1.4.2 (subset)
java.io.IOException: Unable to start program
at com.ibm.oti.lang.SystemProcess.create(SystemProcess.java:153)
at java.lang.Runtime.exec(Runtime.java:100)
at java.lang.Runtime.exec(Runtime.java:69)
at ExecWithEnvTest.run(ExecWithEnvTest.java:24)
at ExecWithEnvTest.main(ExecWithEnvTest.java:7)


 strange exec behaviour with harmony vme/classlib
 

  Key: HARMONY-116
  URL: http://issues.apache.org/jira/browse/HARMONY-116
  Project: Harmony
 Type: Bug
  Environment: Linux, VME v1, classlib r379730
 Reporter: Mark Hindess
  Attachments: ExecWithEnvTest.java, exec-path-broken.tar.gz

 I'm seeing very odd behaviour from ant exec tasks that set environment 
 variables - such as the one in the security natives.  The exec is failing 
 with failed to execute command.  Worse still if I create a matching 
 executable in the basedir then that gets executed even if basedir is not in 
 the path.  This would be a potential security problem in other situations.  
 I'll attach a test case shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-117) minimal javac using scripts

2006-02-22 Thread Mark Hindess (JIRA)
minimal javac using scripts
---

 Key: HARMONY-117
 URL: http://issues.apache.org/jira/browse/HARMONY-117
 Project: Harmony
Type: New Feature
Reporter: Mark Hindess


As a first approximation of javac perhaps we could just use shell scripts and 
batch files (rather than a binary launcher) to run the eclipse compiler?

(Aside: do we need a tools component in JIRA?)


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-117) minimal javac using scripts

2006-02-22 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-117?page=all ]

Mark Hindess updated HARMONY-117:
-

Attachment: javac
javac.bat

The shell script version should be usable.  Batch files are really not my thing 
and I doubt it handles error codes properly.


 minimal javac using scripts
 ---

  Key: HARMONY-117
  URL: http://issues.apache.org/jira/browse/HARMONY-117
  Project: Harmony
 Type: New Feature
 Reporter: Mark Hindess
  Attachments: javac, javac.bat

 As a first approximation of javac perhaps we could just use shell scripts and 
 batch files (rather than a binary launcher) to run the eclipse compiler?
 (Aside: do we need a tools component in JIRA?)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-118) Separate build and clean phases

2006-02-22 Thread Mark Hindess (JIRA)
Separate build and clean phases
---

 Key: HARMONY-118
 URL: http://issues.apache.org/jira/browse/HARMONY-118
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


It would be nice to be able to do incremental build so the clean and build 
targets should be split.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-118) Separate build and clean phases

2006-02-22 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-118?page=all ]

Mark Hindess updated HARMONY-118:
-

Attachment: splitting.build.and.clean.targets.diff
splitting.build.and.clean.targets.after.oss.clean.applied.diff

I've kept the default as 'clean, build'.  (Saving that argument for another 
day.) The second patch is the same but (hopefully) avoids the clash caused if 
https://issues.apache.org/jira/browse/HARMONY-112 has been applied before you 
get to this.



 Separate build and clean phases
 ---

  Key: HARMONY-118
  URL: http://issues.apache.org/jira/browse/HARMONY-118
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: splitting.build.and.clean.targets.after.oss.clean.applied.diff, 
 splitting.build.and.clean.targets.diff

 It would be nice to be able to do incremental build so the clean and build 
 targets should be split.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-117) minimal javac using scripts

2006-02-22 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-117?page=all ]

Mark Hindess updated HARMONY-117:
-

Attachment: javac

Fixing the stupid argument error.  Thanks Matt.

 minimal javac using scripts
 ---

  Key: HARMONY-117
  URL: http://issues.apache.org/jira/browse/HARMONY-117
  Project: Harmony
 Type: New Feature
 Reporter: Mark Hindess
  Attachments: javac, javac, javac.bat

 As a first approximation of javac perhaps we could just use shell scripts and 
 batch files (rather than a binary launcher) to run the eclipse compiler?
 (Aside: do we need a tools component in JIRA?)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-119) Cleaning up trivial redundant declarations in launcher

2006-02-22 Thread Mark Hindess (JIRA)
Cleaning up trivial redundant declarations in launcher
--

 Key: HARMONY-119
 URL: http://issues.apache.org/jira/browse/HARMONY-119
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


native-src/*/launcher/main.c defines COMPARE_STRINGS but never uses it.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-119) Cleaning up trivial redundant declarations in launcher

2006-02-22 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-119?page=all ]

Mark Hindess updated HARMONY-119:
-

Attachment: remove.unused.defines.diff

 Cleaning up trivial redundant declarations in launcher
 --

  Key: HARMONY-119
  URL: http://issues.apache.org/jira/browse/HARMONY-119
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: remove.unused.defines.diff

 native-src/*/launcher/main.c defines COMPARE_STRINGS but never uses it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-120) -lhycommon is listed twice in linux luni link command

2006-02-22 Thread Mark Hindess (JIRA)
-lhycommon is listed twice in linux luni link command
-

 Key: HARMONY-120
 URL: http://issues.apache.org/jira/browse/HARMONY-120
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


If we were happy assuming GNU make we could avoid inconsistency errors like 
this by deriving the -l options from the library dependency list  with 
something like:

MDLLIBFILES = \
../lib/libhycommon.a ../libhysig.so ../lib/libhyzip.a ../libhyzlib.so \
../lib/libhypool.a ../lib/libhyfdlibm.a ../libhythr.so ../libvmi.so

LIBS = $(subst ../lib,-l,$(subst ../lib/lib,-l,$(basename $(MDLLIBFILES

Patch to remove the duplication is trivial so I wont bother to attach it - just 
delete the second -lhycommon line.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-122) Redundant cd commands in the win.ia32 archive makefile

2006-02-22 Thread Mark Hindess (JIRA)
Redundant cd commands in the win.ia32 archive makefile
--

 Key: HARMONY-122
 URL: http://issues.apache.org/jira/browse/HARMONY-122
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess


We should remove the redundant cd commands. in the 
native-src/win.ia32/archive/makefile.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-122) Redundant cd commands in the win.ia32 archive makefile

2006-02-22 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-122?page=all ]

Mark Hindess updated HARMONY-122:
-

Attachment: remove.redundant.jumping.around.diff

Trivial fix for a trivial problem.  Don't know how it got marked as Major 
priority.  I certainly didn't intend it to be and I can't change it.


 Redundant cd commands in the win.ia32 archive makefile
 --

  Key: HARMONY-122
  URL: http://issues.apache.org/jira/browse/HARMONY-122
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
  Attachments: remove.redundant.jumping.around.diff

 We should remove the redundant cd commands. in the 
 native-src/win.ia32/archive/makefile.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-119) Cleaning up trivial redundant declarations in launcher

2006-02-22 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-119?page=comments#action_12367420 
] 

Mark Hindess commented on HARMONY-119:
--

Looks good.  Thanks.


 Cleaning up trivial redundant declarations in launcher
 --

  Key: HARMONY-119
  URL: http://issues.apache.org/jira/browse/HARMONY-119
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: remove.unused.defines.diff

 native-src/*/launcher/main.c defines COMPARE_STRINGS but never uses it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-108) removing unused targets/variables from linux makefiles

2006-02-21 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-108?page=comments#action_12367208 
] 

Mark Hindess commented on HARMONY-108:
--

Looks as I expected. Thanks Tim.


 removing unused targets/variables from linux makefiles
 --

  Key: HARMONY-108
  URL: http://issues.apache.org/jira/browse/HARMONY-108
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: harmony.remove.unused.targets.and.variables.diff

 We should remove the unused rules for .cpp to .o and .asm to .o (the latter 
 references a script which isn't present).  We should also remove the unused 
 quick and BUILDLIB targets.  I'll attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-110) fixing the clean targets in linux makefiles

2006-02-21 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-110?page=comments#action_12367209 
] 

Mark Hindess commented on HARMONY-110:
--

Looks as I expected. Thanks Tim.

 fixing the clean targets in linux makefiles
 ---

  Key: HARMONY-110
  URL: http://issues.apache.org/jira/browse/HARMONY-110
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: harmony.fix.clean.targets.diff

 The linux makefiles use the actual filename in the clean targets.  It would 
 be more appropriate to use the defined variable name.  Also, the vmi/makefile 
 fails to remove $(LIBNAME).map in the clean target.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (HARMONY-109) reducing the verbose auto-generated variable names in linux makefiles

2006-02-21 Thread Mark Hindess (JIRA)
[ 
http://issues.apache.org/jira/browse/HARMONY-109?page=comments#action_12367210 
] 

Mark Hindess commented on HARMONY-109:
--

Looks as I expected. Thanks Tim.


 reducing the verbose auto-generated variable names in linux makefiles
 -

  Key: HARMONY-109
  URL: http://issues.apache.org/jira/browse/HARMONY-109
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Assignee: Tim Ellison
 Priority: Trivial
  Attachments: harmony.reduce.variables.diff

 The linux makefiles contain multiple variables such as BUILDFILES1, 
 BUILDFILES2, etc.  These should be reduce to single variables.  Also the 
 MDLLIBFILES* variables aren't used in the common/makefile.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-112) native-src/build.xml should have clean-overlay-oss target

2006-02-21 Thread Mark Hindess (JIRA)
native-src/build.xml should have clean-overlay-oss target
-

 Key: HARMONY-112
 URL: http://issues.apache.org/jira/browse/HARMONY-112
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess


There should really be a clean-overlay-oss target to remove the files 
generated by the overlay-oss target.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-112) native-src/build.xml should have clean-overlay-oss target

2006-02-21 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-112?page=all ]

Mark Hindess updated HARMONY-112:
-

Attachment: improved.native.clean.diff

Patch to add clean-overlay-oss target.


 native-src/build.xml should have clean-overlay-oss target
 -

  Key: HARMONY-112
  URL: http://issues.apache.org/jira/browse/HARMONY-112
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
  Attachments: improved.native.clean.diff

 There should really be a clean-overlay-oss target to remove the files 
 generated by the overlay-oss target.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-115) set appropriate svn:ignore properties

2006-02-21 Thread Mark Hindess (JIRA)
set appropriate svn:ignore properties
-

 Key: HARMONY-115
 URL: http://issues.apache.org/jira/browse/HARMONY-115
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


We should set svn:ignore properties to ignore generated files so that svn 
status output is less verbose.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-115) set appropriate svn:ignore properties

2006-02-21 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-115?page=all ]

Mark Hindess updated HARMONY-115:
-

Attachment: svn.ig.tar.gz

Sadly patch doesn't support setting svn properties.  The attached tar.gz 
contains svn.ignore files and trivial script to apply them to the appropriate 
directories (and remove the svn.ignore files).  Best not to run it if you have 
other important files called svn.ignore in your Harmony tree.



 set appropriate svn:ignore properties
 -

  Key: HARMONY-115
  URL: http://issues.apache.org/jira/browse/HARMONY-115
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: svn.ig.tar.gz

 We should set svn:ignore properties to ignore generated files so that svn 
 status output is less verbose.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-108) removing unused targets/variables from linux makefiles

2006-02-20 Thread Mark Hindess (JIRA)
removing unused targets/variables from linux makefiles
--

 Key: HARMONY-108
 URL: http://issues.apache.org/jira/browse/HARMONY-108
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


We should remove the unused rules for .cpp to .o and .asm to .o (the latter 
references a script which isn't present).  We should also remove the unused 
quick and BUILDLIB targets.  I'll attach a patch shortly.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-108) removing unused targets/variables from linux makefiles

2006-02-20 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-108?page=all ]

Mark Hindess updated HARMONY-108:
-

Attachment: harmony.remove.unused.targets.and.variables.diff

(Do deletions really count as a contribution. ;-)


 removing unused targets/variables from linux makefiles
 --

  Key: HARMONY-108
  URL: http://issues.apache.org/jira/browse/HARMONY-108
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: harmony.remove.unused.targets.and.variables.diff

 We should remove the unused rules for .cpp to .o and .asm to .o (the latter 
 references a script which isn't present).  We should also remove the unused 
 quick and BUILDLIB targets.  I'll attach a patch shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-109) reducing the verbose auto-generated variable names in linux makefiles

2006-02-20 Thread Mark Hindess (JIRA)
reducing the verbose auto-generated variable names in linux makefiles
-

 Key: HARMONY-109
 URL: http://issues.apache.org/jira/browse/HARMONY-109
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


The linux makefiles contain multiple variables such as BUILDFILES1, 
BUILDFILES2, etc.  These should be reduce to single variables.  Also the 
MDLLIBFILES* variables aren't used in the common/makefile.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-109) reducing the verbose auto-generated variable names in linux makefiles

2006-02-20 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-109?page=all ]

Mark Hindess updated HARMONY-109:
-

Attachment: harmony.reduce.variables.diff

 reducing the verbose auto-generated variable names in linux makefiles
 -

  Key: HARMONY-109
  URL: http://issues.apache.org/jira/browse/HARMONY-109
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: harmony.reduce.variables.diff

 The linux makefiles contain multiple variables such as BUILDFILES1, 
 BUILDFILES2, etc.  These should be reduce to single variables.  Also the 
 MDLLIBFILES* variables aren't used in the common/makefile.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-110) fixing the clean targets in linux makefiles

2006-02-20 Thread Mark Hindess (JIRA)
fixing the clean targets in linux makefiles
---

 Key: HARMONY-110
 URL: http://issues.apache.org/jira/browse/HARMONY-110
 Project: Harmony
Type: Improvement
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial
 Attachments: harmony.fix.clean.targets.diff

The linux makefiles use the actual filename in the clean targets.  It would be 
more appropriate to use the defined variable name.  Also, the vmi/makefile 
fails to remove $(LIBNAME).map in the clean target.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-110) fixing the clean targets in linux makefiles

2006-02-20 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-110?page=all ]

Mark Hindess updated HARMONY-110:
-

Attachment: harmony.fix.clean.targets.diff

 fixing the clean targets in linux makefiles
 ---

  Key: HARMONY-110
  URL: http://issues.apache.org/jira/browse/HARMONY-110
  Project: Harmony
 Type: Improvement
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: harmony.fix.clean.targets.diff

 The linux makefiles use the actual filename in the clean targets.  It would 
 be more appropriate to use the defined variable name.  Also, the vmi/makefile 
 fails to remove $(LIBNAME).map in the clean target.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (HARMONY-111) classlib snapshot target

2006-02-20 Thread Mark Hindess (JIRA)
classlib snapshot target


 Key: HARMONY-111
 URL: http://issues.apache.org/jira/browse/HARMONY-111
 Project: Harmony
Type: New Feature
  Components: Classlib  
Reporter: Mark Hindess
Priority: Trivial


We need a snapshot target to make this process easier and consistent.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (HARMONY-111) classlib snapshot target

2006-02-20 Thread Mark Hindess (JIRA)
 [ http://issues.apache.org/jira/browse/HARMONY-111?page=all ]

Mark Hindess updated HARMONY-111:
-

Attachment: harmony.snapshot.target.diff

 classlib snapshot target
 

  Key: HARMONY-111
  URL: http://issues.apache.org/jira/browse/HARMONY-111
  Project: Harmony
 Type: New Feature
   Components: Classlib
 Reporter: Mark Hindess
 Priority: Trivial
  Attachments: harmony.snapshot.target.diff

 We need a snapshot target to make this process easier and consistent.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira