[jira] Commented: (HARMONY-37) remove() method of IdentityHashMap works incorrectly
[ http://issues.apache.org/jira/browse/HARMONY-37?page=comments#action_12363586 ] Vladimir Strigun commented on HARMONY-37: - Tim, thanks for the fix. Everything works fine. remove() method of IdentityHashMap works incorrectly Key: HARMONY-37 URL: http://issues.apache.org/jira/browse/HARMONY-37 Project: Harmony Type: Bug Components: Classlib Reporter: Vladimir Strigun Assignee: Tim Ellison Attachments: IdentityHashMapTest.java, IdentityHashMapTest.java When user try to remove unexisting key from empty hashmap, size of object decreased to -1. Testcase for reproducing: import java.util.IdentityHashMap; public class Harmony37 { public static void main(String args[]) { IdentityHashMap hashMap = new IdentityHashMap(); hashMap.remove(unexist); if (hashMap.size() != 0) { System.out.println(FAILED, because size=+hashMap.size()); } } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-37) remove() method of IdentityHashMap works incorrectly
[ http://issues.apache.org/jira/browse/HARMONY-37?page=comments#action_12363416 ] Vladimir Strigun commented on HARMONY-37: - I'll attach regression test for this bug. Here is diff for /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/tests/java/util/AllTests.java : 32a33 suite.addTestSuite(IdentityHashMapTest.class); remove() method of IdentityHashMap works incorrectly Key: HARMONY-37 URL: http://issues.apache.org/jira/browse/HARMONY-37 Project: Harmony Type: Bug Components: Classlib Reporter: Vladimir Strigun When user try to remove unexisting key from empty hashmap, size of object decreased to -1. Testcase for reproducing: import java.util.IdentityHashMap; public class Harmony37 { public static void main(String args[]) { IdentityHashMap hashMap = new IdentityHashMap(); hashMap.remove(unexist); if (hashMap.size() != 0) { System.out.println(FAILED, because size=+hashMap.size()); } } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-37) remove() method of IdentityHashMap works incorrectly
[ http://issues.apache.org/jira/browse/HARMONY-37?page=comments#action_12363462 ] Tim Ellison commented on HARMONY-37: Vladimir, Good test -- thanks. ... and it's worse than that, the IdentityHashMap does not deal with 'null' keys and values properly. Will take a look at it. remove() method of IdentityHashMap works incorrectly Key: HARMONY-37 URL: http://issues.apache.org/jira/browse/HARMONY-37 Project: Harmony Type: Bug Components: Classlib Reporter: Vladimir Strigun Assignee: Tim Ellison Attachments: IdentityHashMapTest.java When user try to remove unexisting key from empty hashmap, size of object decreased to -1. Testcase for reproducing: import java.util.IdentityHashMap; public class Harmony37 { public static void main(String args[]) { IdentityHashMap hashMap = new IdentityHashMap(); hashMap.remove(unexist); if (hashMap.size() != 0) { System.out.println(FAILED, because size=+hashMap.size()); } } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira