Re: [classlib][logging] In applying the LogManager patch...
2006/9/25, Paulex Yang <[EMAIL PROTECTED]>:
Geir Magnusson Jr. wrote:
> ... as suggested by Nikolay, I did run the tests
>
> $ cd modules/logging
> $ ant test
>
> and it was endless stacktraces, both before and after I made the
> modification.
>
> How do I know if I broke anything? I'm going to go forward with the
> patch as I don't see any harm, since Logger.global is supposed to be
> set via getLogger("global") anyway, so subsequent settings shouldn't
> harm.
"ant test" in specific module directory returns "build successfully"
even there is some tests fail, so I prefer to "ant
-Dbuild.module=logging test" in classlib/trunk directory, which will
check the test result and generate test report in html format.
About the logging tests, probably because of the default
java.util.logging.ErrorManager, wihch is used to handle the exception of
associated handlers, and its default behavior is to print the error
message to System.err, the solution I can imagine includes: redefine the
System.err to sth. like /dev/null, or specify a customized ErrorManager.
The first one isn't an option actually - it is just another etreme
opposite to jamming console with stacktraces, and both would lead to
disregard of possible problems. I know there is "build successfull"
summary, but can imagine sutiation when some test crashed but total
result is positive.
So yes, IMHO we need to solve this with custom setup. Especially if
those tests assert error handling inside logging machinery.
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [classlib][logging] In applying the LogManager patch...
Geir Magnusson Jr. wrote:
... as suggested by Nikolay, I did run the tests
$ cd modules/logging
$ ant test
and it was endless stacktraces, both before and after I made the
modification.
How do I know if I broke anything? I'm going to go forward with the
patch as I don't see any harm, since Logger.global is supposed to be
set via getLogger("global") anyway, so subsequent settings shouldn't
harm.
"ant test" in specific module directory returns "build successfully"
even there is some tests fail, so I prefer to "ant
-Dbuild.module=logging test" in classlib/trunk directory, which will
check the test result and generate test report in html format.
About the logging tests, probably because of the default
java.util.logging.ErrorManager, wihch is used to handle the exception of
associated handlers, and its default behavior is to print the error
message to System.err, the solution I can imagine includes: redefine the
System.err to sth. like /dev/null, or specify a customized ErrorManager.
geir
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Paulex Yang
China Software Development Lab
IBM
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [classlib][logging] In applying the LogManager patch...
+1
On Sep 23, 2006, at 8:50 AM, Alexey Varlamov wrote:
Can't we muffle it for good?
2006/9/23, Richard Liang <[EMAIL PROTECTED]>:
On 9/23/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
> ... as suggested by Nikolay, I did run the tests
>
>$ cd modules/logging
>$ ant test
>
> and it was endless stacktraces, both before and after I made the
> modification.
>
> How do I know if I broke anything? I'm going to go forward with
the
> patch as I don't see any harm, since Logger.global is supposed
to be
> set via getLogger("global") anyway, so subsequent settings
shouldn't
> harm.
>
I got the same stacktraces, and it said "BUILD SUCCESSFUL" in the
end.
;-) After a quick looking through the test (SocketHandlerTest), I
found that some tests try to verify some expected exception, in the
mean while the exceptions are delegated to ErrorManager which reports
the exception to System.err.
Running the test on RI, we will also see some error messages (not
stacktraces)
I guess you broke nothing ;-)
Best regards,
Richard
> geir
>
>
>
-
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-
[EMAIL PROTECTED]
> For additional commands, e-mail: harmony-dev-
[EMAIL PROTECTED]
>
>
--
Richard Liang
China Development Lab, IBM
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: harmony-dev-
[EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [classlib][logging] In applying the LogManager patch...
Can't we muffle it for good?
2006/9/23, Richard Liang <[EMAIL PROTECTED]>:
On 9/23/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
> ... as suggested by Nikolay, I did run the tests
>
>$ cd modules/logging
>$ ant test
>
> and it was endless stacktraces, both before and after I made the
> modification.
>
> How do I know if I broke anything? I'm going to go forward with the
> patch as I don't see any harm, since Logger.global is supposed to be
> set via getLogger("global") anyway, so subsequent settings shouldn't
> harm.
>
I got the same stacktraces, and it said "BUILD SUCCESSFUL" in the end.
;-) After a quick looking through the test (SocketHandlerTest), I
found that some tests try to verify some expected exception, in the
mean while the exceptions are delegated to ErrorManager which reports
the exception to System.err.
Running the test on RI, we will also see some error messages (not stacktraces)
I guess you broke nothing ;-)
Best regards,
Richard
> geir
>
>
> -
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
--
Richard Liang
China Development Lab, IBM
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [classlib][logging] In applying the LogManager patch...
On 9/23/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote:
... as suggested by Nikolay, I did run the tests
$ cd modules/logging
$ ant test
and it was endless stacktraces, both before and after I made the
modification.
How do I know if I broke anything? I'm going to go forward with the
patch as I don't see any harm, since Logger.global is supposed to be
set via getLogger("global") anyway, so subsequent settings shouldn't
harm.
I got the same stacktraces, and it said "BUILD SUCCESSFUL" in the end.
;-) After a quick looking through the test (SocketHandlerTest), I
found that some tests try to verify some expected exception, in the
mean while the exceptions are delegated to ErrorManager which reports
the exception to System.err.
Running the test on RI, we will also see some error messages (not stacktraces)
I guess you broke nothing ;-)
Best regards,
Richard
geir
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Richard Liang
China Development Lab, IBM
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
