Re: svn commit: r407780 - in /incubator/harmony/enhanced/classlib/trunk/modules/archive/src: main/java/java/util/jar/Attributes.java test/java/org/apache/harmony/archive/tests/java/util/jar/Attributes

2006-05-21 Thread Mikhail Loenko 

We also agreed to put only internationalized messages and
to have a single catalog by module.

Is there any way to meet all the agreements without rewriting the
internationalization framework?

Thanks,
Mikhail


2006/5/19, Magnusson, Geir [EMAIL PROTECTED]:

And if we didn't, I think we just did :)

--
Geir Magnusson Jr
SSG/MPD
[EMAIL PROTECTED]
+1 203 665 6437

 -Original Message-
 From: Tim Ellison [mailto:[EMAIL PROTECTED]
 Sent: Friday, May 19, 2006 7:03 AM
 To: harmony-dev@incubator.apache.org
 Subject: Re: svn commit: r407780 - in
 /incubator/harmony/enhanced/classlib/trunk/modules/archive/src
 : main/java/java/util/jar/Attributes.java
 test/java/org/apache/harmony/archive/tests/java/util/jar/Attri
 butesTest.java

 [EMAIL PROTECTED] wrote:
 snip
  public void putAll(Map attrib) {
  +if( attrib == null ) {
  +throw new ClassCastException();
  +}

 Shouldn't this have a message?  I thought we agreed that we'd
 add useful
 messages to exceptions.

 Regards,
 Tim

 --

 Tim Ellison ([EMAIL PROTECTED])
 IBM Java technology centre, UK.

 -
 Terms of use : http://incubator.apache.org/harmony/mailing.html
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]


-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r407780 - in /incubator/harmony/enhanced/classlib/trunk/modules/archive/src: main/java/java/util/jar/Attributes.java test/java/org/apache/harmony/archive/tests/java/util/jar/Attributes

2006-05-19 Thread Tim Ellison 
[EMAIL PROTECTED] wrote:
snip
   public void putAll(Map attrib) {
 +if( attrib == null ) {
 +throw new ClassCastException();
 +}

Shouldn't this have a message?  I thought we agreed that we'd add useful
messages to exceptions.

Regards,
Tim

-- 

Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: svn commit: r407780 - in /incubator/harmony/enhanced/classlib/trunk/modules/archive/src: main/java/java/util/jar/Attributes.java test/java/org/apache/harmony/archive/tests/java/util/jar/Attributes

2006-05-19 Thread Magnusson, Geir 
And if we didn't, I think we just did :)

-- 
Geir Magnusson Jr
SSG/MPD
[EMAIL PROTECTED]
+1 203 665 6437  

 -Original Message-
 From: Tim Ellison [mailto:[EMAIL PROTECTED] 
 Sent: Friday, May 19, 2006 7:03 AM
 To: harmony-dev@incubator.apache.org
 Subject: Re: svn commit: r407780 - in 
 /incubator/harmony/enhanced/classlib/trunk/modules/archive/src
 : main/java/java/util/jar/Attributes.java 
 test/java/org/apache/harmony/archive/tests/java/util/jar/Attri
 butesTest.java
 
 [EMAIL PROTECTED] wrote:
 snip
  public void putAll(Map attrib) {
  +if( attrib == null ) {
  +throw new ClassCastException();
  +}
 
 Shouldn't this have a message?  I thought we agreed that we'd 
 add useful
 messages to exceptions.
 
 Regards,
 Tim
 
 -- 
 
 Tim Ellison ([EMAIL PROTECTED])
 IBM Java technology centre, UK.
 
 -
 Terms of use : http://incubator.apache.org/harmony/mailing.html
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 

-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]