[jira] [Commented] (HDFS-4292) Sanity check not correct in RemoteBlockReader2.newBlockReader
[
https://issues.apache.org/jira/browse/HDFS-4292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527209#comment-13527209
]
Hadoop QA commented on HDFS-4292:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12560036/HDFS-4292.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3625//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3625//console
This message is automatically generated.
> Sanity check not correct in RemoteBlockReader2.newBlockReader
> -
>
> Key: HDFS-4292
> URL: https://issues.apache.org/jira/browse/HDFS-4292
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Binglin Chang
>Assignee: Binglin Chang
>Priority: Minor
> Attachments: HDFS-4292.patch
>
>
> {code}
> if ( firstChunkOffset < 0 || firstChunkOffset > startOffset ||
> firstChunkOffset >= (startOffset + checksum.getBytesPerChecksum())) {
> {code}
> should be:
> {code}
> if ( firstChunkOffset < 0 || firstChunkOffset > startOffset ||
> firstChunkOffset <= (startOffset - checksum.getBytesPerChecksum())) {
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4292) Sanity check not correct in RemoteBlockReader2.newBlockReader
[
https://issues.apache.org/jira/browse/HDFS-4292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Binglin Chang updated HDFS-4292:
Attachment: HDFS-4292.patch
> Sanity check not correct in RemoteBlockReader2.newBlockReader
> -
>
> Key: HDFS-4292
> URL: https://issues.apache.org/jira/browse/HDFS-4292
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Binglin Chang
>Assignee: Binglin Chang
>Priority: Minor
> Attachments: HDFS-4292.patch
>
>
> {code}
> if ( firstChunkOffset < 0 || firstChunkOffset > startOffset ||
> firstChunkOffset >= (startOffset + checksum.getBytesPerChecksum())) {
> {code}
> should be:
> {code}
> if ( firstChunkOffset < 0 || firstChunkOffset > startOffset ||
> firstChunkOffset <= (startOffset - checksum.getBytesPerChecksum())) {
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4292) Sanity check not correct in RemoteBlockReader2.newBlockReader
[
https://issues.apache.org/jira/browse/HDFS-4292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Binglin Chang updated HDFS-4292:
Status: Patch Available (was: Open)
> Sanity check not correct in RemoteBlockReader2.newBlockReader
> -
>
> Key: HDFS-4292
> URL: https://issues.apache.org/jira/browse/HDFS-4292
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Binglin Chang
>Assignee: Binglin Chang
>Priority: Minor
> Attachments: HDFS-4292.patch
>
>
> {code}
> if ( firstChunkOffset < 0 || firstChunkOffset > startOffset ||
> firstChunkOffset >= (startOffset + checksum.getBytesPerChecksum())) {
> {code}
> should be:
> {code}
> if ( firstChunkOffset < 0 || firstChunkOffset > startOffset ||
> firstChunkOffset <= (startOffset - checksum.getBytesPerChecksum())) {
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (HDFS-4292) Sanity check not correct in RemoteBlockReader2.newBlockReader
Binglin Chang created HDFS-4292:
---
Summary: Sanity check not correct in
RemoteBlockReader2.newBlockReader
Key: HDFS-4292
URL: https://issues.apache.org/jira/browse/HDFS-4292
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Minor
{code}
if ( firstChunkOffset < 0 || firstChunkOffset > startOffset ||
firstChunkOffset >= (startOffset + checksum.getBytesPerChecksum())) {
{code}
should be:
{code}
if ( firstChunkOffset < 0 || firstChunkOffset > startOffset ||
firstChunkOffset <= (startOffset - checksum.getBytesPerChecksum())) {
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4236) Regression: HDFS-4171 puts artificial limit on username length
[ https://issues.apache.org/jira/browse/HDFS-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527148#comment-13527148 ] Hudson commented on HDFS-4236: -- Integrated in Hadoop-Mapreduce-trunk #1279 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1279/]) HDFS-4236. Remove artificial limit on username length introduced in HDFS-4171. Contributed by Alejandro Abdelnur. (Revision 1418356) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418356 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/UserProvider.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/wsrs/TestUserProvider.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserParam.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java > Regression: HDFS-4171 puts artificial limit on username length > -- > > Key: HDFS-4236 > URL: https://issues.apache.org/jira/browse/HDFS-4236 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.0.3-alpha >Reporter: Allen Wittenauer >Assignee: Alejandro Abdelnur >Priority: Blocker > Labels: regression > Fix For: 2.0.3-alpha > > Attachments: HDFS-4171.patch > > > HDFS-4171 made the invalid assumption that there is a common limit on user > names at the UNIX level. Almost all modern systems, when running under a > 64-bit kernel, use a pointer instead of a char array in the passwd struct. > This makes usernames essentially unlimited. > Additionally, IIRC, the only places where HDFS and the OS interact where the > username is touched is during group lookup. > This limit is artificial and should be removed. There is a very high risk > that we will break users, especially service accounts used for automated > processes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4260) Fix HDFS tests to set test dir to a valid HDFS path as opposed to the local build path
[ https://issues.apache.org/jira/browse/HDFS-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527149#comment-13527149 ] Hudson commented on HDFS-4260: -- Integrated in Hadoop-Mapreduce-trunk #1279 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1279/]) HDFS-4260 Fix HDFS tests to set test dir to a valid HDFS path as opposed to the local build path (Chris Nauroth via Sanjay) (Revision 1418424) Result = SUCCESS sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418424 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextTestHelper.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsCreateMkdir.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsPermission.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsSetUMask.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsSymlink.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHDFSFileContextMainOperations.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemAtHdfsRoot.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemHdfs.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsAtHdfsRoot.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsHdfs.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestFSMainOperationsWebHdfs.java > Fix HDFS tests to set test dir to a valid HDFS path as opposed to the local > build path > -- > > Key: HDFS-4260 > URL: https://issues.apache.org/jira/browse/HDFS-4260 > Project: Hadoop HDFS > Issue Type: Bug > Components: test >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Attachments: HDFS-4260-branch-trunk-win.1.patch, > HDFS-4260-branch-trunk-win.2.patch, HDFS-4260-branch-trunk-win.3.patch > > > Multiple HDFS test suites fail early during initialization on Windows because > of inclusion of the drive spec in the test root path. The ':' gets rejected > as an invalid character by the logic of isValidName. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4171) WebHDFS and HttpFs should accept only valid Unix user names
[ https://issues.apache.org/jira/browse/HDFS-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527147#comment-13527147 ] Hudson commented on HDFS-4171: -- Integrated in Hadoop-Mapreduce-trunk #1279 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1279/]) HDFS-4236. Remove artificial limit on username length introduced in HDFS-4171. Contributed by Alejandro Abdelnur. (Revision 1418356) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418356 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/UserProvider.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/wsrs/TestUserProvider.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserParam.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java > WebHDFS and HttpFs should accept only valid Unix user names > --- > > Key: HDFS-4171 > URL: https://issues.apache.org/jira/browse/HDFS-4171 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.0.2-alpha >Reporter: Harsh J >Assignee: Alejandro Abdelnur > Fix For: 2.0.3-alpha > > Attachments: HDFS-4171.patch, HDFS-4171.patch, HDFS-4171.patch, > HDFS-4171.patch > > > HttpFs tries to use UserProfile.USER_PATTERN to match all usernames before a > doAs impersonation function. This regex is too strict for most usernames, as > it disallows any special character at all. We should relax it more or ditch > needing to match things there. > WebHDFS currently has no such limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4279) NameNode does not initialize generic conf keys when started with -recover
[ https://issues.apache.org/jira/browse/HDFS-4279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527146#comment-13527146 ] Hudson commented on HDFS-4279: -- Integrated in Hadoop-Mapreduce-trunk #1279 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1279/]) HDFS-4279. NameNode does not initialize generic conf keys when started with -recover. Contributed by Colin Patrick McCabe. (Revision 1418559) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418559 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeRecovery.java > NameNode does not initialize generic conf keys when started with -recover > - > > Key: HDFS-4279 > URL: https://issues.apache.org/jira/browse/HDFS-4279 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 2.0.3-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 2.0.3-alpha > > Attachments: HDFS-3236.002.patch > > > This means that configurations that scope the location of the > name/edits/shared edits dirs by nameserice or namenode won't work with `hdfs > namenode -recover` -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4260) Fix HDFS tests to set test dir to a valid HDFS path as opposed to the local build path
[ https://issues.apache.org/jira/browse/HDFS-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527130#comment-13527130 ] Hudson commented on HDFS-4260: -- Integrated in Hadoop-Hdfs-trunk #1248 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1248/]) HDFS-4260 Fix HDFS tests to set test dir to a valid HDFS path as opposed to the local build path (Chris Nauroth via Sanjay) (Revision 1418424) Result = FAILURE sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418424 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextTestHelper.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsCreateMkdir.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsPermission.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsSetUMask.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsSymlink.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHDFSFileContextMainOperations.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemAtHdfsRoot.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemHdfs.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsAtHdfsRoot.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsHdfs.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestFSMainOperationsWebHdfs.java > Fix HDFS tests to set test dir to a valid HDFS path as opposed to the local > build path > -- > > Key: HDFS-4260 > URL: https://issues.apache.org/jira/browse/HDFS-4260 > Project: Hadoop HDFS > Issue Type: Bug > Components: test >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Attachments: HDFS-4260-branch-trunk-win.1.patch, > HDFS-4260-branch-trunk-win.2.patch, HDFS-4260-branch-trunk-win.3.patch > > > Multiple HDFS test suites fail early during initialization on Windows because > of inclusion of the drive spec in the test root path. The ':' gets rejected > as an invalid character by the logic of isValidName. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4171) WebHDFS and HttpFs should accept only valid Unix user names
[ https://issues.apache.org/jira/browse/HDFS-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527128#comment-13527128 ] Hudson commented on HDFS-4171: -- Integrated in Hadoop-Hdfs-trunk #1248 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1248/]) HDFS-4236. Remove artificial limit on username length introduced in HDFS-4171. Contributed by Alejandro Abdelnur. (Revision 1418356) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418356 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/UserProvider.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/wsrs/TestUserProvider.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserParam.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java > WebHDFS and HttpFs should accept only valid Unix user names > --- > > Key: HDFS-4171 > URL: https://issues.apache.org/jira/browse/HDFS-4171 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.0.2-alpha >Reporter: Harsh J >Assignee: Alejandro Abdelnur > Fix For: 2.0.3-alpha > > Attachments: HDFS-4171.patch, HDFS-4171.patch, HDFS-4171.patch, > HDFS-4171.patch > > > HttpFs tries to use UserProfile.USER_PATTERN to match all usernames before a > doAs impersonation function. This regex is too strict for most usernames, as > it disallows any special character at all. We should relax it more or ditch > needing to match things there. > WebHDFS currently has no such limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4236) Regression: HDFS-4171 puts artificial limit on username length
[ https://issues.apache.org/jira/browse/HDFS-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527129#comment-13527129 ] Hudson commented on HDFS-4236: -- Integrated in Hadoop-Hdfs-trunk #1248 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1248/]) HDFS-4236. Remove artificial limit on username length introduced in HDFS-4171. Contributed by Alejandro Abdelnur. (Revision 1418356) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418356 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/UserProvider.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/wsrs/TestUserProvider.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserParam.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java > Regression: HDFS-4171 puts artificial limit on username length > -- > > Key: HDFS-4236 > URL: https://issues.apache.org/jira/browse/HDFS-4236 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.0.3-alpha >Reporter: Allen Wittenauer >Assignee: Alejandro Abdelnur >Priority: Blocker > Labels: regression > Fix For: 2.0.3-alpha > > Attachments: HDFS-4171.patch > > > HDFS-4171 made the invalid assumption that there is a common limit on user > names at the UNIX level. Almost all modern systems, when running under a > 64-bit kernel, use a pointer instead of a char array in the passwd struct. > This makes usernames essentially unlimited. > Additionally, IIRC, the only places where HDFS and the OS interact where the > username is touched is during group lookup. > This limit is artificial and should be removed. There is a very high risk > that we will break users, especially service accounts used for automated > processes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4279) NameNode does not initialize generic conf keys when started with -recover
[ https://issues.apache.org/jira/browse/HDFS-4279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527127#comment-13527127 ] Hudson commented on HDFS-4279: -- Integrated in Hadoop-Hdfs-trunk #1248 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1248/]) HDFS-4279. NameNode does not initialize generic conf keys when started with -recover. Contributed by Colin Patrick McCabe. (Revision 1418559) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418559 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeRecovery.java > NameNode does not initialize generic conf keys when started with -recover > - > > Key: HDFS-4279 > URL: https://issues.apache.org/jira/browse/HDFS-4279 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 2.0.3-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 2.0.3-alpha > > Attachments: HDFS-3236.002.patch > > > This means that configurations that scope the location of the > name/edits/shared edits dirs by nameserice or namenode won't work with `hdfs > namenode -recover` -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4260) Fix HDFS tests to set test dir to a valid HDFS path as opposed to the local build path
[ https://issues.apache.org/jira/browse/HDFS-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527105#comment-13527105 ] Hudson commented on HDFS-4260: -- Integrated in Hadoop-Yarn-trunk #59 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/59/]) HDFS-4260 Fix HDFS tests to set test dir to a valid HDFS path as opposed to the local build path (Chris Nauroth via Sanjay) (Revision 1418424) Result = SUCCESS sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418424 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextTestHelper.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsCreateMkdir.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsPermission.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsSetUMask.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestFcHdfsSymlink.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHDFSFileContextMainOperations.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemAtHdfsRoot.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemHdfs.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsAtHdfsRoot.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsHdfs.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestFSMainOperationsWebHdfs.java > Fix HDFS tests to set test dir to a valid HDFS path as opposed to the local > build path > -- > > Key: HDFS-4260 > URL: https://issues.apache.org/jira/browse/HDFS-4260 > Project: Hadoop HDFS > Issue Type: Bug > Components: test >Affects Versions: 3.0.0, trunk-win >Reporter: Chris Nauroth >Assignee: Chris Nauroth > Attachments: HDFS-4260-branch-trunk-win.1.patch, > HDFS-4260-branch-trunk-win.2.patch, HDFS-4260-branch-trunk-win.3.patch > > > Multiple HDFS test suites fail early during initialization on Windows because > of inclusion of the drive spec in the test root path. The ':' gets rejected > as an invalid character by the logic of isValidName. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4236) Regression: HDFS-4171 puts artificial limit on username length
[ https://issues.apache.org/jira/browse/HDFS-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527104#comment-13527104 ] Hudson commented on HDFS-4236: -- Integrated in Hadoop-Yarn-trunk #59 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/59/]) HDFS-4236. Remove artificial limit on username length introduced in HDFS-4171. Contributed by Alejandro Abdelnur. (Revision 1418356) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418356 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/UserProvider.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/wsrs/TestUserProvider.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserParam.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java > Regression: HDFS-4171 puts artificial limit on username length > -- > > Key: HDFS-4236 > URL: https://issues.apache.org/jira/browse/HDFS-4236 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.0.3-alpha >Reporter: Allen Wittenauer >Assignee: Alejandro Abdelnur >Priority: Blocker > Labels: regression > Fix For: 2.0.3-alpha > > Attachments: HDFS-4171.patch > > > HDFS-4171 made the invalid assumption that there is a common limit on user > names at the UNIX level. Almost all modern systems, when running under a > 64-bit kernel, use a pointer instead of a char array in the passwd struct. > This makes usernames essentially unlimited. > Additionally, IIRC, the only places where HDFS and the OS interact where the > username is touched is during group lookup. > This limit is artificial and should be removed. There is a very high risk > that we will break users, especially service accounts used for automated > processes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4171) WebHDFS and HttpFs should accept only valid Unix user names
[ https://issues.apache.org/jira/browse/HDFS-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527103#comment-13527103 ] Hudson commented on HDFS-4171: -- Integrated in Hadoop-Yarn-trunk #59 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/59/]) HDFS-4236. Remove artificial limit on username length introduced in HDFS-4171. Contributed by Alejandro Abdelnur. (Revision 1418356) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418356 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/UserProvider.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/lib/wsrs/TestUserProvider.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserParam.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java > WebHDFS and HttpFs should accept only valid Unix user names > --- > > Key: HDFS-4171 > URL: https://issues.apache.org/jira/browse/HDFS-4171 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.0.2-alpha >Reporter: Harsh J >Assignee: Alejandro Abdelnur > Fix For: 2.0.3-alpha > > Attachments: HDFS-4171.patch, HDFS-4171.patch, HDFS-4171.patch, > HDFS-4171.patch > > > HttpFs tries to use UserProfile.USER_PATTERN to match all usernames before a > doAs impersonation function. This regex is too strict for most usernames, as > it disallows any special character at all. We should relax it more or ditch > needing to match things there. > WebHDFS currently has no such limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4279) NameNode does not initialize generic conf keys when started with -recover
[ https://issues.apache.org/jira/browse/HDFS-4279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527102#comment-13527102 ] Hudson commented on HDFS-4279: -- Integrated in Hadoop-Yarn-trunk #59 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/59/]) HDFS-4279. NameNode does not initialize generic conf keys when started with -recover. Contributed by Colin Patrick McCabe. (Revision 1418559) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1418559 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeRecovery.java > NameNode does not initialize generic conf keys when started with -recover > - > > Key: HDFS-4279 > URL: https://issues.apache.org/jira/browse/HDFS-4279 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 2.0.3-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 2.0.3-alpha > > Attachments: HDFS-3236.002.patch > > > This means that configurations that scope the location of the > name/edits/shared edits dirs by nameserice or namenode won't work with `hdfs > namenode -recover` -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
