[jira] [Commented] (HDFS-6278) Create HTML5-based UI for SNN

2014-04-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979233#comment-13979233
 ] 

Hadoop QA commented on HDFS-6278:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12641607/HDFS-6278.000.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/6710//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6710//console

This message is automatically generated.

 Create HTML5-based UI for SNN
 -

 Key: HDFS-6278
 URL: https://issues.apache.org/jira/browse/HDFS-6278
 Project: Hadoop HDFS
  Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Haohui Mai
 Attachments: HDFS-6278.000.patch


 This jira proposes to create a HTML5-based UI for SNN, which matches the 
 looks and feels of the current NN UI.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6279) Create new index page for JN / DN

2014-04-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979251#comment-13979251
 ] 

Hadoop QA commented on HDFS-6279:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12641617/HDFS-6279.000.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/6711//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6711//console

This message is automatically generated.

 Create new index page for JN / DN
 -

 Key: HDFS-6279
 URL: https://issues.apache.org/jira/browse/HDFS-6279
 Project: Hadoop HDFS
  Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Haohui Mai
 Attachments: HDFS-6279.000.patch


 This jira proposes to replace the jsp UI of DN / JN to web pages that match 
 the looks and feels of the NN UI.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6210) Support GETACLSTATUS operation in WebImageViewer

2014-04-23 Thread Akira AJISAKA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979268#comment-13979268
 ] 

Akira AJISAKA commented on HDFS-6210:
-

[~wheat9], would you please review the latest patch?

 Support GETACLSTATUS operation in WebImageViewer
 

 Key: HDFS-6210
 URL: https://issues.apache.org/jira/browse/HDFS-6210
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: tools
Affects Versions: 2.5.0
Reporter: Akira AJISAKA
Assignee: Akira AJISAKA
 Attachments: HDFS-6210.2.patch, HDFS-6210.3.patch, HDFS-6210.patch, 
 HDFS-6210.patch


 In HDFS-6170, I found {{GETACLSTATUS}} operation support is also required to 
 execute hdfs dfs -ls to WebImageViewer.
 {code}
 [root@trunk ~]# hdfs dfs -ls webhdfs://localhost:5978/
 14/04/09 11:53:04 WARN util.NativeCodeLoader: Unable to load native-hadoop 
 library for your platform... using builtin-java classes where applicable
 Found 1 items
 ls: Unexpected HTTP response: code=400 != 200, op=GETACLSTATUS, message=Bad 
 Request
 {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6279) Create new index page for JN / DN

2014-04-23 Thread Jing Zhao (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979273#comment-13979273
 ] 

Jing Zhao commented on HDFS-6279:
-

+1

 Create new index page for JN / DN
 -

 Key: HDFS-6279
 URL: https://issues.apache.org/jira/browse/HDFS-6279
 Project: Hadoop HDFS
  Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Haohui Mai
 Attachments: HDFS-6279.000.patch


 This jira proposes to replace the jsp UI of DN / JN to web pages that match 
 the looks and feels of the NN UI.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6278) Create HTML5-based UI for SNN

2014-04-23 Thread Jing Zhao (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979271#comment-13979271
 ] 

Jing Zhao commented on HDFS-6278:
-

Thanks for working on this, [~wheat9]. +1

 Create HTML5-based UI for SNN
 -

 Key: HDFS-6278
 URL: https://issues.apache.org/jira/browse/HDFS-6278
 Project: Hadoop HDFS
  Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Haohui Mai
 Attachments: HDFS-6278.000.patch


 This jira proposes to create a HTML5-based UI for SNN, which matches the 
 looks and feels of the current NN UI.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HDFS-6276) Remove unnecessary conditions and null check

2014-04-23 Thread Suresh Srinivas (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-6276:
--

   Resolution: Fixed
Fix Version/s: 2.5.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

I've committed the patch to trunk and branch-2. Thanks [~jingzhao] for the 
review.

 Remove unnecessary conditions and null check
 

 Key: HDFS-6276
 URL: https://issues.apache.org/jira/browse/HDFS-6276
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
 Fix For: 2.5.0

 Attachments: HDFS-6276.1.patch, HDFS-6276.patch


 The code has many places where null check and other condition checks are 
 unnecessary.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6276) Remove unnecessary conditions and null check

2014-04-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979315#comment-13979315
 ] 

Hudson commented on HDFS-6276:
--

SUCCESS: Integrated in Hadoop-trunk-Commit #5557 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/5557/])
HDFS-6276. Remove unnecessary conditions and null check. Contributed by Suresh 
Srinivas (suresh: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1589586)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataBlockScanner.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/RollingLogsImpl.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/CachePool.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SaveNamespaceCancelledException.java


 Remove unnecessary conditions and null check
 

 Key: HDFS-6276
 URL: https://issues.apache.org/jira/browse/HDFS-6276
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
 Fix For: 2.5.0

 Attachments: HDFS-6276.1.patch, HDFS-6276.patch


 The code has many places where null check and other condition checks are 
 unnecessary.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6271) Rename JournalProtocol to BackupNodeJournalProtocol

2014-04-23 Thread Suresh Srinivas (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979325#comment-13979325
 ] 

Suresh Srinivas commented on HDFS-6271:
---

bq. we should keep concetion consistent as webUI, which shows Standby, not 
backup, so It would be StandbyNodeJournalProtocol.
Standby and BackupNode are two completely different daemons. Please look at 
BackupNode.java code for details and contrast it with Standby which is a state 
of NameNode.

 Rename JournalProtocol to BackupNodeJournalProtocol
 ---

 Key: HDFS-6271
 URL: https://issues.apache.org/jira/browse/HDFS-6271
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Suresh Srinivas

 [~shv], as indicated in earlier comments, JournalProtocol is used only for 
 sending journal to backupnode .Renaming it would make it clear how the 
 protocol is being used and will not conflict with QuorumJournalProtocol.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HDFS-6247) Avoid timeouts for replaceBlock() call by sending intermediate responses to Balancer

2014-04-23 Thread Vinayakumar B (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinayakumar B updated HDFS-6247:


Attachment: HDFS-6247.patch

Removed one more extra daemon to send responses which could eat-up one xceiver. 
sending responses back in {{receivePacket()}} method itself for every 5 seconds.

Please review

 Avoid timeouts for replaceBlock() call by sending intermediate responses to 
 Balancer
 

 Key: HDFS-6247
 URL: https://issues.apache.org/jira/browse/HDFS-6247
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: balancer, datanode
Affects Versions: 2.4.0
Reporter: Vinayakumar B
Assignee: Vinayakumar B
 Attachments: HDFS-6247.patch, HDFS-6247.patch


 Currently there is no response sent from target Datanode to Balancer for the 
 replaceBlock() calls.
 Since the Block movement for balancing is throttled, complete block movement 
 will take time and this could result in timeout at Balancer, which will be 
 trying to read the status message.
  
 To Avoid this during replaceBlock() call in in progress Datanode  can send 
 IN_PROGRESS status messages to Balancer to avoid timeouts and treat 
 BlockMovement as  failed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HDFS-6246) Remove 'dfs.support.append' flag from trunk code

2014-04-23 Thread Vinayakumar B (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979329#comment-13979329
 ] 

Vinayakumar B commented on HDFS-6246:
-

Yes Uma, failure seems to be unrelated to this. 

It seems due to patch automation. HADOOP-10532 has been raised to address this.

+1 for the current patch.

 Remove 'dfs.support.append' flag from trunk code
 

 Key: HDFS-6246
 URL: https://issues.apache.org/jira/browse/HDFS-6246
 Project: Hadoop HDFS
  Issue Type: Improvement
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
Priority: Minor
 Attachments: HDFS-6246.patch


 we added dfs.support.append' flag long ago to control the issues with append 
 feature.  Now in trunk and hadoop-2, by default we enabled and using it for 
 long time.  
 So, I propose to remove that property now as we don't see any issue by 
 enabling the append feature always. 
 Thoughts?



--
This message was sent by Atlassian JIRA
(v6.2#6252)


<    1   2