[jira] [Resolved] (HDFS-17376) Distcp creates Factor 1 replication file on target if Source is EC
[ https://issues.apache.org/jira/browse/HDFS-17376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen O'Donnell resolved HDFS-17376. -- Fix Version/s: 3.5.0 Resolution: Fixed > Distcp creates Factor 1 replication file on target if Source is EC > -- > > Key: HDFS-17376 > URL: https://issues.apache.org/jira/browse/HDFS-17376 > Project: Hadoop HDFS > Issue Type: Bug > Components: distcp >Affects Versions: 3.3.6 >Reporter: Sadanand Shenoy >Assignee: Sadanand Shenoy >Priority: Major > Labels: pull-request-available > Fix For: 3.5.0 > > > If the source file is EC, distcp without preserve option creates a 1 > replication file (this is not intended). > This is because for an EC file getReplication() always return 1 . Instead it > should create the file as per the default replication on the target. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17376) Distcp creates Factor 1 replication file on target if Source is EC
[ https://issues.apache.org/jira/browse/HDFS-17376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816159#comment-17816159 ] ASF GitHub Bot commented on HDFS-17376: --- sodonnel merged PR #6540: URL: https://github.com/apache/hadoop/pull/6540 > Distcp creates Factor 1 replication file on target if Source is EC > -- > > Key: HDFS-17376 > URL: https://issues.apache.org/jira/browse/HDFS-17376 > Project: Hadoop HDFS > Issue Type: Bug > Components: distcp >Affects Versions: 3.3.6 >Reporter: Sadanand Shenoy >Assignee: Sadanand Shenoy >Priority: Major > Labels: pull-request-available > > If the source file is EC, distcp without preserve option creates a 1 > replication file (this is not intended). > This is because for an EC file getReplication() always return 1 . Instead it > should create the file as per the default replication on the target. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17376) Distcp creates Factor 1 replication file on target if Source is EC
[
https://issues.apache.org/jira/browse/HDFS-17376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816138#comment-17816138
]
ASF GitHub Bot commented on HDFS-17376:
---
hadoop-yetus commented on PR #6540:
URL: https://github.com/apache/hadoop/pull/6540#issuecomment-1936233134
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 44s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 44m 53s | | trunk passed |
| +1 :green_heart: | compile | 0m 29s | | trunk passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 0m 26s | | trunk passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | checkstyle | 0m 29s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 31s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 32s | | trunk passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 28s | | trunk passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | spotbugs | 0m 51s | | trunk passed |
| +1 :green_heart: | shadedclient | 33m 56s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 22s | | the patch passed |
| +1 :green_heart: | compile | 0m 21s | | the patch passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 0m 21s | | the patch passed |
| +1 :green_heart: | compile | 0m 17s | | the patch passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | javac | 0m 17s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 16s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 24s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | spotbugs | 0m 50s | | the patch passed |
| +1 :green_heart: | shadedclient | 34m 56s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 16m 9s | | hadoop-distcp in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 33s | | The patch does not
generate ASF License warnings. |
| | | 142m 51s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.44 ServerAPI=1.44 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6540/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6540 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 2d8d5dde3f11 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2
15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / e343c4c3a6e7585f574caa1f63a88e5d8275fa35 |
| Default Java | Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
/usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6540/2/testReport/ |
| Max. process+thread count | 699 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6540/2/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Distcp creates Factor 1 replication file on target if Source is EC
> ---
[jira] [Updated] (HDFS-17378) Missing operationType for some operations in authorizer
[
https://issues.apache.org/jira/browse/HDFS-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Francke updated HDFS-17378:
Description:
In HDFS-14743 the operationType was implemented as a thread-local, which
requires the caller to set the thread-local before calling the
{{AccessControlEnforcer}} interface.
Most operations will set the operationType to a String, but some operations set
it to `null`.
This causes the FSPermissionChecker to always call the old (deprecated)
{{AccessControlEnforcer.checkPermission}} API (see
[https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java#L431])
Instead of setting the operationType to `null` (e.g.
[here|https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java#L2767])
we should set the correct value.
was:
In HDFS-14743 the operationType was implemented as a thread-local, which
requires the caller to set the thread-local before calling the
{{AccessControlEnforcer}} interface.
Most operations will set the operationType to a String, but some operations set
it to `null`.
This causes the FSPermissionChecker to always the old (deprecated)
{{AccessControlEnforcer.checkPermission}} API (see
[https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java#L431])
Instead of setting the operationType to `null` (e.g.
[here|https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java#L2767])
we should set the correct value.
> Missing operationType for some operations in authorizer
> ---
>
> Key: HDFS-17378
> URL: https://issues.apache.org/jira/browse/HDFS-17378
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
>Affects Versions: 3.3.6
>Reporter: Sebastian Bernauer
>Priority: Minor
>
> In HDFS-14743 the operationType was implemented as a thread-local, which
> requires the caller to set the thread-local before calling the
> {{AccessControlEnforcer}} interface.
> Most operations will set the operationType to a String, but some operations
> set it to `null`.
> This causes the FSPermissionChecker to always call the old (deprecated)
> {{AccessControlEnforcer.checkPermission}} API (see
> [https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java#L431])
> Instead of setting the operationType to `null` (e.g.
> [here|https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java#L2767])
> we should set the correct value.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-17378) Missing operationType for some operations in authorizer
[
https://issues.apache.org/jira/browse/HDFS-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastian Bernauer updated HDFS-17378:
--
Description:
In HDFS-14743 the operationType was implemented as a thread-local, which
requires the caller to set the thread-local before calling the
{{AccessControlEnforcer}} interface.
Most operations will set the operationType to a String, but some operations set
it to {{{}null{}}}.
This causes the FSPermissionChecker to always call the old (deprecated)
{{AccessControlEnforcer.checkPermission}} API (see
[https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java#L431])
Instead of setting the operationType to {{null}} (e.g.
[here|https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java#L2767])
we should set the correct value.
was:
In HDFS-14743 the operationType was implemented as a thread-local, which
requires the caller to set the thread-local before calling the
{{AccessControlEnforcer}} interface.
Most operations will set the operationType to a String, but some operations set
it to `null`.
This causes the FSPermissionChecker to always call the old (deprecated)
{{AccessControlEnforcer.checkPermission}} API (see
[https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java#L431])
Instead of setting the operationType to `null` (e.g.
[here|https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java#L2767])
we should set the correct value.
> Missing operationType for some operations in authorizer
> ---
>
> Key: HDFS-17378
> URL: https://issues.apache.org/jira/browse/HDFS-17378
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
>Affects Versions: 3.3.6
>Reporter: Sebastian Bernauer
>Priority: Minor
>
> In HDFS-14743 the operationType was implemented as a thread-local, which
> requires the caller to set the thread-local before calling the
> {{AccessControlEnforcer}} interface.
> Most operations will set the operationType to a String, but some operations
> set it to {{{}null{}}}.
> This causes the FSPermissionChecker to always call the old (deprecated)
> {{AccessControlEnforcer.checkPermission}} API (see
> [https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java#L431])
> Instead of setting the operationType to {{null}} (e.g.
> [here|https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java#L2767])
> we should set the correct value.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Created] (HDFS-17378) Missing operationType for some operations in authorizer
Sebastian Bernauer created HDFS-17378:
-
Summary: Missing operationType for some operations in authorizer
Key: HDFS-17378
URL: https://issues.apache.org/jira/browse/HDFS-17378
Project: Hadoop HDFS
Issue Type: Bug
Components: hdfs
Affects Versions: 3.3.6
Reporter: Sebastian Bernauer
In HDFS-14743 the operationType was implemented as a thread-local, which
requires the caller to set the thread-local before calling the
{{AccessControlEnforcer}} interface.
Most operations will set the operationType to a String, but some operations set
it to `null`.
This causes the FSPermissionChecker to always the old (deprecated)
{{AccessControlEnforcer.checkPermission}} API (see
[https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java#L431])
Instead of setting the operationType to `null` (e.g.
[here|https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java#L2767])
we should set the correct value.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17376) Distcp creates Factor 1 replication file on target if Source is EC
[ https://issues.apache.org/jira/browse/HDFS-17376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816013#comment-17816013 ] ASF GitHub Bot commented on HDFS-17376: --- sodonnel commented on PR #6540: URL: https://github.com/apache/hadoop/pull/6540#issuecomment-1935695635 @sadanand48 The change LGTM, but there are two checkstyle warnings in the test changes - could you fix them please? > Distcp creates Factor 1 replication file on target if Source is EC > -- > > Key: HDFS-17376 > URL: https://issues.apache.org/jira/browse/HDFS-17376 > Project: Hadoop HDFS > Issue Type: Bug > Components: distcp >Affects Versions: 3.3.6 >Reporter: Sadanand Shenoy >Assignee: Sadanand Shenoy >Priority: Major > Labels: pull-request-available > > If the source file is EC, distcp without preserve option creates a 1 > replication file (this is not intended). > This is because for an EC file getReplication() always return 1 . Instead it > should create the file as per the default replication on the target. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
