[jira] [Updated] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()
[
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sanghyun Yun updated HDFS-6291:
---
Attachment: HDFS-6291.2.patch
Thanks for your review, [~tedyu].
You are right. I removed image.close() in catch block.
> FSImage may be left unclosed in BootstrapStandby#doRun()
>
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HDFS-6291.2.patch, HDFS-6291.patch
>
>
> At around line 203:
> {code}
> if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
> }
> {code}
> If we return following the above check, image is not closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()
[
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179670#comment-14179670
]
Sanghyun Yun commented on HDFS-6291:
Please review my patch, [~vinayrpet] and [~tedyu]. :)
And can I assign to me this issue?
> FSImage may be left unclosed in BootstrapStandby#doRun()
>
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HDFS-6291.patch
>
>
> At around line 203:
> {code}
> if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
> }
> {code}
> If we return following the above check, image is not closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()
[
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sanghyun Yun updated HDFS-6291:
---
Status: Patch Available (was: Open)
> FSImage may be left unclosed in BootstrapStandby#doRun()
>
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HDFS-6291.patch
>
>
> At around line 203:
> {code}
> if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
> }
> {code}
> If we return following the above check, image is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()
[
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sanghyun Yun updated HDFS-6291:
---
Attachment: HDFS-6291.patch
I add image.close() in finally
> FSImage may be left unclosed in BootstrapStandby#doRun()
>
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HDFS-6291.patch
>
>
> At around line 203:
> {code}
> if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
> }
> {code}
> If we return following the above check, image is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-5147) Certain dfsadmin commands such as safemode do not interact with the active namenode in ha setup
[ https://issues.apache.org/jira/browse/HDFS-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984047#comment-13984047 ] Sanghyun Yun commented on HDFS-5147: [~jingzhao], thanks for your answers. I known -fs option and it works well. But, I think "dfsadmin" command should be affect active namenode when I don't specify specific NN URI or use "-fs hdfs://CLUSTERNAME". Currently, it affect first namenode that doesn't matter active or standby. > Certain dfsadmin commands such as safemode do not interact with the active > namenode in ha setup > --- > > Key: HDFS-5147 > URL: https://issues.apache.org/jira/browse/HDFS-5147 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha >Affects Versions: 2.1.0-beta >Reporter: Arpit Gupta >Assignee: Jing Zhao > > There are certain commands in dfsadmin return the status of the first > namenode specified in the configs rather than interacting with the active > namenode > For example. Issue > hdfs dfsadmin -safemode get > and it will return the status of the first namenode in the configs rather > than the active namenode. > I think all dfsadmin commands should determine which is the active namenode > do the operation on it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-5147) Certain dfsadmin commands such as safemode do not interact with the active namenode in ha setup
[ https://issues.apache.org/jira/browse/HDFS-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983998#comment-13983998 ] Sanghyun Yun commented on HDFS-5147: hdfs dfsadmin -safemode enter This command's result is first namenode(it doesn't matter that active) status changes to safemode. I think should be changed active namenode or both. hdfs dfsadmin -fs hdfs://CLUSTERNAME -safemode enter This command's result is same. Is it correct? I performed in r2.2.0 > Certain dfsadmin commands such as safemode do not interact with the active > namenode in ha setup > --- > > Key: HDFS-5147 > URL: https://issues.apache.org/jira/browse/HDFS-5147 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha >Affects Versions: 2.1.0-beta >Reporter: Arpit Gupta >Assignee: Jing Zhao > > There are certain commands in dfsadmin return the status of the first > namenode specified in the configs rather than interacting with the active > namenode > For example. Issue > hdfs dfsadmin -safemode get > and it will return the status of the first namenode in the configs rather > than the active namenode. > I think all dfsadmin commands should determine which is the active namenode > do the operation on it. -- This message was sent by Atlassian JIRA (v6.2#6252)
