[jira] [Comment Edited] (HDFS-12496) Make QuorumJournalManager timeout properties configurable

2017-09-21 Thread Ajay Kumar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-12496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175106#comment-16175106
 ] 

Ajay Kumar edited comment on HDFS-12496 at 9/21/17 5:19 PM:


[~arpitagarwal],[~hkoneru] thanks for review and commit.


was (Author: ajayydv):
[~arpitagarwal], thanks for review and commit.

> Make QuorumJournalManager timeout properties configurable
> -
>
> Key: HDFS-12496
> URL: https://issues.apache.org/jira/browse/HDFS-12496
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ajay Kumar
>Assignee: Ajay Kumar
> Fix For: 2.9.0, 3.0.0-beta1
>
> Attachments: HDFS-12496.01.patch, HDFS-12496.02.patch, 
> HDFS-12496.03.patch, HDFS-12496.04.patch, HDFS-12496.05.patch, 
> HDFS-12496.06.patch
>
>
> Make QuorumJournalManager timeout properties configurable using a common key. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (HDFS-12496) Make QuorumJournalManager timeout properties configurable

2017-09-20 Thread Ajay Kumar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-12496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173983#comment-16173983
 ] 

Ajay Kumar edited comment on HDFS-12496 at 9/20/17 11:12 PM:
-

Changed {{DFS_QJM_OP_TIMEOUT,DFS_QJM_OP_TIMEOUT_DEFAULT}} to 
{{DFS_QJM_OPERATIONS_TIMEOUT,DFS_QJM_OPERATIONS_TIMEOUT_DEFAULT}}


was (Author: ajayydv):
Changed {{DFS_QJM_OP_TIMEOUT,DFS_QJM_OP_TIMEOUT_DEFAULT}} to 
{{DFS_QJM_OPERATIONS_TIMEOUT_DEFAULT}}

> Make QuorumJournalManager timeout properties configurable
> -
>
> Key: HDFS-12496
> URL: https://issues.apache.org/jira/browse/HDFS-12496
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ajay Kumar
>Assignee: Ajay Kumar
> Attachments: HDFS-12496.01.patch, HDFS-12496.02.patch, 
> HDFS-12496.03.patch, HDFS-12496.04.patch, HDFS-12496.05.patch
>
>
> Make QuorumJournalManager timeout properties configurable using a common key. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (HDFS-12496) Make QuorumJournalManager timeout properties configurable

2017-09-20 Thread Arpit Agarwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-12496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173570#comment-16173570
 ] 

Arpit Agarwal edited comment on HDFS-12496 at 9/20/17 5:46 PM:
---

Thanks for the updated patch [~ajayydv]. Couple of additional comments:
# The new config key should be in hdfs-default.xml and it should be renamed to 
something like {{dfs.qjm.operations.timeout}}.
# Can you please update the description to state that the value accepts 
suffixes standard units like ns, ms, s and m. And if no unit is specified then 
the default is milliseconds. Also you can specify the default as 60s or 1m 
instead of 6. There are other keys that accept the same suffixes, you can 
copy this sentence from their description.
{code}
+  Common key to set timeout in milliseconds for related operations in
+  QuorumJournalManager.
{code}



was (Author: arpitagarwal):
Thanks for the updated patch [~ajayydv]. Couple of additional comments:
# The new config key should be in hdfs-default.xml and it should
# Can you please update the description to state that the value accepts 
suffixes standard units like ns, ms, s and m. And if no unit is specified then 
the default is milliseconds. Also you can specify the default as 60s or 1m 
instead of 6. There are other keys that accept the same suffixes, you can 
copy this sentence from their description.
{code}
+  Common key to set timeout in milliseconds for related operations in
+  QuorumJournalManager.
{code}
# The config key should be renamed to something like 
{{dfs.qjm.operations.timeout}}.

> Make QuorumJournalManager timeout properties configurable
> -
>
> Key: HDFS-12496
> URL: https://issues.apache.org/jira/browse/HDFS-12496
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ajay Kumar
>Assignee: Ajay Kumar
> Attachments: HDFS-12496.01.patch, HDFS-12496.02.patch
>
>
> Make QuorumJournalManager timeout properties configurable using a common key. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org