[ 
https://issues.apache.org/jira/browse/HDFS-12515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173674#comment-16173674
 ] 

Anu Engineer edited comment on HDFS-12515 at 9/20/17 7:07 PM:
--------------------------------------------------------------

Adding this dependency makes this work on ozone .. 
{code}
===================================================================
--- hadoop-mapreduce-project/hadoop-mapreduce-examples/pom.xml  (revision 
2a94ce9124c7c96a6baa527c543575b74958afd9)
+++ hadoop-mapreduce-project/hadoop-mapreduce-examples/pom.xml  (revision )
@@ -34,6 +34,13 @@
   </properties>
 
   <dependencies>
+      <!-- Adding this dependency makes this build in ozone !-->
+      <dependency>
+          <groupId>org.slf4j</groupId>
+          <artifactId>slf4j-api</artifactId>
+      </dependency>
+      <!-- but this not needed in trunk !-->
+
     <dependency>
       <groupId>commons-cli</groupId>
       <artifactId>commons-cli</artifactId>
{code}

I am going to commit this, but not resolve this JIRA in case we want to revert 
it. This dependency just makes it explicit that this module needed in 
mapreduce-examples package. So it might be ok to merge this change to trunk.



was (Author: anu):
Adding this dependency makes this work on ozone .. 
{code}
===================================================================
--- hadoop-mapreduce-project/hadoop-mapreduce-examples/pom.xml  (revision 
2a94ce9124c7c96a6baa527c543575b74958afd9)
+++ hadoop-mapreduce-project/hadoop-mapreduce-examples/pom.xml  (revision )
@@ -34,6 +34,13 @@
   </properties>
 
   <dependencies>
+      <!-- Adding this dependency makes this build in ozone !-->
+      <dependency>
+          <groupId>org.slf4j</groupId>
+          <artifactId>slf4j-api</artifactId>
+      </dependency>
+      <!-- but this not needed in trunk !-->
+
     <dependency>
       <groupId>commons-cli</groupId>
       <artifactId>commons-cli</artifactId>
{code}

I am going to commit this, but not resolve this JIRA in case we want to revert 
it. This dependency just makes it explicit that this module need sl4j. So it 
might be ok to merge this change to trunk.


> Ozone: mvn package compilation fails on HDFS-7240
> -------------------------------------------------
>
>                 Key: HDFS-12515
>                 URL: https://issues.apache.org/jira/browse/HDFS-12515
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Mukul Kumar Singh
>            Assignee: Mukul Kumar Singh
>            Priority: Blocker
>              Labels: ozoneMerge
>             Fix For: HDFS-7240
>
>         Attachments: HDFS-12515-HDFS-7240.001.patch
>
>
> Creation of a package on ozone(HDFS-7240) fails
> {{mvn clean package -Pdist -DskipTests -Dtar -Dmaven.javadoc.skip=true}}
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) 
> on project hadoop-mapreduce-examples: Compilation failure: Compilation 
> failure: 
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraGen.java:[50,17]
>  package org.slf4j does not exist
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraGen.java:[51,17]
>  package org.slf4j does not exist
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraGen.java:[69,24]
>  cannot find symbol
> [ERROR]   symbol:   class Logger
> [ERROR]   location: class org.apache.hadoop.examples.terasort.TeraGen
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/BaileyBorweinPlouffe.java:[53,17]
>  package org.slf4j does not exist
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/BaileyBorweinPlouffe.java:[86,24]
>  cannot find symbol
> [ERROR]   symbol:   class Logger
> [ERROR]   location: class org.apache.hadoop.examples.BaileyBorweinPlouffe
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java:[51,17]
>  package org.slf4j does not exist
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java:[80,24]
>  cannot find symbol
> [ERROR]   symbol:   class Logger
> [ERROR]   location: class org.apache.hadoop.examples.DBCountPageView
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/pi/DistSum.java:[57,17]
>  package org.slf4j does not exist
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/pi/DistSum.java:[69,24]
>  cannot find symbol
> [ERROR]   symbol:   class Logger
> [ERROR]   location: class org.apache.hadoop.examples.pi.DistSum
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/dancing/DancingLinks.java:[23,17]
>  package org.slf4j does not exist
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/dancing/DancingLinks.java:[38,24]
>  cannot find symbol
> [ERROR]   symbol:   class Logger
> [ERROR]   location: class 
> org.apache.hadoop.examples.dancing.DancingLinks<ColumnName>
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java:[40,17]
>  package org.slf4j does not exist
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java:[50,24]
>  cannot find symbol
> [ERROR]   symbol:   class Logger
> [ERROR]   location: class org.apache.hadoop.examples.terasort.TeraSort
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java:[40,17]
>  package org.slf4j does not exist
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java:[46,24]
>  cannot find symbol
> [ERROR]   symbol:   class Logger
> [ERROR]   location: class org.apache.hadoop.examples.terasort.TeraOutputFormat
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraScheduler.java:[29,17]
>  package org.slf4j does not exist
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraScheduler.java:[34,24]
>  cannot find symbol
> [ERROR]   symbol:   class Logger
> [ERROR]   location: class org.apache.hadoop.examples.terasort.TeraScheduler
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraGen.java:[69,37]
>  cannot find symbol
> [ERROR]   symbol:   variable LoggerFactory
> [ERROR]   location: class org.apache.hadoop.examples.terasort.TeraGen
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/BaileyBorweinPlouffe.java:[87,7]
>  cannot find symbol
> [ERROR]   symbol:   variable LoggerFactory
> [ERROR]   location: class org.apache.hadoop.examples.BaileyBorweinPlouffe
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/DBCountPageView.java:[81,7]
>  cannot find symbol
> [ERROR]   symbol:   variable LoggerFactory
> [ERROR]   location: class org.apache.hadoop.examples.DBCountPageView
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/pi/DistSum.java:[69,37]
>  cannot find symbol
> [ERROR]   symbol:   variable LoggerFactory
> [ERROR]   location: class org.apache.hadoop.examples.pi.DistSum
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/dancing/DancingLinks.java:[38,37]
>  cannot find symbol
> [ERROR]   symbol:   variable LoggerFactory
> [ERROR]   location: class 
> org.apache.hadoop.examples.dancing.DancingLinks<ColumnName>
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraSort.java:[50,37]
>  cannot find symbol
> [ERROR]   symbol:   variable LoggerFactory
> [ERROR]   location: class org.apache.hadoop.examples.terasort.TeraSort
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java:[47,7]
>  cannot find symbol
> [ERROR]   symbol:   variable LoggerFactory
> [ERROR]   location: class org.apache.hadoop.examples.terasort.TeraOutputFormat
> [ERROR] 
> /Users/msingh/code/work/apache/cblock/ozone_review2/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraScheduler.java:[35,7]
>  cannot find symbol
> [ERROR]   symbol:   variable LoggerFactory
> [ERROR]   location: class org.apache.hadoop.examples.terasort.TeraScheduler
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to