[ https://issues.apache.org/jira/browse/HDFS-12840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277817#comment-16277817 ]
Lei (Eddy) Xu edited comment on HDFS-12840 at 12/5/17 12:44 AM: ---------------------------------------------------------------- Thanks for the suggestions and reviews [~Sammi] and [~rakesh_r] bq. TestOfflineEditsViewer.testStored is failing, is this related to the patch?. Please download {{editsStored.03}} with the patch, and place it to {{./hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored}}. bq. REPLICATION_POLICY_ID is defined in ErasureCodeConstants Done bq. TestRetryCacheWithHA, 40 instead of 41. It was due to creating {{RS-6-3}} files sometimes failed with not enough DNs in the tests. It seems flaky, and not relevant. Will file a new JIRA for it. I removed creating file with default policy in the tests, as it is not relevant. bq. Refactor: ecPolicyID => erasureCodingPolicyId ... Done Could you give another review, [~Sammi], [~rakesh_r] and [~xiaochen] was (Author: eddyxu): Thanks for the suggestions and reviews [~Sammi] and [~rakesh_r] bq. TestOfflineEditsViewer.testStored is failing, is this related to the patch?. Please download {{editsStored.03}} with the patch, and place it to {{./hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored}}. bq. REPLICATION_POLICY_ID is defined in ErasureCodeConstants Done bq. TestRetryCacheWithHA, 40 instead of 41. It was due to creating {{RS-6-3}} files sometimes failed with not enough DNs in the tests. It seems flaky, and not relevant. Will file a new JIRA for it. I removed creating file with default policy in the tests, as it is not relevant. bq. Refactor: ecPolicyID => erasureCodingPolicyId ... Done Could you give another review, [~Sammi], [~rakesh_r] and [~xiaochen] > Creating a replicated file in a EC zone does not correctly serialized in > EditLogs > --------------------------------------------------------------------------------- > > Key: HDFS-12840 > URL: https://issues.apache.org/jira/browse/HDFS-12840 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding > Affects Versions: 3.0.0-beta1 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Priority: Blocker > Labels: hdfs-ec-3.0-must-do > Attachments: HDFS-12840.00.patch, HDFS-12840.01.patch, > HDFS-12840.02.patch, HDFS-12840.03.patch, HDFS-12840.reprod.patch, > editsStored, editsStored, editsStored.03 > > > When create a replicated file in an existing EC zone, the edit logs does not > differentiate it from an EC file. When {{FSEditLogLoader}} to replay edits, > this file is treated as EC file, as a results, it crashes the NN because the > blocks of this file are replicated, which does not match with {{INode}}. > {noformat} > ERROR org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader: Encountered > exception on operation AddBlockOp [path=/system/balancer.id, > penultimateBlock=NULL, lastBlock=blk_1073743259_2455, RpcClientId=, > RpcCallId=-2] > java.lang.IllegalArgumentException: reportedBlock is not striped > at > com.google.common.base.Preconditions.checkArgument(Preconditions.java:88) > at > org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoStriped.addStorage(BlockInfoStriped.java:118) > at > org.apache.hadoop.hdfs.server.blockmanagement.DatanodeStorageInfo.addBlock(DatanodeStorageInfo.java:256) > at > org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.addStoredBlock(BlockManager.java:3141) > at > org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.addStoredBlockUnderConstruction(BlockManager.java:3068) > at > org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processAndHandleReportedBlock(BlockManager.java:3864) > at > org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processQueuedMessages(BlockManager.java:2916) > at > org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processQueuedMessagesForBlock(BlockManager.java:2903) > at > org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.addNewBlock(FSEditLogLoader.java:1069) > at > org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.applyEditLogOp(FSEditLogLoader.java:532) > at > org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.loadEditRecords(FSEditLogLoader.java:249) > at > org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.loadFSEdits(FSEditLogLoader.java:158) > at > org.apache.hadoop.hdfs.server.namenode.FSImage.loadEdits(FSImage.java:882) > at > org.apache.hadoop.hdfs.server.namenode.FSImage.loadEdits(FSImage.java:863) > at > org.apache.hadoop.hdfs.server.namenode.ha.EditLogTailer.doTailEdits(EditLogTailer.java:293) > at > org.apache.hadoop.hdfs.server.namenode.ha.EditLogTailer$EditLogTailerThread.doWork(EditLogTailer.java:427) > at > org.apache.hadoop.hdfs.server.namenode.ha.EditLogTailer$EditLogTailerThread.access$400(EditLogTailer.java:380) > at > org.apache.hadoop.hdfs.server.namenode.ha.EditLogTailer$EditLogTailerThread$1.run(EditLogTailer.java:397) > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org