[
https://issues.apache.org/jira/browse/HDFS-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409885#comment-16409885
]
Íñigo Goiri edited comment on HDFS-13291 at 3/22/18 4:55 PM:
-
Thanks [~linyiqun]. Comments on [^HDFS-13291.005.patch]:
* We can make have a constructor with the conf and make {{setMinUpdateTime()}}
part of the parent constructor with a final and avoid the FindBugs error.
* In AvailableSpaceResolver, there is no need to do
AvailableSpaceResolver.SubclusterAvailableSpace in line 50,
SubclusterAvailableSpace should be enough.
* I would add an extra line before lines 51 and try to make 64 javadoc a single
line comment (e.g., remove "writing").
* We could log the {{getMembershipStore()}} error in the parent class.
* {{AvailableSpaceResolver#getSubclusterInfo}} should have a javadoc defining
what the map is (in one case is node to subcluster and in the other is
subcluster to space, we may want to may K and V templates, and not just T).
Similarly, {{RouterResolve}} comment for the map should be made general as it
is not always NamespaceId.
* Make the comparator in AvailableSpaceResolver final.
* TestRouterAllResolver line 63, typo in RANDOM.
* In {{getParentPermission}} comment that this is based on the FSDirXXX.
* checkstyles and javadoc warnings can be fixed.
was (Author: elgoiri):
* We can make have a constructor with the conf and mae {{setMinUpdateTime()}}
part of the parent constructor with a final and avoid the FindBugs error.
* In AvailableSpaceResolver, there is no need to do
AvailableSpaceResolver.SubclusterAvailableSpace in line 50,
SubclusterAvailableSpace should be enough.
* I would add an extra line before lines 51 and try to make 64 javadoc a single
line comment (e.g., remove "writing").
* We could log the {{getMembershipStore()}} error in the parent class.
* {{AvailableSpaceResolver#getSubclusterInfo}} should have a javadoc defining
what the map is (in one case is node to subcluster and in the other is
subcluster to space, we may want to may K and V templates, and not just T).
Similarly, {{RouterResolve}} comment for the map should be made general as it
is not always NamespaceId.
* Make the comparator in AvailableSpaceResolver final.
* TestRouterAllResolver line 63, typo in RANDOM.
* In {{getParentPermission}} comment that this is based on the FSDirXXX.
* checkstyles and javadoc warnings can be fixed.
> RBF: Implement available space based OrderResolver
> --
>
> Key: HDFS-13291
> URL: https://issues.apache.org/jira/browse/HDFS-13291
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
>Priority: Major
> Attachments: HDFS-13291.001.patch, HDFS-13291.002.patch,
> HDFS-13291.003.patch, HDFS-13291.004.patch, HDFS-13291.005.patch
>
>
> Implement available space based OrderResolver, this type resolver will
> benefit for balancing the data across subclusters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
