[jira] [Comment Edited] (HDFS-14320) Support skipTrash for WebHDFS
[ https://issues.apache.org/jira/browse/HDFS-14320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330394#comment-17330394 ] Viraj Jasani edited comment on HDFS-14320 at 4/23/21, 11:43 AM: I was not aware of this Jira and hence we worked on HDFS-15982 with similar purpose, apologies for the duplicated efforts. However, since we have upto date PR available and unless anyone has any objections, can someone please review [https://github.com/apache/hadoop/pull/2927] ? Thanks was (Author: vjasani): I was not aware of this Jira and hence we worked on HDFS-15982 with similar purpose, apologies for the duplicated efforts. However, since we have upto date PR available, can someone please review [https://github.com/apache/hadoop/pull/2927] ? Thanks > Support skipTrash for WebHDFS > -- > > Key: HDFS-14320 > URL: https://issues.apache.org/jira/browse/HDFS-14320 > Project: Hadoop HDFS > Issue Type: New Feature > Components: namenode, webhdfs >Affects Versions: 3.2.0 >Reporter: Karthik Palanisamy >Assignee: Karthik Palanisamy >Priority: Major > Attachments: HDFS-14320-001.patch, HDFS-14320-002.patch, > HDFS-14320-003.patch, HDFS-14320-004.patch, HDFS-14320-005.patch, > HDFS-14320-006.patch, HDFS-14320-007.patch, HDFS-14320-008.patch > > > Files/Directories deleted via webhdfs rest call doesn't use the skiptrash > feature, it would be deleted permanently. This feature is very important us > because our user has deleted large directory accidentally. > By default, Skiptrash option is set to true, skiptrash=true. Any files, Using > CURL will be permanently deleted. > Example: > curl -iv -X DELETE > "http://:50070/webhdfs/v1/tmp/sampledata?op=DELETE&user.name=hdfs&recursive=true"; > > Use skiptrash=false, to move files to trash Instead. > Example: > curl -iv -X DELETE > "http://:50070/webhdfs/v1/tmp/sampledata?op=DELETE&user.name=hdfs&recursive=true&skiptrash=false"; > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDFS-14320) Support skipTrash for WebHDFS
[ https://issues.apache.org/jira/browse/HDFS-14320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118235#comment-17118235 ] Chao Sun edited comment on HDFS-14320 at 5/28/20, 10:16 AM: Bumping up this as this seems to be an important feature. Curious what is the current status [~kpalanisamy], [~weichiu]. was (Author: csun): Bumping up this as this seems to be an important feature. Curious what is the current status [~weichiu]. > Support skipTrash for WebHDFS > -- > > Key: HDFS-14320 > URL: https://issues.apache.org/jira/browse/HDFS-14320 > Project: Hadoop HDFS > Issue Type: New Feature > Components: namenode, webhdfs >Affects Versions: 3.2.0 >Reporter: Karthik Palanisamy >Assignee: Karthik Palanisamy >Priority: Major > Attachments: HDFS-14320-001.patch, HDFS-14320-002.patch, > HDFS-14320-003.patch, HDFS-14320-004.patch, HDFS-14320-005.patch, > HDFS-14320-006.patch, HDFS-14320-007.patch, HDFS-14320-008.patch > > > Files/Directories deleted via webhdfs rest call doesn't use the skiptrash > feature, it would be deleted permanently. This feature is very important us > because our user has deleted large directory accidentally. > By default, Skiptrash option is set to true, skiptrash=true. Any files, Using > CURL will be permanently deleted. > Example: > curl -iv -X DELETE > "http://:50070/webhdfs/v1/tmp/sampledata?op=DELETE&user.name=hdfs&recursive=true"; > > Use skiptrash=false, to move files to trash Instead. > Example: > curl -iv -X DELETE > "http://:50070/webhdfs/v1/tmp/sampledata?op=DELETE&user.name=hdfs&recursive=true&skiptrash=false"; > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDFS-14320) Support skipTrash for WebHDFS
[
https://issues.apache.org/jira/browse/HDFS-14320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799373#comment-16799373
]
Karthik Palanisamy edited comment on HDFS-14320 at 3/22/19 9:36 PM:
{quote}Also, this patch won't work with security enabled since the NN's handler
does not have any credentials.
{quote}
[~daryn] It works in secure environment because authentication token will send
to Webhdfs server, where we do doAs with this credentials. Tested this patch
in Secure cluster.
NamenodeWebHdfsMethods#delete
{code:java}
return doAs(ugi, new PrivilegedExceptionAction() {
@Override
public Response run() throws IOException {
return delete(ugi, delegation, username, doAsUser,
path.getAbsolutePath(), op, recursive, skiptrash, snapshotName);
}
{code}
Btw, yes I should not use Filesystem object, will use direct rename(trash)
call to Namenode.
was (Author: kpalanisamy):
{quote}Also, this patch won't work with security enabled since the NN's handler
does not have any credentials.
{quote}
[~daryn] It works in secure environment because authentication token will send
to Webhdfs server, where we do doAs with this credentials. Tested this patch
in Secure cluster.
NamenodeWebHdfsMethods#delete
{code:java}
return doAs(ugi, new PrivilegedExceptionAction() {
@Override
public Response run() throws IOException {
return delete(ugi, delegation, username, doAsUser,
path.getAbsolutePath(), op, recursive, skiptrash, snapshotName);
}
{code}
Btw, yes I should not Filesystem object, will use direct rename(trash) call to
Namenode.
> Support skipTrash for WebHDFS
> --
>
> Key: HDFS-14320
> URL: https://issues.apache.org/jira/browse/HDFS-14320
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: namenode, webhdfs
>Affects Versions: 3.2.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Major
> Attachments: HDFS-14320-001.patch, HDFS-14320-002.patch,
> HDFS-14320-003.patch, HDFS-14320-004.patch, HDFS-14320-005.patch,
> HDFS-14320-006.patch, HDFS-14320-007.patch, HDFS-14320-008.patch
>
>
> Files/Directories deleted via webhdfs rest call doesn't use the skiptrash
> feature, it would be deleted permanently. This feature is very important us
> because our user has deleted large directory accidentally.
> By default, Skiptrash option is set to true, skiptrash=true. Any files, Using
> CURL will be permanently deleted.
> Example:
> curl -iv -X DELETE
> "http://:50070/webhdfs/v1/tmp/sampledata?op=DELETE&user.name=hdfs&recursive=true";
>
> Use skiptrash=false, to move files to trash Instead.
> Example:
> curl -iv -X DELETE
> "http://:50070/webhdfs/v1/tmp/sampledata?op=DELETE&user.name=hdfs&recursive=true&skiptrash=false";
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDFS-14320) Support skipTrash for WebHDFS
[ https://issues.apache.org/jira/browse/HDFS-14320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786211#comment-16786211 ] Karthik Palanisamy edited comment on HDFS-14320 at 3/6/19 11:27 PM: Not sure if whitespace is related to this 006.patch. However, attaching a new patch. It looks issue due to NodeJs whitespace check. Found here,[YARN-9348|https://issues.apache.org/jira/browse/YARN-9348]. [~eyang] was (Author: kpalanisamy): Not sure if whitespace is related to this 006.patch. However, attaching a new patch. > Support skipTrash for WebHDFS > -- > > Key: HDFS-14320 > URL: https://issues.apache.org/jira/browse/HDFS-14320 > Project: Hadoop HDFS > Issue Type: New Feature > Components: namenode, webhdfs >Affects Versions: 3.2.0 >Reporter: Karthik Palanisamy >Assignee: Karthik Palanisamy >Priority: Major > Attachments: HDFS-14320-001.patch, HDFS-14320-002.patch, > HDFS-14320-003.patch, HDFS-14320-004.patch, HDFS-14320-005.patch, > HDFS-14320-006.patch, HDFS-14320-007.patch > > > Files/Directories deleted via webhdfs rest call doesn't use the skiptrash > feature, it would be deleted permanently. This feature is very important us > because our user has deleted large directory accidentally. > By default, Skiptrash option is set to true, skiptrash=true. Any files, Using > CURL will be permanently deleted. > Example: > curl -iv -X DELETE > "http://:50070/webhdfs/v1/tmp/sampledata?op=DELETE&user.name=hdfs&recursive=true"; > > Use skiptrash=false, to move files to trash Instead. > Example: > curl -iv -X DELETE > "http://:50070/webhdfs/v1/tmp/sampledata?op=DELETE&user.name=hdfs&recursive=true&skiptrash=false"; > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
