[jira] [Commented] (HDDS-1548) Jenkins precommit build is broken for Ozone

2019-05-16 Thread Elek, Marton (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841393#comment-16841393
 ] 

Elek, Marton commented on HDDS-1548:


+1

Thanks to take care of this.

Agree, this was the plan with YETUS-816 and HADOOP-16183: move everything from 
the experimental spaces to the mainstream apache repository.

> Jenkins precommit build is broken for Ozone
> ---
>
> Key: HDDS-1548
> URL: https://issues.apache.org/jira/browse/HDDS-1548
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Eric Yang
>Priority: Blocker
>
> HDDS Jenkins precommit build has been broken since Build 2685 Date May 13, 
> 2019 11:00:40PM.  It looks like the precommit build depends on Yetus trunk.  
> This is extremely risky when Yetus trunk breaks, it also breaks precommit 
> build for Ozone.  Precommit build must use a released version of Yetus to 
> prevent cascaded regression.
> A second problem is the precommit build also depends on Marton's own personal 
> website to download ozone.sh.  It would be best to version control ozone.sh 
> in hadoop-ozone/dev-support directory to prevent unpredictable changes to 
> ozone.sh at different time, which can make precommit build report 
> indeterministic.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-1548) Jenkins precommit build is broken for Ozone

2019-05-15 Thread Eric Yang (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840653#comment-16840653
 ] 

Eric Yang commented on HDDS-1548:
-

Yetus master has recently committed YETUS-873.  This will make the parameters 
more strict.  By default if unknown parameters are passed, it will cause Yetus 
to exit.  With the recent trim down of parameters, some parameters are no 
longer valid to latest version of Yetus.  This is the root cause of Ozone 
pre-commit build regressions.

> Jenkins precommit build is broken for Ozone
> ---
>
> Key: HDDS-1548
> URL: https://issues.apache.org/jira/browse/HDDS-1548
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Eric Yang
>Priority: Blocker
>
> HDDS Jenkins precommit build has been broken since Build 2685 Date May 13, 
> 2019 11:00:40PM.  It looks like the precommit build depends on Yetus trunk.  
> This is extremely risky when Yetus trunk breaks, it also breaks precommit 
> build for Ozone.  Precommit build must use a released version of Yetus to 
> prevent cascaded regression.
> A second problem is the precommit build also depends on Marton's own personal 
> website to download ozone.sh.  It would be best to version control ozone.sh 
> in hadoop-ozone/dev-support directory to prevent unpredictable changes to 
> ozone.sh at different time, which can make precommit build report 
> indeterministic.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-1548) Jenkins precommit build is broken for Ozone

2019-05-15 Thread Eric Yang (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840639#comment-16840639
 ] 

Eric Yang commented on HDDS-1548:
-

[~elek] Can we make the following changes:

{code}
- curl -L https://api.github.com/repos/apache/yetus/tarball/master -o 
yetus.tar.gz
- wget 
https://raw.githubusercontent.com/elek/yetus/ozone-personality/precommit/src/main/shell/personality/hadoop.sh
 -O "$WORKSPACE/ozone.sh"
+ curl -L https://api.github.com/repos/apache/yetus/tarball/rel/0.8.0 -o 
yetus.tar.gz
...
- YETUS_ARGS+=("--personality=$WORKSPACE/ozone.sh")
{code}

It is better to make sure that shell script are written using same upper and 
lower case and remove indirect references to prevent shellshock attacks.  
Therefore, the disabled shellcheck SC2034 should be checked.

> Jenkins precommit build is broken for Ozone
> ---
>
> Key: HDDS-1548
> URL: https://issues.apache.org/jira/browse/HDDS-1548
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Eric Yang
>Priority: Blocker
>
> HDDS Jenkins precommit build has been broken since Build 2685 Date May 13, 
> 2019 11:00:40PM.  It looks like the precommit build depends on Yetus trunk.  
> This is extremely risky when Yetus trunk breaks, it also breaks precommit 
> build for Ozone.  Precommit build must use a released version of Yetus to 
> prevent cascaded regression.
> A second problem is the precommit build also depends on Marton's own personal 
> website to download ozone.sh.  It would be best to version control ozone.sh 
> in hadoop-ozone/dev-support directory to prevent unpredictable changes to 
> ozone.sh at different time, which can make precommit build report 
> indeterministic.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org