[jira] [Commented] (HDDS-219) Genearate version-info.properties for hadoop and ozone

2018-08-09 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574554#comment-16574554
 ] 

Hudson commented on HDDS-219:
-

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14736 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14736/])
HDDS-219. Genearate version-info.properties for hadoop and ozone. (elek: rev 
3d96bc6e5ff098900cf07e4b30c642e961a39427)
* (add) 
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/util/OzoneVersionInfo.java
* (add) hadoop-hdds/common/src/main/resources/hdds-version-info.properties
* (add) hadoop-ozone/common/src/main/resources/ozone-version-info.properties
* (add) 
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/HddsVersionInfo.java
* (edit) hadoop-ozone/common/pom.xml
* (edit) hadoop-ozone/common/src/main/bin/ozone
* (edit) hadoop-hdds/common/pom.xml


> Genearate version-info.properties for hadoop and ozone
> --
>
> Key: HDDS-219
> URL: https://issues.apache.org/jira/browse/HDDS-219
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Elek, Marton
>Assignee: Sandeep Nemuri
>Priority: Major
>  Labels: newbie
> Fix For: 0.2.1
>
> Attachments: HDDS-219.001.patch, HDDS-219.002.patch
>
>
> org.apache.hadoop.util.VersionInfo provides an api to show the actual version 
> information.
> We need to generate hdds-version-info.properties and 
> ozone-version-info.properties as part of the build process(most probably in 
> hdds/common, ozone/common projects)  and print out the available versions in 
> case of 'ozone version' command



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-219) Genearate version-info.properties for hadoop and ozone

2018-08-09 Thread Elek, Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574522#comment-16574522
 ] 

Elek, Marton commented on HDDS-219:
---

+1

Looks awesome to me.

I just committed it to the trunk. Thank you very much [~Sandeep Nemuri] the 
contribution.

> Genearate version-info.properties for hadoop and ozone
> --
>
> Key: HDDS-219
> URL: https://issues.apache.org/jira/browse/HDDS-219
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Elek, Marton
>Assignee: Sandeep Nemuri
>Priority: Major
>  Labels: newbie
> Fix For: 0.2.1
>
> Attachments: HDDS-219.001.patch, HDDS-219.002.patch
>
>
> org.apache.hadoop.util.VersionInfo provides an api to show the actual version 
> information.
> We need to generate hdds-version-info.properties and 
> ozone-version-info.properties as part of the build process(most probably in 
> hdds/common, ozone/common projects)  and print out the available versions in 
> case of 'ozone version' command



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-219) Genearate version-info.properties for hadoop and ozone

2018-08-08 Thread genericqa (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573368#comment-16573368
 ] 

genericqa commented on HDDS-219:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m 
34s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 30m 
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 28s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m  
4s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
32s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 31m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 31m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
26s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green}  0m 
32s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 32s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
12s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
46s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
50s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}135m 17s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 |
| JIRA Issue | HDDS-219 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12934809/HDDS-219.002.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient 

[jira] [Commented] (HDDS-219) Genearate version-info.properties for hadoop and ozone

2018-08-08 Thread Sandeep Nemuri (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573207#comment-16573207
 ] 

Sandeep Nemuri commented on HDDS-219:
-

[^HDDS-219.002.patch] Includes : 
 * Ozone logo in version output.
 * Checksum for all the sources in the hdds and ozone project.
 * Release name

Output is as below:
{code:java}
~/g/hadoop> ./hadoop-dist/target/ozone/bin/ozone version
  //
   
 
   //  
  /    /
 /   ///
    /
/ 
/      //
  ///   /
 /  /// 
  /   //  /
   //   //   /
 /// 
   //  
   ///   //
  /0.2.1-SNAPSHOT(Acadia)

Source code repository https://github.com/apache/hadoop.git -r 
6ed8593d180fe653f78f0a210478555338c4685a
Compiled by snemuri on 2018-08-08T10:45Z
Compiled with protoc 2.5.0
>From source with checksum 5e911cd6412a9c54b463d01211cbae6d

Using HDDS 0.2.1-SNAPSHOT
Source code repository https://github.com/apache/hadoop.git -r 
6ed8593d180fe653f78f0a210478555338c4685a
Compiled by snemuri on 2018-08-08T10:41Z
Compiled with protoc 2.5.0
>From source with checksum 6cedbc75c9cd6791685b499cf62a2d

{code}

[~elek], Kindly review.

> Genearate version-info.properties for hadoop and ozone
> --
>
> Key: HDDS-219
> URL: https://issues.apache.org/jira/browse/HDDS-219
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Elek, Marton
>Assignee: Sandeep Nemuri
>Priority: Major
>  Labels: newbie
> Fix For: 0.2.1
>
> Attachments: HDDS-219.001.patch, HDDS-219.002.patch
>
>
> org.apache.hadoop.util.VersionInfo provides an api to show the actual version 
> information.
> We need to generate hdds-version-info.properties and 
> ozone-version-info.properties as part of the build process(most probably in 
> hdds/common, ozone/common projects)  and print out the available versions in 
> case of 'ozone version' command



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-219) Genearate version-info.properties for hadoop and ozone

2018-08-08 Thread Elek, Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572946#comment-16572946
 ] 

Elek, Marton commented on HDDS-219:
---

We had an offline discussion about the hadoop version and I am convinced by 
[~Sandeep Nemuri] that the hadoop version is not so important in the output. It 
requires a lot of space and makes the output more complex. And the only 
situation when we need it is running ozone container-service as part of an 
existing hadoop cluster. But in that case we can display both the versions  
(hadoop version + hdds version) on hdds datanode ui. (And from the command line 
we can use hadoop version + ozone version)

> Genearate version-info.properties for hadoop and ozone
> --
>
> Key: HDDS-219
> URL: https://issues.apache.org/jira/browse/HDDS-219
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Elek, Marton
>Assignee: Sandeep Nemuri
>Priority: Major
>  Labels: newbie
> Fix For: 0.2.1
>
> Attachments: HDDS-219.001.patch
>
>
> org.apache.hadoop.util.VersionInfo provides an api to show the actual version 
> information.
> We need to generate hdds-version-info.properties and 
> ozone-version-info.properties as part of the build process(most probably in 
> hdds/common, ozone/common projects)  and print out the available versions in 
> case of 'ozone version' command



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-219) Genearate version-info.properties for hadoop and ozone

2018-08-08 Thread Elek, Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572859#comment-16572859
 ] 

Elek, Marton commented on HDDS-219:
---

Just to summarize again. Most of the points in my previous comment were just 
notes and thoughts.

1. I think it would be great to add the hadoop version to the output of ozone 
version (to show the currently used hadoop common version).

2. We can adjust the calculation of the source checksum but it could be done in 
separated jira as well.

> Genearate version-info.properties for hadoop and ozone
> --
>
> Key: HDDS-219
> URL: https://issues.apache.org/jira/browse/HDDS-219
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Elek, Marton
>Assignee: Sandeep Nemuri
>Priority: Major
>  Labels: newbie
> Fix For: 0.2.1
>
> Attachments: HDDS-219.001.patch
>
>
> org.apache.hadoop.util.VersionInfo provides an api to show the actual version 
> information.
> We need to generate hdds-version-info.properties and 
> ozone-version-info.properties as part of the build process(most probably in 
> hdds/common, ozone/common projects)  and print out the available versions in 
> case of 'ozone version' command



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-219) Genearate version-info.properties for hadoop and ozone

2018-07-27 Thread Sandeep Nemuri (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559725#comment-16559725
 ] 

Sandeep Nemuri commented on HDDS-219:
-

[~anu], I will be updating the v2 patch soon. 

 
 

> Genearate version-info.properties for hadoop and ozone
> --
>
> Key: HDDS-219
> URL: https://issues.apache.org/jira/browse/HDDS-219
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Elek, Marton
>Assignee: Sandeep Nemuri
>Priority: Major
>  Labels: newbie
> Fix For: 0.2.1
>
> Attachments: HDDS-219.001.patch
>
>
> org.apache.hadoop.util.VersionInfo provides an api to show the actual version 
> information.
> We need to generate hdds-version-info.properties and 
> ozone-version-info.properties as part of the build process(most probably in 
> hdds/common, ozone/common projects)  and print out the available versions in 
> case of 'ozone version' command



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-219) Genearate version-info.properties for hadoop and ozone

2018-07-27 Thread Anu Engineer (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559716#comment-16559716
 ] 

Anu Engineer commented on HDDS-219:
---

bq.  Anu Engineer: Do you have any thoughts against maintaining two versions 
(hdds + ozone)

No, I am good with maintaining 2 versions. That would be the right approach 
since these are two different systems.

> Genearate version-info.properties for hadoop and ozone
> --
>
> Key: HDDS-219
> URL: https://issues.apache.org/jira/browse/HDDS-219
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Elek, Marton
>Assignee: Sandeep Nemuri
>Priority: Major
>  Labels: newbie
> Fix For: 0.2.1
>
> Attachments: HDDS-219.001.patch
>
>
> org.apache.hadoop.util.VersionInfo provides an api to show the actual version 
> information.
> We need to generate hdds-version-info.properties and 
> ozone-version-info.properties as part of the build process(most probably in 
> hdds/common, ozone/common projects)  and print out the available versions in 
> case of 'ozone version' command



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-219) Genearate version-info.properties for hadoop and ozone

2018-07-26 Thread genericqa (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558235#comment-16558235
 ] 

genericqa commented on HDDS-219:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m 
 7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m 
55s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 40s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
52s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
26s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m  
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 28m  
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
24s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green}  0m 
33s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 4 line(s) that end in whitespace. Use git 
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply 
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 20s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
52s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m  
9s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
43s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
47s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}128m  4s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 |
| JIRA Issue | HDDS-219 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12932927/HDDS-219.001.patch |
| Optional 

[jira] [Commented] (HDDS-219) Genearate version-info.properties for hadoop and ozone

2018-07-26 Thread Elek, Marton (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558117#comment-16558117
 ] 

Elek, Marton commented on HDDS-219:
---

Thanks [~Sandeep Nemuri] the patch. Overall it looks good to me.

1. The patch introduces two versions (ozone and hdds version). Currently hdds 
and ozone versions are the same and we use just one version in the maven 
(hdds.version) but later it could be separated. I am happy with this approach, 
but it could be more confusing (but worst case we can hide one of the versions 
from the ui/output). [~anu]: Do you have any thoughts against maintaining two 
versions (hdds + ozone)

2. Yes, improving the output would be super cool...

3. We can also print out the hadoop version in 'ozone version' (good to know 
which hadoop version is used as we plan to use container-service with older 
hadoop versions)

4. I was not familiar the checksum part until now but I checked the source 
code. It seems that the hadoop-maven-plugin does a checksum from the included 
sources. As it's a generic hdds/ozone version I would consider to include all 
of the hdds/ozone sources in the checksum (except the generated java files) not 
just from the ozone/hdds common project. It would help to detect any local code 
change. Ideally we should get the same hash code checking out the same code 
base, but getting a different hash in any java/protobuf change). 

5. After this patch we need to think about 
org.apache.hadoop.hdds.server.ServiceRuntimeInfo and add the multiple version 
to the hdds/ozone implementation of this class. (in seperated jira)

6. Just a note: The patch includes some very minor code duplication 
(OzoneVersion.java/HddsVersion.java). I am happy with it. The classes are 
simple, and it could be more important to avoid additional dependencies between 
the projects.

> Genearate version-info.properties for hadoop and ozone
> --
>
> Key: HDDS-219
> URL: https://issues.apache.org/jira/browse/HDDS-219
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Elek, Marton
>Assignee: Sandeep Nemuri
>Priority: Major
>  Labels: newbie
> Fix For: 0.2.1
>
> Attachments: HDDS-219.001.patch
>
>
> org.apache.hadoop.util.VersionInfo provides an api to show the actual version 
> information.
> We need to generate hdds-version-info.properties and 
> ozone-version-info.properties as part of the build process(most probably in 
> hdds/common, ozone/common projects)  and print out the available versions in 
> case of 'ozone version' command



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-219) Genearate version-info.properties for hadoop and ozone

2018-07-24 Thread Sandeep Nemuri (JIRA)


[ 
https://issues.apache.org/jira/browse/HDDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554650#comment-16554650
 ] 

Sandeep Nemuri commented on HDDS-219:
-

[~elek], Attaching the v1 patch to print Ozone and HDDS versions.  
[^HDDS-219.001.patch]

Below is the output of `ozone version` command.

 
{code:java}
~/g/hadoop> ./ozone version
Ozone 0.2.1-SNAPSHOT
Source code repository https://github.com/apache/hadoop.git -r 
ff7c2eda34c2c40ad71b50df6462a661bd213fbd
Compiled by snemuri on 2018-07-24T17:42Z
Compiled with protoc 2.5.0
>From source with checksum 61bff39be6caa0bb8b3e31be770bf
This command was run using 
/Users/snemuri/git/hadoop/hadoop-dist/target/ozone/share/hadoop/ozone/hadoop-ozone-common-0.2.1-SNAPSHOT.jar
HDDS 0.2.1-SNAPSHOT
Source code repository https://github.com/apache/hadoop.git -r 
ff7c2eda34c2c40ad71b50df6462a661bd213fbd
Compiled by snemuri on 2018-07-24T17:42Z
Compiled with protoc 2.5.0
>From source with checksum 25fc3311f5435a42856b49979728fb
This command was run using 
/Users/snemuri/git/hadoop/hadoop-dist/target/ozone/share/hadoop/hdds/hadoop-hdds-common-0.2.1-SNAPSHOT.jar
 
{code}
Added Ozone and HDDFS versions to the same command as HDDS doesn't have any 
cli. 

We could do some cosmetic changes to the output, Something like spark version.

 
{code:java}
spark-submit --version
SPARK_MAJOR_VERSION is set to 2, using Spark2
Welcome to
  __
 / __/__ ___ _/ /__
 _\ \/ _ \/ _ `/ __/ '_/
 /___/ .__/\_,_/_/ /_/\_\ version 2.2.0.2.6.4.0-91
 /_/
Using Scala version 2.11.8, Java HotSpot(TM) 64-Bit Server VM, 1.8.0_112
Branch HEAD
Compiled by user jenkins on 2018-01-04T10:31:44Z
Revision a24017869f5450397136ee8b11be818e7cd3facb
Url g...@github.com:hortonworks/spark2.git 
{code}
Let me know your thoughts on this. 

> Genearate version-info.properties for hadoop and ozone
> --
>
> Key: HDDS-219
> URL: https://issues.apache.org/jira/browse/HDDS-219
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>Reporter: Elek, Marton
>Assignee: Sandeep Nemuri
>Priority: Major
>  Labels: newbie
> Fix For: 0.2.1
>
> Attachments: HDDS-219.001.patch
>
>
> org.apache.hadoop.util.VersionInfo provides an api to show the actual version 
> information.
> We need to generate hdds-version-info.properties and 
> ozone-version-info.properties as part of the build process(most probably in 
> hdds/common, ozone/common projects)  and print out the available versions in 
> case of 'ozone version' command



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org