[jira] [Commented] (HDDS-380) Remove synchronization from ChunkGroupOutputStream and ChunkOutputStream

2018-08-30 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598139#comment-16598139
 ] 

Hudson commented on HDDS-380:
-

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14855 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14855/])
HDDS-380. Remove synchronization from ChunkGroupOutputStream and (nanda: rev 
0bd4217194ae50ec30e386b200fcfa54c069f042)
* (edit) 
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ChunkGroupOutputStream.java
* (edit) 
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/ChunkOutputStream.java


> Remove synchronization from ChunkGroupOutputStream and ChunkOutputStream
> 
>
> Key: HDDS-380
> URL: https://issues.apache.org/jira/browse/HDDS-380
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: Ozone Client
>Reporter: Shashikant Banerjee
>Assignee: Shashikant Banerjee
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-380.00.patch
>
>
> In one of the code review for HDDS-247, it was suggested  that 
> ChunkGroupOutputStream/ChunkOutputStream may not be thread safe as the Java 
> OutputStream subclasses are generally non-thread-safe for performance 
> reasons. If users want thread safe, they can easily synchronize it 
> themselves. This Jira aims to remove synchronization from 
> ChunkGroupOutputStream and ChunkOutputStream.
> cc [~szetszwo].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-380) Remove synchronization from ChunkGroupOutputStream and ChunkOutputStream

2018-08-29 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596918#comment-16596918
 ] 

Tsz Wo Nicholas Sze commented on HDDS-380:
--

Not surprisingly, all tests pass without any further changes after removed 
"synchronized" from ChunkOutputStream and ChunkGroupOutputStream.  Thanks, 
[~shashikant]!

> Remove synchronization from ChunkGroupOutputStream and ChunkOutputStream
> 
>
> Key: HDDS-380
> URL: https://issues.apache.org/jira/browse/HDDS-380
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: Ozone Client
>Reporter: Shashikant Banerjee
>Assignee: Shashikant Banerjee
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-380.00.patch
>
>
> In one of the code review for HDDS-247, it was suggested  that 
> ChunkGroupOutputStream/ChunkOutputStream may not be thread safe as the Java 
> OutputStream subclasses are generally non-thread-safe for performance 
> reasons. If users want thread safe, they can easily synchronize it 
> themselves. This Jira aims to remove synchronization from 
> ChunkGroupOutputStream and ChunkOutputStream.
> cc [~szetszwo].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-380) Remove synchronization from ChunkGroupOutputStream and ChunkOutputStream

2018-08-29 Thread Nanda kumar (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596055#comment-16596055
 ] 

Nanda kumar commented on HDDS-380:
--

Thanks [~shashikant] for the contribution. I have committed this to trunk.

> Remove synchronization from ChunkGroupOutputStream and ChunkOutputStream
> 
>
> Key: HDDS-380
> URL: https://issues.apache.org/jira/browse/HDDS-380
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: Ozone Client
>Reporter: Shashikant Banerjee
>Assignee: Shashikant Banerjee
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-380.00.patch
>
>
> In one of the code review for HDDS-247, it was suggested  that 
> ChunkGroupOutputStream/ChunkOutputStream may not be thread safe as the Java 
> OutputStream subclasses are generally non-thread-safe for performance 
> reasons. If users want thread safe, they can easily synchronize it 
> themselves. This Jira aims to remove synchronization from 
> ChunkGroupOutputStream and ChunkOutputStream.
> cc [~szetszwo].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-380) Remove synchronization from ChunkGroupOutputStream and ChunkOutputStream

2018-08-29 Thread Nanda kumar (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596049#comment-16596049
 ] 

Nanda kumar commented on HDDS-380:
--

Thanks [~shashikant] for the patch. +1, looks good to me. I will commit this 
shortly.

> Remove synchronization from ChunkGroupOutputStream and ChunkOutputStream
> 
>
> Key: HDDS-380
> URL: https://issues.apache.org/jira/browse/HDDS-380
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: Ozone Client
>Reporter: Shashikant Banerjee
>Assignee: Shashikant Banerjee
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-380.00.patch
>
>
> In one of the code review for HDDS-247, it was suggested  that 
> ChunkGroupOutputStream/ChunkOutputStream may not be thread safe as the Java 
> OutputStream subclasses are generally non-thread-safe for performance 
> reasons. If users want thread safe, they can easily synchronize it 
> themselves. This Jira aims to remove synchronization from 
> ChunkGroupOutputStream and ChunkOutputStream.
> cc [~szetszwo].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDDS-380) Remove synchronization from ChunkGroupOutputStream and ChunkOutputStream

2018-08-28 Thread genericqa (JIRA) 


[ 
https://issues.apache.org/jira/browse/HDDS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594655#comment-16594655
 ] 

genericqa commented on HDDS-380:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m  
2s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m 
56s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m 
49s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
59s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
16m 39s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
17s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
54s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 18m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 18m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 11s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
30s{color} | {color:green} client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
34s{color} | {color:green} client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
39s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}103m 13s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 |
| JIRA Issue | HDDS-380 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12937380/HDDS-380.00.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 4b65faedb50f 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 75691ad |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDD