[jira] [Commented] (HDFS-10858) FBR processing may generate incorrect reportedBlock-blockGroup mapping
[
https://issues.apache.org/jira/browse/HDFS-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485699#comment-15485699
]
Hudson commented on HDFS-10858:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10429 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/10429/])
HDFS-10858. FBR processing may generate incorrect (jing9: rev
72dfb048a9a7be64b371b74478b90150bf300d35)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* (add)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddStripedBlockInFBR.java
> FBR processing may generate incorrect reportedBlock-blockGroup mapping
> --
>
> Key: HDFS-10858
> URL: https://issues.apache.org/jira/browse/HDFS-10858
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
>Affects Versions: 3.0.0-alpha1
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Blocker
> Fix For: 3.0.0-alpha2
>
> Attachments: HDFS-10858.000.patch
>
>
> In BlockManager#reportDiffSorted:
> {code}
> } else if (reportedState == ReplicaState.FINALIZED &&
>(storedBlock.findStorageInfo(storageInfo) == -1 ||
> corruptReplicas.isReplicaCorrupt(storedBlock, dn))) {
> // Add replica if appropriate. If the replica was previously corrupt
> // but now okay, it might need to be updated.
> toAdd.add(new BlockInfoToAdd(storedBlock, replica));
> }
> {code}
> "new BlockInfoToAdd(storedBlock, replica)" is wrong because "replica" (i.e.,
> the reported block) is a reused object provided by BlockListAsLongs#iterator.
> Later this object is reused by directly changing its ID/GS. Thus
> {{addStoredBlock}} can get wrong (reportedBlock, stored-BlockInfo) mapping.
> For EC the reported block is used to calculate the internal block index. Thus
> the bug can completely corrupt the EC block group internal states.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10858) FBR processing may generate incorrect reportedBlock-blockGroup mapping
[
https://issues.apache.org/jira/browse/HDFS-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485556#comment-15485556
]
Hadoop QA commented on HDFS-10858:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
53s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 24s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch
generated 3 new + 127 unchanged - 0 fixed = 130 total (was 127) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 59m 2s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 78m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.TestFileCreationDelete |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | HDFS-10858 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12828116/HDFS-10858.000.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 4e221a08fe00 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 58ed4fa |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/16716/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/16716/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/16716/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/16716/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> FBR processing may generate incorrect reportedBlock-blockGroup mapping
> --
>
> Key:
[jira] [Commented] (HDFS-10858) FBR processing may generate incorrect reportedBlock-blockGroup mapping
[
https://issues.apache.org/jira/browse/HDFS-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485405#comment-15485405
]
Andrew Wang commented on HDFS-10858:
+1 LGTM, nice find Jing!
> FBR processing may generate incorrect reportedBlock-blockGroup mapping
> --
>
> Key: HDFS-10858
> URL: https://issues.apache.org/jira/browse/HDFS-10858
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
>Affects Versions: 3.0.0-alpha1
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Blocker
> Attachments: HDFS-10858.000.patch
>
>
> In BlockManager#reportDiffSorted:
> {code}
> } else if (reportedState == ReplicaState.FINALIZED &&
>(storedBlock.findStorageInfo(storageInfo) == -1 ||
> corruptReplicas.isReplicaCorrupt(storedBlock, dn))) {
> // Add replica if appropriate. If the replica was previously corrupt
> // but now okay, it might need to be updated.
> toAdd.add(new BlockInfoToAdd(storedBlock, replica));
> }
> {code}
> "new BlockInfoToAdd(storedBlock, replica)" is wrong because "replica" (i.e.,
> the reported block) is a reused object provided by BlockListAsLongs#iterator.
> Later this object is reused by directly changing its ID/GS. Thus
> {{addStoredBlock}} can get wrong (reportedBlock, stored-BlockInfo) mapping.
> For EC the reported block is used to calculate the internal block index. Thus
> the bug can completely corrupt the EC block group internal states.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10858) FBR processing may generate incorrect reportedBlock-blockGroup mapping
[
https://issues.apache.org/jira/browse/HDFS-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484885#comment-15484885
]
Jing Zhao commented on HDFS-10858:
--
A simple fix is:
{code}
@@ -2677,7 +2677,7 @@ private void reportDiffSortedInner(
corruptReplicas.isReplicaCorrupt(storedBlock, dn))) {
// Add replica if appropriate. If the replica was previously corrupt
// but now okay, it might need to be updated.
- toAdd.add(new BlockInfoToAdd(storedBlock, replica));
+ toAdd.add(new BlockInfoToAdd(storedBlock, new Block(replica)));
}
}
{code}
I will try to write a unit test for this and will upload a patch afterwards.
> FBR processing may generate incorrect reportedBlock-blockGroup mapping
> --
>
> Key: HDFS-10858
> URL: https://issues.apache.org/jira/browse/HDFS-10858
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
>Affects Versions: 3.0.0-alpha1
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Blocker
>
> In BlockManager#reportDiffSorted:
> {code}
> } else if (reportedState == ReplicaState.FINALIZED &&
>(storedBlock.findStorageInfo(storageInfo) == -1 ||
> corruptReplicas.isReplicaCorrupt(storedBlock, dn))) {
> // Add replica if appropriate. If the replica was previously corrupt
> // but now okay, it might need to be updated.
> toAdd.add(new BlockInfoToAdd(storedBlock, replica));
> }
> {code}
> "new BlockInfoToAdd(storedBlock, replica)" is wrong because "replica" (i.e.,
> the reported block) is a reused object provided by BlockListAsLongs#iterator.
> Later this object is reused by directly changing its ID/GS. Thus
> {{addStoredBlock}} can get wrong (reportedBlock, stored-BlockInfo) mapping.
> For EC the reported block is used to calculate the internal block index. Thus
> the bug can completely corrupt the EC block group internal states.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
