[jira] [Commented] (HDFS-10870) Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
[
https://issues.apache.org/jira/browse/HDFS-10870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507283#comment-15507283
]
John Zhuge commented on HDFS-10870:
---
Thanks [~eddyxu] for the review and commit!
Thanks [~raviprak], this fix is to prevent users from wrongly expecting ACLs to
be enabled.
> Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
> --
>
> Key: HDFS-10870
> URL: https://issues.apache.org/jira/browse/HDFS-10870
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.6.0
>Reporter: John Zhuge
>Assignee: John Zhuge
>Priority: Trivial
> Fix For: 2.6.5
>
> Attachments: HDFS-10870-branch-2.6.001.patch
>
>
> Wrong {{dfs.namenode.acls.enabled = true}} in
> {{HdfsPermissionsGuide.apt.vm}}. The default should be {{false}} as correctly
> stated in the description and in {{DFS_NAMENODE_ACLS_ENABLED_DEFAULT}}:
> {code}
> * <<>>
>Set to true to enable support for HDFS ACLs (Access Control Lists). By
>default, ACLs are disabled. When ACLs are disabled, the NameNode
> rejects
>all attempts to set an ACL.
> {code}
> {code:title=DFSConfigKeys.java}
> public static final String DFS_NAMENODE_ACLS_ENABLED_KEY =
> "dfs.namenode.acls.enabled";
> public static final boolean DFS_NAMENODE_ACLS_ENABLED_DEFAULT = false;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10870) Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
[
https://issues.apache.org/jira/browse/HDFS-10870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507175#comment-15507175
]
Ravi Prakash commented on HDFS-10870:
-
Sorry. Never mind. This is just a change in the doc. Thanks Eddy and John
> Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
> --
>
> Key: HDFS-10870
> URL: https://issues.apache.org/jira/browse/HDFS-10870
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.6.0
>Reporter: John Zhuge
>Assignee: John Zhuge
>Priority: Trivial
> Fix For: 2.6.5
>
> Attachments: HDFS-10870-branch-2.6.001.patch
>
>
> Wrong {{dfs.namenode.acls.enabled = true}} in
> {{HdfsPermissionsGuide.apt.vm}}. The default should be {{false}} as correctly
> stated in the description and in {{DFS_NAMENODE_ACLS_ENABLED_DEFAULT}}:
> {code}
> * <<>>
>Set to true to enable support for HDFS ACLs (Access Control Lists). By
>default, ACLs are disabled. When ACLs are disabled, the NameNode
> rejects
>all attempts to set an ACL.
> {code}
> {code:title=DFSConfigKeys.java}
> public static final String DFS_NAMENODE_ACLS_ENABLED_KEY =
> "dfs.namenode.acls.enabled";
> public static final boolean DFS_NAMENODE_ACLS_ENABLED_DEFAULT = false;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10870) Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
[
https://issues.apache.org/jira/browse/HDFS-10870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507172#comment-15507172
]
Ravi Prakash commented on HDFS-10870:
-
Would this not be a backward incompatible change?
> Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
> --
>
> Key: HDFS-10870
> URL: https://issues.apache.org/jira/browse/HDFS-10870
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.6.0
>Reporter: John Zhuge
>Assignee: John Zhuge
>Priority: Trivial
> Fix For: 2.6.5
>
> Attachments: HDFS-10870-branch-2.6.001.patch
>
>
> Wrong {{dfs.namenode.acls.enabled = true}} in
> {{HdfsPermissionsGuide.apt.vm}}. The default should be {{false}} as correctly
> stated in the description and in {{DFS_NAMENODE_ACLS_ENABLED_DEFAULT}}:
> {code}
> * <<>>
>Set to true to enable support for HDFS ACLs (Access Control Lists). By
>default, ACLs are disabled. When ACLs are disabled, the NameNode
> rejects
>all attempts to set an ACL.
> {code}
> {code:title=DFSConfigKeys.java}
> public static final String DFS_NAMENODE_ACLS_ENABLED_KEY =
> "dfs.namenode.acls.enabled";
> public static final boolean DFS_NAMENODE_ACLS_ENABLED_DEFAULT = false;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10870) Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
[
https://issues.apache.org/jira/browse/HDFS-10870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504280#comment-15504280
]
Lei (Eddy) Xu commented on HDFS-10870:
--
+1. LGTM.
The warnings are not relevant.
> Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
> --
>
> Key: HDFS-10870
> URL: https://issues.apache.org/jira/browse/HDFS-10870
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.6.0
>Reporter: John Zhuge
>Assignee: John Zhuge
>Priority: Trivial
> Fix For: 2.6.5
>
> Attachments: HDFS-10870-branch-2.6.001.patch
>
>
> Wrong {{dfs.namenode.acls.enabled = true}} in
> {{HdfsPermissionsGuide.apt.vm}}. The default should be {{false}} as correctly
> stated in the description and in {{DFS_NAMENODE_ACLS_ENABLED_DEFAULT}}:
> {code}
> * <<>>
>Set to true to enable support for HDFS ACLs (Access Control Lists). By
>default, ACLs are disabled. When ACLs are disabled, the NameNode
> rejects
>all attempts to set an ACL.
> {code}
> {code:title=DFSConfigKeys.java}
> public static final String DFS_NAMENODE_ACLS_ENABLED_KEY =
> "dfs.namenode.acls.enabled";
> public static final boolean DFS_NAMENODE_ACLS_ENABLED_DEFAULT = false;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10870) Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
[
https://issues.apache.org/jira/browse/HDFS-10870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504274#comment-15504274
]
Hadoop QA commented on HDFS-10870:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 11m
26s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
45s{color} | {color:green} branch-2.6 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
58s{color} | {color:green} branch-2.6 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1317 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
33s{color} | {color:red} The patch 18 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
29s{color} | {color:red} The patch generated 38 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 43s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:44eef0e |
| JIRA Issue | HDFS-10870 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12829230/HDFS-10870-branch-2.6.001.patch
|
| Optional Tests | asflicense mvnsite |
| uname | Linux 1fdfb472c5f8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | branch-2.6 / 7ee4982 |
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/16794/artifact/patchprocess/whitespace-eol.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/16794/artifact/patchprocess/whitespace-tabs.txt
|
| asflicense |
https://builds.apache.org/job/PreCommit-HDFS-Build/16794/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/16794/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
> --
>
> Key: HDFS-10870
> URL: https://issues.apache.org/jira/browse/HDFS-10870
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.6.0
>Reporter: John Zhuge
>Assignee: John Zhuge
>Priority: Trivial
> Fix For: 2.6.5
>
> Attachments: HDFS-10870-branch-2.6.001.patch
>
>
> Wrong {{dfs.namenode.acls.enabled = true}} in
> {{HdfsPermissionsGuide.apt.vm}}. The default should be {{false}} as correctly
> stated in the description and in {{DFS_NAMENODE_ACLS_ENABLED_DEFAULT}}:
> {code}
> * <<>>
>Set to true to enable support for HDFS ACLs (Access Control Lists). By
>default, ACLs are disabled. When ACLs are disabled, the NameNode
> rejects
>all attempts to set an ACL.
> {code}
> {code:title=DFSConfigKeys.java}
> public static final String DFS_NAMENODE_ACLS_ENABLED_KEY =
> "dfs.namenode.acls.enabled";
> public static final boolean DFS_NAMENODE_ACLS_ENABLED_DEFAULT = false;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10870) Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
[
https://issues.apache.org/jira/browse/HDFS-10870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504196#comment-15504196
]
John Zhuge commented on HDFS-10870:
---
The whitespace and asflicense warnings are unrelated. Probably Yetus problem?
> Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
> --
>
> Key: HDFS-10870
> URL: https://issues.apache.org/jira/browse/HDFS-10870
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.6.0
>Reporter: John Zhuge
>Assignee: John Zhuge
>Priority: Trivial
> Fix For: 2.6.5
>
> Attachments: HDFS-10870-branch-2.6.001.patch
>
>
> Wrong {{dfs.namenode.acls.enabled = true}} in
> {{HdfsPermissionsGuide.apt.vm}}. The default should be {{false}} as correctly
> stated in the description and in {{DFS_NAMENODE_ACLS_ENABLED_DEFAULT}}:
> {code}
> * <<>>
>Set to true to enable support for HDFS ACLs (Access Control Lists). By
>default, ACLs are disabled. When ACLs are disabled, the NameNode
> rejects
>all attempts to set an ACL.
> {code}
> {code:title=DFSConfigKeys.java}
> public static final String DFS_NAMENODE_ACLS_ENABLED_KEY =
> "dfs.namenode.acls.enabled";
> public static final boolean DFS_NAMENODE_ACLS_ENABLED_DEFAULT = false;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10870) Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
[
https://issues.apache.org/jira/browse/HDFS-10870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503916#comment-15503916
]
Hadoop QA commented on HDFS-10870:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
6s{color} | {color:green} branch-2.6 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
6s{color} | {color:green} branch-2.6 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1161 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
27s{color} | {color:red} The patch 18 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
29s{color} | {color:red} The patch generated 38 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 4s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:44eef0e |
| JIRA Issue | HDFS-10870 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12829230/HDFS-10870-branch-2.6.001.patch
|
| Optional Tests | asflicense mvnsite |
| uname | Linux 21a1874fac54 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | branch-2.6 / 7ee4982 |
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/16793/artifact/patchprocess/whitespace-eol.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/16793/artifact/patchprocess/whitespace-tabs.txt
|
| asflicense |
https://builds.apache.org/job/PreCommit-HDFS-Build/16793/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/16793/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Wrong dfs.namenode.acls.enabled default in HdfsPermissionsGuide.apt.vm
> --
>
> Key: HDFS-10870
> URL: https://issues.apache.org/jira/browse/HDFS-10870
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.6.0
>Reporter: John Zhuge
>Assignee: John Zhuge
>Priority: Trivial
> Fix For: 2.6.5
>
> Attachments: HDFS-10870-branch-2.6.001.patch
>
>
> Wrong {{dfs.namenode.acls.enabled = true}} in
> {{HdfsPermissionsGuide.apt.vm}}. The default should be {{false}} as correctly
> stated in the description and in {{DFS_NAMENODE_ACLS_ENABLED_DEFAULT}}:
> {code}
> * <<>>
>Set to true to enable support for HDFS ACLs (Access Control Lists). By
>default, ACLs are disabled. When ACLs are disabled, the NameNode
> rejects
>all attempts to set an ACL.
> {code}
> {code:title=DFSConfigKeys.java}
> public static final String DFS_NAMENODE_ACLS_ENABLED_KEY =
> "dfs.namenode.acls.enabled";
> public static final boolean DFS_NAMENODE_ACLS_ENABLED_DEFAULT = false;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
