[jira] [Commented] (HDFS-10876) Dispatcher#dispatch should log IOException stacktrace
[
https://issues.apache.org/jira/browse/HDFS-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517648#comment-15517648
]
Hudson commented on HDFS-10876:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10481 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/10481/])
HDFS-10876. Dispatcher#dispatch should log IOException stacktrace. (weichiu:
rev 74b3dd514c86b46197e2e19d9824a423715cab30)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
> Dispatcher#dispatch should log IOException stacktrace
> -
>
> Key: HDFS-10876
> URL: https://issues.apache.org/jira/browse/HDFS-10876
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
>Affects Versions: 2.6.0
>Reporter: Wei-Chiu Chuang
>Assignee: Manoj Govindassamy
>Priority: Trivial
> Labels: newbie
> Fix For: 2.8.0, 3.0.0-alpha2
>
> Attachments: HDFS-10876.001.patch
>
>
> This error logging should be improved. A warning log should record the
> stacktrace as well.
> {code:title=Dispatcher#dispatch}
> try {
> ...
> } catch (IOException e) {
> LOG.warn("Failed to move " + this + ": " + e.getMessage());
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10876) Dispatcher#dispatch should log IOException stacktrace
[
https://issues.apache.org/jira/browse/HDFS-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514764#comment-15514764
]
Manoj Govindassamy commented on HDFS-10876:
---
Thanks for the review [~jojochuang] and [~liuml07].
> Dispatcher#dispatch should log IOException stacktrace
> -
>
> Key: HDFS-10876
> URL: https://issues.apache.org/jira/browse/HDFS-10876
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
>Affects Versions: 2.6.0
>Reporter: Wei-Chiu Chuang
>Assignee: Manoj Govindassamy
>Priority: Trivial
> Labels: newbie
> Attachments: HDFS-10876.001.patch
>
>
> This error logging should be improved. A warning log should record the
> stacktrace as well.
> {code:title=Dispatcher#dispatch}
> try {
> ...
> } catch (IOException e) {
> LOG.warn("Failed to move " + this + ": " + e.getMessage());
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10876) Dispatcher#dispatch should log IOException stacktrace
[
https://issues.apache.org/jira/browse/HDFS-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514755#comment-15514755
]
Mingliang Liu commented on HDFS-10876:
--
It makes sense. Thanks.
> Dispatcher#dispatch should log IOException stacktrace
> -
>
> Key: HDFS-10876
> URL: https://issues.apache.org/jira/browse/HDFS-10876
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
>Affects Versions: 2.6.0
>Reporter: Wei-Chiu Chuang
>Assignee: Manoj Govindassamy
>Priority: Trivial
> Labels: newbie
> Attachments: HDFS-10876.001.patch
>
>
> This error logging should be improved. A warning log should record the
> stacktrace as well.
> {code:title=Dispatcher#dispatch}
> try {
> ...
> } catch (IOException e) {
> LOG.warn("Failed to move " + this + ": " + e.getMessage());
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10876) Dispatcher#dispatch should log IOException stacktrace
[
https://issues.apache.org/jira/browse/HDFS-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514711#comment-15514711
]
Wei-Chiu Chuang commented on HDFS-10876:
Hello [~liuml07], any other comments on log level? Thanks!
> Dispatcher#dispatch should log IOException stacktrace
> -
>
> Key: HDFS-10876
> URL: https://issues.apache.org/jira/browse/HDFS-10876
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
>Affects Versions: 2.6.0
>Reporter: Wei-Chiu Chuang
>Assignee: Manoj Govindassamy
>Priority: Trivial
> Labels: newbie
> Attachments: HDFS-10876.001.patch
>
>
> This error logging should be improved. A warning log should record the
> stacktrace as well.
> {code:title=Dispatcher#dispatch}
> try {
> ...
> } catch (IOException e) {
> LOG.warn("Failed to move " + this + ": " + e.getMessage());
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10876) Dispatcher#dispatch should log IOException stacktrace
[
https://issues.apache.org/jira/browse/HDFS-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507649#comment-15507649
]
Hadoop QA commented on HDFS-10876:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
49s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
49s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 66m
15s{color} | {color:green} hadoop-hdfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 86m 24s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | HDFS-10876 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12829424/HDFS-10876.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 4285ffe72eff 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18
21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / e45307c |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/16810/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/16810/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Dispatcher#dispatch should log IOException stacktrace
> -
>
> Key: HDFS-10876
> URL: https://issues.apache.org/jira/browse/HDFS-10876
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
>Affects Versions: 2.6.0
>Reporter: Wei-Chiu Chuang
>Assignee: Manoj Govindassamy
>Priority: Trivial
> Labels: newbie
>
[jira] [Commented] (HDFS-10876) Dispatcher#dispatch should log IOException stacktrace
[
https://issues.apache.org/jira/browse/HDFS-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507539#comment-15507539
]
Wei-Chiu Chuang commented on HDFS-10876:
INFO may be fine.
However, I am seeing an IOE in balancer that disrupts normal balancer
operation. It only occurs after several hours of balancing.
2016-05-14 08:56:27,636 WARN [pool-2302-thread-7] balancer.Dispatcher
(Dispatcher.java:dispatch(325)) - Failed to move blk_1550828018_1100035582559
with size=167 from 10.17.1.1:1004:DISK to 10.17.1.2:1004:DISK through
10.17.1.1:1004: Can't re-compute encryption key for nonce, since the required
block key (keyID=-327392027) doesn't exist. Current key: -327392024
Balancer aborts after five iterations if no blocks are moved. If you make it
DEBUG it's going to be really hard to tell what's going on. From a support
perspective it's going to generated many support tickets.
> Dispatcher#dispatch should log IOException stacktrace
> -
>
> Key: HDFS-10876
> URL: https://issues.apache.org/jira/browse/HDFS-10876
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
>Affects Versions: 2.6.0
>Reporter: Wei-Chiu Chuang
>Assignee: Manoj Govindassamy
>Priority: Trivial
> Labels: newbie
> Attachments: HDFS-10876.001.patch
>
>
> This error logging should be improved. A warning log should record the
> stacktrace as well.
> {code:title=Dispatcher#dispatch}
> try {
> ...
> } catch (IOException e) {
> LOG.warn("Failed to move " + this + ": " + e.getMessage());
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10876) Dispatcher#dispatch should log IOException stacktrace
[
https://issues.apache.org/jira/browse/HDFS-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507476#comment-15507476
]
Manoj Govindassamy commented on HDFS-10876:
---
Thanks for the review. Exception is because of the proxy or target issue during
balancing. Upon these issues, 10 second delay for proxy and target are
activated. So, would logging this stacktrace as an INFO message be OK ? But, I
also see your point of not spamming the logs with stack traces and may be DEBUG
for stack trace sounds like a good idea.
[~jojochuang] any thoughts please ?
> Dispatcher#dispatch should log IOException stacktrace
> -
>
> Key: HDFS-10876
> URL: https://issues.apache.org/jira/browse/HDFS-10876
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
>Affects Versions: 2.6.0
>Reporter: Wei-Chiu Chuang
>Assignee: Manoj Govindassamy
>Priority: Trivial
> Labels: newbie
> Attachments: HDFS-10876.001.patch
>
>
> This error logging should be improved. A warning log should record the
> stacktrace as well.
> {code:title=Dispatcher#dispatch}
> try {
> ...
> } catch (IOException e) {
> LOG.warn("Failed to move " + this + ": " + e.getMessage());
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10876) Dispatcher#dispatch should log IOException stacktrace
[
https://issues.apache.org/jira/browse/HDFS-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507436#comment-15507436
]
Mingliang Liu commented on HDFS-10876:
--
I'm also thinking of logging the exception stack trace in INFO or DEBUG level.
> Dispatcher#dispatch should log IOException stacktrace
> -
>
> Key: HDFS-10876
> URL: https://issues.apache.org/jira/browse/HDFS-10876
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
>Affects Versions: 2.6.0
>Reporter: Wei-Chiu Chuang
>Assignee: Manoj Govindassamy
>Priority: Trivial
> Labels: newbie
> Attachments: HDFS-10876.001.patch
>
>
> This error logging should be improved. A warning log should record the
> stacktrace as well.
> {code:title=Dispatcher#dispatch}
> try {
> ...
> } catch (IOException e) {
> LOG.warn("Failed to move " + this + ": " + e.getMessage());
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-10876) Dispatcher#dispatch should log IOException stacktrace
[
https://issues.apache.org/jira/browse/HDFS-10876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507431#comment-15507431
]
Mingliang Liu commented on HDFS-10876:
--
+1 pending on Jenkins.
> Dispatcher#dispatch should log IOException stacktrace
> -
>
> Key: HDFS-10876
> URL: https://issues.apache.org/jira/browse/HDFS-10876
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
>Affects Versions: 2.6.0
>Reporter: Wei-Chiu Chuang
>Assignee: Manoj Govindassamy
>Priority: Trivial
> Labels: newbie
> Attachments: HDFS-10876.001.patch
>
>
> This error logging should be improved. A warning log should record the
> stacktrace as well.
> {code:title=Dispatcher#dispatch}
> try {
> ...
> } catch (IOException e) {
> LOG.warn("Failed to move " + this + ": " + e.getMessage());
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
