[jira] [Commented] (HDFS-11718) DFSStripedOutputStream hsync/hflush should not throw UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HDFS-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991265#comment-15991265
]
Andrew Wang commented on HDFS-11718:
I think we're set, looks like Eddy committed this to trunk already. We haven't
branched for 3.0.0-alpha3 yet, so commits just need to land in trunk.
> DFSStripedOutputStream hsync/hflush should not throw
> UnsupportedOperationException
> --
>
> Key: HDFS-11718
> URL: https://issues.apache.org/jira/browse/HDFS-11718
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding
>Affects Versions: 3.0.0-alpha1
>Reporter: Manoj Govindassamy
>Assignee: Manoj Govindassamy
>Priority: Blocker
> Labels: hdfs-ec-3.0-must-do
> Fix For: 3.0.0-alpha3
>
> Attachments: HDFS-11644.01.patch, HDFS-11718.01.patch
>
>
> This is a clone bug of HDFS-11644 to provide a quick fix while a proper fix
> is being discussed and developed. The quick fix here would be to just turn
> {{DFSStripedOutputStream#hsync()/hflush()}} as a no-op instead of throwing
> UnsupportedOperationException.
> {code}
> @Override
> public void hflush() {
> throw new UnsupportedOperationException();
> }
> @Override
> public void hsync() {
> throw new UnsupportedOperationException();
> }
> {code}
> For more details please refer to the comments in HDFS-11644.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11718) DFSStripedOutputStream hsync/hflush should not throw UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HDFS-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989742#comment-15989742
]
Hudson commented on HDFS-11718:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11653 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/11653/])
HDFS-11718. DFSStripedOutputStream hsync/hflush should not throw (lei: rev
19a7e94ee47f81557f0db6fb76bdf6bc49944dd0)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStream.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedOutputStream.java
> DFSStripedOutputStream hsync/hflush should not throw
> UnsupportedOperationException
> --
>
> Key: HDFS-11718
> URL: https://issues.apache.org/jira/browse/HDFS-11718
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding
>Affects Versions: 3.0.0-alpha1
>Reporter: Manoj Govindassamy
>Assignee: Manoj Govindassamy
>Priority: Blocker
> Labels: hdfs-ec-3.0-must-do
> Fix For: 3.0.0-alpha3
>
> Attachments: HDFS-11644.01.patch, HDFS-11718.01.patch
>
>
> This is a clone bug of HDFS-11644 to provide a quick fix while a proper fix
> is being discussed and developed. The quick fix here would be to just turn
> {{DFSStripedOutputStream#hsync()/hflush()}} as a no-op instead of throwing
> UnsupportedOperationException.
> {code}
> @Override
> public void hflush() {
> throw new UnsupportedOperationException();
> }
> @Override
> public void hsync() {
> throw new UnsupportedOperationException();
> }
> {code}
> For more details please refer to the comments in HDFS-11644.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11718) DFSStripedOutputStream hsync/hflush should not throw UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HDFS-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989626#comment-15989626
]
Manoj Govindassamy commented on HDFS-11718:
---
[~andrew.wang], I believe this fix needs to be committed to trunk also. Please
confirm.
> DFSStripedOutputStream hsync/hflush should not throw
> UnsupportedOperationException
> --
>
> Key: HDFS-11718
> URL: https://issues.apache.org/jira/browse/HDFS-11718
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding
>Affects Versions: 3.0.0-alpha1
>Reporter: Manoj Govindassamy
>Assignee: Manoj Govindassamy
>Priority: Blocker
> Labels: hdfs-ec-3.0-must-do
> Fix For: 3.0.0-alpha3
>
> Attachments: HDFS-11644.01.patch, HDFS-11718.01.patch
>
>
> This is a clone bug of HDFS-11644 to provide a quick fix while a proper fix
> is being discussed and developed. The quick fix here would be to just turn
> {{DFSStripedOutputStream#hsync()/hflush()}} as a no-op instead of throwing
> UnsupportedOperationException.
> {code}
> @Override
> public void hflush() {
> throw new UnsupportedOperationException();
> }
> @Override
> public void hsync() {
> throw new UnsupportedOperationException();
> }
> {code}
> For more details please refer to the comments in HDFS-11644.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11718) DFSStripedOutputStream hsync/hflush should not throw UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HDFS-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989542#comment-15989542
]
Hadoop QA commented on HDFS-11718:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
50s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m
8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
29s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
23s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs-client in trunk has 2
extant Findbugs warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
38s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
23s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 86m 12s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}124m 41s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.server.namenode.TestMetadataVersionOutput |
| | hadoop.hdfs.server.namenode.TestStartup |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:0ac17dc |
| JIRA Issue | HDFS-11718 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12865622/HDFS-11718.01.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 968e0fc0aa4d 3.13.0-108-generic #155-Ubuntu SMP Wed Jan 11
16:58:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 2e52789 |
| Default Java | 1.8.0_121 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HDFS-Build/19237/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
|
| findbugs |
[jira] [Commented] (HDFS-11718) DFSStripedOutputStream hsync/hflush should not throw UnsupportedOperationException
[
https://issues.apache.org/jira/browse/HDFS-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989307#comment-15989307
]
Lei (Eddy) Xu commented on HDFS-11718:
--
Thanks for the patch, [~manojg]. It LGTM. +1 pending for jenkins and after
addressing small nits.
* Can we use {{try-resource}} for {{FSDataOutputStream}} used in the test.
* Please add comments to the test as a reference, since this JIRA is a hot fix.
Thanks!
> DFSStripedOutputStream hsync/hflush should not throw
> UnsupportedOperationException
> --
>
> Key: HDFS-11718
> URL: https://issues.apache.org/jira/browse/HDFS-11718
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding
>Affects Versions: 3.0.0-alpha1
>Reporter: Manoj Govindassamy
>Assignee: Manoj Govindassamy
>Priority: Blocker
> Labels: hdfs-ec-3.0-must-do
> Attachments: HDFS-11644.01.patch
>
>
> This is a clone bug of HDFS-11644 to provide a quick fix while a proper fix
> is being discussed and developed. The quick fix here would be to just turn
> {{DFSStripedOutputStream#hsync()/hflush()}} as a no-op instead of throwing
> UnsupportedOperationException.
> @Override
> public void hflush() {
> throw new UnsupportedOperationException();
> }
> @Override
> public void hsync() {
> throw new UnsupportedOperationException();
> }
> For more details please refer to the comments in HDFS-11644.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
