[jira] [Commented] (HDFS-11806) hdfs journalnode command should support meaningful --help

2018-01-05 Thread Doris Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312808#comment-16312808
 ] 

Doris Gu commented on HDFS-11806:
-

I ran junit tests at my local machine, they passed.

> hdfs journalnode command should support meaningful --help
> -
>
> Key: HDFS-11806
> URL: https://issues.apache.org/jira/browse/HDFS-11806
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Affects Versions: 2.8.0, 2.9.0, 3.0.0-alpha2, 3.1.0
>Reporter: Doris Gu
> Attachments: HDFS-11806.001.patch, HDFS-11806.002.patch
>
>
> Most (sub) commands support -help or -h options for detailed help while hdfs 
> journalnode does not. What's worse, when you use "hdfs journalnode -h" to get 
> some help, journalnode daemon starts straightly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-11806) hdfs journalnode command should support meaningful --help

2018-01-05 Thread genericqa (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312784#comment-16312784
 ] 

genericqa commented on HDFS-11806:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
12m 59s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
58s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 40s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch 
generated 2 new + 5 unchanged - 0 fixed = 7 total (was 5) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
12m 13s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}115m  1s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}173m 31s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration |
|   | hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120 |
|   | hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy |
|   | hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes |
|   | hadoop.hdfs.TestCrcCorruption |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure050 |
|   | hadoop.hdfs.server.balancer.TestBalancerRPCDelay |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure190 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
| JIRA Issue | HDFS-11806 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12904730/HDFS-11806.002.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux fac608a31f5d 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 
11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |

[jira] [Commented] (HDFS-11806) hdfs journalnode command should support meaningful --help

2018-01-05 Thread Doris Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312702#comment-16312702
 ] 

Doris Gu commented on HDFS-11806:
-

Notice journalnode does not  parse general options so far, make 
{{printGenericCommandUsage}} to {{false}} in patch 002, the modification is 
like this:
*Before*
{quote}[root@localhost ~]# hdfs journalnode -h
2018-01-05 08:03:32,384 INFO server.JournalNode: STARTUP_MSG: 
/
STARTUP_MSG: Starting JournalNode
STARTUP_MSG:   host = localhost/172.17.0.19
STARTUP_MSG:   args = [-h]
STARTUP_MSG:   version = 3.1.0-SNAPSHOT
...{quote}

*After*
{quote}[root@localhost ~]# hdfs journalnode -h
Usage: hdfs journalnode 
JournalNode is a necessary role in a typical HA cluster with QJM. It 
allows a NameNode to read and write edit logs stored on it's local disk. Note 
that you should run an odd number of JNs, (i.e. 3, 5, 7, etc.), since edit log 
modifications must be written to a majority of JNs.

[root@localhost ~]# {quote}

[~sureshms] [~bharatviswa], could you please review this issue for me? Thanks 
very much!
Tips: Due to [https://issues.apache.org/jira/browse/HADOOP-14818], need to test 
'-h' when there's no active journalnode daemon already, or you'll got 
{{journalnode is running as process ...}} error.

> hdfs journalnode command should support meaningful --help
> -
>
> Key: HDFS-11806
> URL: https://issues.apache.org/jira/browse/HDFS-11806
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Affects Versions: 2.8.0, 3.0.0-alpha2, 3.1.0
>Reporter: Doris Gu
> Attachments: HDFS-11806.001.patch, HDFS-11806.002.patch
>
>
> Most (sub) commands support -help or -h options for detailed help while hdfs 
> journalnode does not. What's worse, when you use "hdfs journalnode -h" to get 
> some help, journalnode daemon starts straightly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-11806) hdfs journalnode command should support meaningful --help

2018-01-04 Thread genericqa (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312575#comment-16312575
 ] 

genericqa commented on HDFS-11806:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  5s{color} 
| {color:red} HDFS-11806 does not apply to trunk. Rebase required? Wrong 
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-11806 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12867523/HDFS-11806.001.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/22572/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> hdfs journalnode command should support meaningful --help
> -
>
> Key: HDFS-11806
> URL: https://issues.apache.org/jira/browse/HDFS-11806
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Affects Versions: 2.8.0, 3.0.0-alpha2, 3.1.0
>Reporter: Doris Gu
> Attachments: HDFS-11806.001.patch
>
>
> Most (sub) commands support -help or -h options for detailed help while hdfs 
> journalnode does not. What's worse, when you use "hdfs journalnode -h" to get 
> some help, journalnode daemon starts straightly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-11806) hdfs journalnode command should support meaningful --help

2017-05-11 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006196#comment-16006196
 ] 

Hadoop QA commented on HDFS-11806:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m 
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
12s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
33s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant 
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
36s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 63m  0s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
19s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 87m  3s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.web.TestWebHdfsTimeouts |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-11806 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12867523/HDFS-11806.001.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux 2bbb3e42fea3 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / 51b671e |
| Default Java | 1.8.0_121 |
| findbugs | v3.1.0-RC1 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HDFS-Build/19398/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/19398/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/19398/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/19398/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> hdfs journalnode command

[jira] [Commented] (HDFS-11806) hdfs journalnode command should support meaningful --help

2017-05-11 Thread Doris Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006100#comment-16006100
 ] 

Doris Gu commented on HDFS-11806:
-

 Since "hdfs journalnode" only has general options, I add a brief statement 
about journalnode followed the style of secondary namenode.
{quote}[root@localhost ~]# hdfs journalnode -h
Usage: hdfs journalnode 
JournalNode is a necessary role in a typical HA cluster with QJM. It 
allows a NameNode to read and write edit logs stored on it's local disk. Note 
that you should run an odd number of JNs, (i.e. 3, 5, 7, etc.), since edit log 
modifications must be written to a majority of JNs.

Generic options supported are
-conf  specify an application configuration file
-D

[jira] [Commented] (HDFS-11806) hdfs journalnode command should support meaningful --help

2017-05-11 Thread Doris Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006086#comment-16006086
 ] 

Doris Gu commented on HDFS-11806:
-

{quote}hdfs@localhost:~/version/hadoop-3.0.0-alpha2/bin$ ./hdfs journalnode -h
2017-05-11 16:30:26,128 INFO server.JournalNode: STARTUP_MSG: 
/
STARTUP_MSG: Starting JournalNode
STARTUP_MSG:   user = hdfs
STARTUP_MSG:   host = localhost/127.0.0.1
STARTUP_MSG:   args = [-h]
STARTUP_MSG:   version = 3.0.0-alpha2{quote}

> hdfs journalnode command should support meaningful --help
> -
>
> Key: HDFS-11806
> URL: https://issues.apache.org/jira/browse/HDFS-11806
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Affects Versions: 3.0.0-alpha2
>Reporter: Doris Gu
>
> Most (sub) commands support -help or -h options for detailed help while hdfs 
> journalnode does not. What's worse, when you use "hdfs journalnode -h" to get 
> some help, journalnode daemon starts straightly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org