[jira] [Commented] (HDFS-1276) Add failed volume info to dfsadmin report

2012-09-28 Thread Bertrand Dechoux (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465603#comment-13465603
 ] 

Bertrand Dechoux commented on HDFS-1276:


One question about the need :
* Wouldn't it be possible to have the same as the HDFS web interface ie the 
list of namenode storage and their status? If I understand correctly, this 
patch will display (if any) failed volumes of datanode (and maybe namenode).

Second, about the patch :
* use  instead of new String[0]
* The comment or the code about parsing the error message is wrong
= the error message is : DataNode failed 
volumes:failed_volume;failed_volume...
= but the code split twice on ':', shouldn't it be first on ':' and then on 
';' ?
* Isn't that a very fragile way of reporting error? People might use (and so 
will use) the report output to do monitoring.

 Add failed volume info to dfsadmin report
 -

 Key: HDFS-1276
 URL: https://issues.apache.org/jira/browse/HDFS-1276
 Project: Hadoop HDFS
  Issue Type: Improvement
Affects Versions: 0.21.0
Reporter: Jeff Zhang
Assignee: Jeff Zhang
Priority: Minor
 Attachments: HDFS_1276.patch


 Currently, users do not know which volumes are failed unless he looks into 
 the logs, this way is not convenient for users. I plan to put the failed 
 volumes in the report of HDFS. Then hdfs administers can use command 
 bin/hadoop dfsadmin -report to find which volumes are failed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HDFS-1276) Add failed volume info to dfsadmin report

2012-09-28 Thread Bertrand Dechoux (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465609#comment-13465609
 ] 

Bertrand Dechoux commented on HDFS-1276:


Nevermind ( use  instead of new String[0] ), I am obviously tired.

 Add failed volume info to dfsadmin report
 -

 Key: HDFS-1276
 URL: https://issues.apache.org/jira/browse/HDFS-1276
 Project: Hadoop HDFS
  Issue Type: Improvement
Affects Versions: 0.21.0
Reporter: Jeff Zhang
Assignee: Jeff Zhang
Priority: Minor
 Attachments: HDFS_1276.patch


 Currently, users do not know which volumes are failed unless he looks into 
 the logs, this way is not convenient for users. I plan to put the failed 
 volumes in the report of HDFS. Then hdfs administers can use command 
 bin/hadoop dfsadmin -report to find which volumes are failed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira