[jira] [Commented] (HDFS-13133) Ozone: OzoneFileSystem: Calling delete with non-existing path shouldn't be logged on ERROR level
[
https://issues.apache.org/jira/browse/HDFS-13133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455387#comment-16455387
]
Hudson commented on HDFS-13133:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14070 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14070/])
HDFS-13133. Ozone: OzoneFileSystem: Calling delete with non-existing (omalley:
rev cd807c9890baf0778d782f8ed5f036b5f78b29d5)
* (edit)
hadoop-tools/hadoop-ozone/src/main/java/org/apache/hadoop/fs/ozone/OzoneFileSystem.java
> Ozone: OzoneFileSystem: Calling delete with non-existing path shouldn't be
> logged on ERROR level
>
>
> Key: HDFS-13133
> URL: https://issues.apache.org/jira/browse/HDFS-13133
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Major
> Fix For: HDFS-7240
>
> Attachments: HDFS-13133-HDFS-7240.001.patch
>
>
> During the test of OzoneFileSystem with spark I noticed ERROR messages
> multiple times:
> Something like this:
> {code}
> 2018-02-11 15:54:54 ERROR OzoneFileSystem:409 - Couldn't delete
> o3://bucket1.test/user/hadoop/.sparkStaging/application_1518349702045_0008 -
> does not exist
> {code}
> I checked the other implemetations, and they use DEBUG level. I think it's
> expected that the path sometimes points to a non-existing dir/file.
> To be consistent with the other implemetation I propose to lower the log
> level to debug.
> Examples from other file systems:
> S3AFileSystem:
> {code}
> } catch (FileNotFoundException e) {
> LOG.debug("Couldn't delete {} - does not exist", f);
> instrumentation.errorIgnored();
> return false;
> } catch (AmazonClientException e) {
> throw translateException("delete", f, e);
> }
> {code}
> Alyun:
> {code}
>try {
> return innerDelete(getFileStatus(path), recursive);
> } catch (FileNotFoundException e) {
> LOG.debug("Couldn't delete {} - does not exist", path);
> return false;
> }
> {code}
> SFTP:
> {code}
>} catch (FileNotFoundException e) {
> // file not found, no need to delete, return true
> return false;
> }
> {code}
> SwiftNativeFileSystem:
> {code}
> try {
> return store.delete(path, recursive);
> } catch (FileNotFoundException e) {
> //base path was not found.
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13133) Ozone: OzoneFileSystem: Calling delete with non-existing path shouldn't be logged on ERROR level
[
https://issues.apache.org/jira/browse/HDFS-13133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451171#comment-16451171
]
Hudson commented on HDFS-13133:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14057/])
HDFS-13133. Ozone: OzoneFileSystem: Calling delete with non-existing (msingh:
rev f3d07efac1a7007ed0493486a6aff26cbaa09b22)
* (edit)
hadoop-tools/hadoop-ozone/src/main/java/org/apache/hadoop/fs/ozone/OzoneFileSystem.java
> Ozone: OzoneFileSystem: Calling delete with non-existing path shouldn't be
> logged on ERROR level
>
>
> Key: HDFS-13133
> URL: https://issues.apache.org/jira/browse/HDFS-13133
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Major
> Fix For: HDFS-7240
>
> Attachments: HDFS-13133-HDFS-7240.001.patch
>
>
> During the test of OzoneFileSystem with spark I noticed ERROR messages
> multiple times:
> Something like this:
> {code}
> 2018-02-11 15:54:54 ERROR OzoneFileSystem:409 - Couldn't delete
> o3://bucket1.test/user/hadoop/.sparkStaging/application_1518349702045_0008 -
> does not exist
> {code}
> I checked the other implemetations, and they use DEBUG level. I think it's
> expected that the path sometimes points to a non-existing dir/file.
> To be consistent with the other implemetation I propose to lower the log
> level to debug.
> Examples from other file systems:
> S3AFileSystem:
> {code}
> } catch (FileNotFoundException e) {
> LOG.debug("Couldn't delete {} - does not exist", f);
> instrumentation.errorIgnored();
> return false;
> } catch (AmazonClientException e) {
> throw translateException("delete", f, e);
> }
> {code}
> Alyun:
> {code}
>try {
> return innerDelete(getFileStatus(path), recursive);
> } catch (FileNotFoundException e) {
> LOG.debug("Couldn't delete {} - does not exist", path);
> return false;
> }
> {code}
> SFTP:
> {code}
>} catch (FileNotFoundException e) {
> // file not found, no need to delete, return true
> return false;
> }
> {code}
> SwiftNativeFileSystem:
> {code}
> try {
> return store.delete(path, recursive);
> } catch (FileNotFoundException e) {
> //base path was not found.
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13133) Ozone: OzoneFileSystem: Calling delete with non-existing path shouldn't be logged on ERROR level
[
https://issues.apache.org/jira/browse/HDFS-13133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360382#comment-16360382
]
Mukul Kumar Singh commented on HDFS-13133:
--
Thanks for working on this [~elek].
+1, v1 patch looks good to me. I will commit this shortly.
> Ozone: OzoneFileSystem: Calling delete with non-existing path shouldn't be
> logged on ERROR level
>
>
> Key: HDFS-13133
> URL: https://issues.apache.org/jira/browse/HDFS-13133
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Major
> Fix For: HDFS-7240
>
> Attachments: HDFS-13133-HDFS-7240.001.patch
>
>
> During the test of OzoneFileSystem with spark I noticed ERROR messages
> multiple times:
> Something like this:
> {code}
> 2018-02-11 15:54:54 ERROR OzoneFileSystem:409 - Couldn't delete
> o3://bucket1.test/user/hadoop/.sparkStaging/application_1518349702045_0008 -
> does not exist
> {code}
> I checked the other implemetations, and they use DEBUG level. I think it's
> expected that the path sometimes points to a non-existing dir/file.
> To be consistent with the other implemetation I propose to lower the log
> level to debug.
> Examples from other file systems:
> S3AFileSystem:
> {code}
> } catch (FileNotFoundException e) {
> LOG.debug("Couldn't delete {} - does not exist", f);
> instrumentation.errorIgnored();
> return false;
> } catch (AmazonClientException e) {
> throw translateException("delete", f, e);
> }
> {code}
> Alyun:
> {code}
>try {
> return innerDelete(getFileStatus(path), recursive);
> } catch (FileNotFoundException e) {
> LOG.debug("Couldn't delete {} - does not exist", path);
> return false;
> }
> {code}
> SFTP:
> {code}
>} catch (FileNotFoundException e) {
> // file not found, no need to delete, return true
> return false;
> }
> {code}
> SwiftNativeFileSystem:
> {code}
> try {
> return store.delete(path, recursive);
> } catch (FileNotFoundException e) {
> //base path was not found.
> return false;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13133) Ozone: OzoneFileSystem: Calling delete with non-existing path shouldn't be logged on ERROR level
[
https://issues.apache.org/jira/browse/HDFS-13133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360022#comment-16360022
]
genericqa commented on HDFS-13133:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m
22s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
20s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 19s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
26s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} HDFS-7240 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 10s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
36s{color} | {color:green} hadoop-ozone in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 45m 16s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d11161b |
| JIRA Issue | HDFS-13133 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12910120/HDFS-13133-HDFS-7240.001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 84eeae27f171 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20
11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDFS-7240 / eb5e66a |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/23028/testReport/ |
| Max. process+thread count | 432 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-ozone U: hadoop-tools/hadoop-ozone |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/23028/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: OzoneFileSystem:
