[jira] [Commented] (HDFS-13210) Fix the typo in MiniDFSCluster class
[ https://issues.apache.org/jira/browse/HDFS-13210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381859#comment-16381859 ] fang zhenyi commented on HDFS-13210: Thanks [~linyiqun] for report this.I have attached HDFS-13210.001.patch.Hope you can review, thanks a lot. > Fix the typo in MiniDFSCluster class > - > > Key: HDFS-13210 > URL: https://issues.apache.org/jira/browse/HDFS-13210 > Project: Hadoop HDFS > Issue Type: Bug > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: fang zhenyi >Priority: Trivial > Attachments: HDFS-13210.001.patch > > > There is a typo {{SimilatedFSDataset}} in {{MiniDFSCluster#injectBlocks}}. > In line2748 and line2769: > {code:java} > public void injectBlocks(int dataNodeIndex, > Iterable blocksToInject, String bpid) throws IOException { > if (dataNodeIndex < 0 || dataNodeIndex > dataNodes.size()) { > throw new IndexOutOfBoundsException(); > } > final DataNode dn = dataNodes.get(dataNodeIndex).datanode; > final FsDatasetSpi dataSet = DataNodeTestUtils.getFSDataset(dn); > if (!(dataSet instanceof SimulatedFSDataset)) { > throw new IOException("injectBlocks is valid only for > SimilatedFSDataset"); > } > ... > } > {code} > {{SimilatedFSDataset}} should be {{SimulatedFSDataset}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13210) Fix the typo in MiniDFSCluster class
[ https://issues.apache.org/jira/browse/HDFS-13210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381876#comment-16381876 ] Yiqun Lin commented on HDFS-13210: -- [~zhenyi], there are two places (line2748 or line2769) needed to fix, would you fix another place as well? > Fix the typo in MiniDFSCluster class > - > > Key: HDFS-13210 > URL: https://issues.apache.org/jira/browse/HDFS-13210 > Project: Hadoop HDFS > Issue Type: Bug > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: fang zhenyi >Priority: Trivial > Attachments: HDFS-13210.001.patch > > > There is a typo {{SimilatedFSDataset}} in {{MiniDFSCluster#injectBlocks}}. > In line2748 and line2769: > {code:java} > public void injectBlocks(int dataNodeIndex, > Iterable blocksToInject, String bpid) throws IOException { > if (dataNodeIndex < 0 || dataNodeIndex > dataNodes.size()) { > throw new IndexOutOfBoundsException(); > } > final DataNode dn = dataNodes.get(dataNodeIndex).datanode; > final FsDatasetSpi dataSet = DataNodeTestUtils.getFSDataset(dn); > if (!(dataSet instanceof SimulatedFSDataset)) { > throw new IOException("injectBlocks is valid only for > SimilatedFSDataset"); > } > ... > } > {code} > {{SimilatedFSDataset}} should be {{SimulatedFSDataset}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13210) Fix the typo in MiniDFSCluster class
[ https://issues.apache.org/jira/browse/HDFS-13210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381890#comment-16381890 ] fang zhenyi commented on HDFS-13210: Thans [~linyiqun] for reminding.I have attached HDFS-13210.002.patch.Hope you can review again, thanks a lot. > Fix the typo in MiniDFSCluster class > - > > Key: HDFS-13210 > URL: https://issues.apache.org/jira/browse/HDFS-13210 > Project: Hadoop HDFS > Issue Type: Bug > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: fang zhenyi >Priority: Trivial > Attachments: HDFS-13210.001.patch, HDFS-13210.002.patch > > > There is a typo {{SimilatedFSDataset}} in {{MiniDFSCluster#injectBlocks}}. > In line2748 and line2769: > {code:java} > public void injectBlocks(int dataNodeIndex, > Iterable blocksToInject, String bpid) throws IOException { > if (dataNodeIndex < 0 || dataNodeIndex > dataNodes.size()) { > throw new IndexOutOfBoundsException(); > } > final DataNode dn = dataNodes.get(dataNodeIndex).datanode; > final FsDatasetSpi dataSet = DataNodeTestUtils.getFSDataset(dn); > if (!(dataSet instanceof SimulatedFSDataset)) { > throw new IOException("injectBlocks is valid only for > SimilatedFSDataset"); > } > ... > } > {code} > {{SimilatedFSDataset}} should be {{SimulatedFSDataset}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13210) Fix the typo in MiniDFSCluster class
[ https://issues.apache.org/jira/browse/HDFS-13210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382100#comment-16382100 ] genericqa commented on HDFS-13210: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 27s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 46s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 56s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 42s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 46s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 31s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 202 unchanged - 1 fixed = 203 total (was 203) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 9m 36s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 50s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}147m 50s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}195m 11s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.web.TestWebHdfsTimeouts | | | hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations | | | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure | | | hadoop.hdfs.server.namenode.ha.TestBootstrapStandby | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 | | JIRA Issue | HDFS-13210 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12912588/HDFS-13210.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux f581ab974542 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 55d04a6 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_151 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/23252/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23252/artifact/out/patch-unit-hadoop-hdfs-
[jira] [Commented] (HDFS-13210) Fix the typo in MiniDFSCluster class
[ https://issues.apache.org/jira/browse/HDFS-13210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382136#comment-16382136 ] genericqa commented on HDFS-13210: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 29s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 16s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 34s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 53s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 9m 58s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 55s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 36s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 201 unchanged - 2 fixed = 203 total (was 203) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 9m 43s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}154m 51s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}201m 52s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA | | | hadoop.hdfs.web.TestWebHdfsTimeouts | | | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure | | | hadoop.hdfs.TestReadStripedFileWithMissingBlocks | | | hadoop.hdfs.TestBlocksScheduledCounter | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 | | JIRA Issue | HDFS-13210 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12912591/HDFS-13210.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 589667a1eab5 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 55d04a6 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_151 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/23253/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23253/ar
[jira] [Commented] (HDFS-13210) Fix the typo in MiniDFSCluster class
[ https://issues.apache.org/jira/browse/HDFS-13210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382941#comment-16382941 ] fang zhenyi commented on HDFS-13210: Fix checkstyle in HDFS-13210.003.patch. > Fix the typo in MiniDFSCluster class > - > > Key: HDFS-13210 > URL: https://issues.apache.org/jira/browse/HDFS-13210 > Project: Hadoop HDFS > Issue Type: Bug > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: fang zhenyi >Priority: Trivial > Attachments: HDFS-13210.001.patch, HDFS-13210.002.patch, > HDFS-13210.003.patch > > > There is a typo {{SimilatedFSDataset}} in {{MiniDFSCluster#injectBlocks}}. > In line2748 and line2769: > {code:java} > public void injectBlocks(int dataNodeIndex, > Iterable blocksToInject, String bpid) throws IOException { > if (dataNodeIndex < 0 || dataNodeIndex > dataNodes.size()) { > throw new IndexOutOfBoundsException(); > } > final DataNode dn = dataNodes.get(dataNodeIndex).datanode; > final FsDatasetSpi dataSet = DataNodeTestUtils.getFSDataset(dn); > if (!(dataSet instanceof SimulatedFSDataset)) { > throw new IOException("injectBlocks is valid only for > SimilatedFSDataset"); > } > ... > } > {code} > {{SimilatedFSDataset}} should be {{SimulatedFSDataset}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13210) Fix the typo in MiniDFSCluster class
[ https://issues.apache.org/jira/browse/HDFS-13210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383120#comment-16383120 ] genericqa commented on HDFS-13210: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 35s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m 2s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 1s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 34s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 55s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 201 unchanged - 2 fixed = 201 total (was 203) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 5s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}111m 41s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}163m 47s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration | | | hadoop.hdfs.TestReconstructStripedFile | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d4cc50f | | JIRA Issue | HDFS-13210 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12912702/HDFS-13210.003.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 6a976a22fdf8 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 923e177 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_151 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/23257/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/23257/testReport/ | | Max. process+thread count | 3112 (vs. ulimit of 1) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-
[jira] [Commented] (HDFS-13210) Fix the typo in MiniDFSCluster class
[ https://issues.apache.org/jira/browse/HDFS-13210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383125#comment-16383125 ] Yiqun Lin commented on HDFS-13210: -- +1. > Fix the typo in MiniDFSCluster class > - > > Key: HDFS-13210 > URL: https://issues.apache.org/jira/browse/HDFS-13210 > Project: Hadoop HDFS > Issue Type: Bug > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: fang zhenyi >Priority: Trivial > Attachments: HDFS-13210.001.patch, HDFS-13210.002.patch, > HDFS-13210.003.patch > > > There is a typo {{SimilatedFSDataset}} in {{MiniDFSCluster#injectBlocks}}. > In line2748 and line2769: > {code:java} > public void injectBlocks(int dataNodeIndex, > Iterable blocksToInject, String bpid) throws IOException { > if (dataNodeIndex < 0 || dataNodeIndex > dataNodes.size()) { > throw new IndexOutOfBoundsException(); > } > final DataNode dn = dataNodes.get(dataNodeIndex).datanode; > final FsDatasetSpi dataSet = DataNodeTestUtils.getFSDataset(dn); > if (!(dataSet instanceof SimulatedFSDataset)) { > throw new IOException("injectBlocks is valid only for > SimilatedFSDataset"); > } > ... > } > {code} > {{SimilatedFSDataset}} should be {{SimulatedFSDataset}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13210) Fix the typo in MiniDFSCluster class
[ https://issues.apache.org/jira/browse/HDFS-13210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383126#comment-16383126 ] Hudson commented on HDFS-13210: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #13756 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13756/]) HDFS-13210. Fix the typo in MiniDFSCluster class. Contributed by fang (yqlin: rev 55669515f626eb5b1f3ba25095f3e306c243d899) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java > Fix the typo in MiniDFSCluster class > - > > Key: HDFS-13210 > URL: https://issues.apache.org/jira/browse/HDFS-13210 > Project: Hadoop HDFS > Issue Type: Bug > Components: test >Affects Versions: 3.0.0 >Reporter: Yiqun Lin >Assignee: fang zhenyi >Priority: Trivial > Fix For: 3.2.0 > > Attachments: HDFS-13210.001.patch, HDFS-13210.002.patch, > HDFS-13210.003.patch > > > There is a typo {{SimilatedFSDataset}} in {{MiniDFSCluster#injectBlocks}}. > In line2748 and line2769: > {code:java} > public void injectBlocks(int dataNodeIndex, > Iterable blocksToInject, String bpid) throws IOException { > if (dataNodeIndex < 0 || dataNodeIndex > dataNodes.size()) { > throw new IndexOutOfBoundsException(); > } > final DataNode dn = dataNodes.get(dataNodeIndex).datanode; > final FsDatasetSpi dataSet = DataNodeTestUtils.getFSDataset(dn); > if (!(dataSet instanceof SimulatedFSDataset)) { > throw new IOException("injectBlocks is valid only for > SimilatedFSDataset"); > } > ... > } > {code} > {{SimilatedFSDataset}} should be {{SimulatedFSDataset}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org