[jira] [Commented] (HDFS-13415) Ozone: Remove cblock code from HDFS-7240 (move to a different branch)
[
https://issues.apache.org/jira/browse/HDFS-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433852#comment-16433852
]
Mukul Kumar Singh commented on HDFS-13415:
--
Thanks for working on this [~elek],
+1, the patch looks good to me. I will commit this shortly.
Ozone acceptance pass after removing cblock related components.
{code}
==
Acceptance
==
Acceptance.Ozone :: Smoke test to start cluster with docker-compose environ...
==
Daemons are running without error | PASS |
--
Check if datanode is connected to the scm | PASS |
--
Scale it up to 5 datanodes| PASS |
--
Test rest interface | PASS |
--
Test ozone cli| PASS |
--
Check webui static resources | PASS |
--
Start freon testing | PASS |
--
Acceptance.Ozone :: Smoke test to start cluster with docker-compos... | PASS |
7 critical tests, 7 passed, 0 failed
7 tests total, 7 passed, 0 failed
==
Acceptance| PASS |
7 critical tests, 7 passed, 0 failed
7 tests total, 7 passed, 0 failed
{code}
> Ozone: Remove cblock code from HDFS-7240 (move to a different branch)
> -
>
> Key: HDFS-13415
> URL: https://issues.apache.org/jira/browse/HDFS-13415
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Minor
> Attachments: HDFS-13415-HDFS-7240.001.patch,
> HDFS-13415-HDFS-7240.002.patch, HDFS-13415-HDFS-7240.003.patch
>
>
> The Ozone components (hdds/ozone) and cblock components (cblock) has
> different stability. We suggest to separated the development: Ozone could
> remain on HDFS-7240 and could be merged to the trunk as voted by the
> community.
> The cblock development could be kept on a separated feature branch
> (HDFS-8) and could be developed and merged independently.
> To achieve this we
> 1. need to remove the cblock code from HDFS-7240 branch (this is what this
> jira about)
> 2. Create a new branch from the latest HDFS-7240 which contains the cblock
> server (not in this jira)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13415) Ozone: Remove cblock code from HDFS-7240 (move to a different branch)
[ https://issues.apache.org/jira/browse/HDFS-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433685#comment-16433685 ] Elek, Marton commented on HDFS-13415: - conflicted as docker-compose files are changed on HDFS-7240. Rebased to the latest HDFS-7240. > Ozone: Remove cblock code from HDFS-7240 (move to a different branch) > - > > Key: HDFS-13415 > URL: https://issues.apache.org/jira/browse/HDFS-13415 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Reporter: Elek, Marton >Assignee: Elek, Marton >Priority: Minor > Attachments: HDFS-13415-HDFS-7240.001.patch, > HDFS-13415-HDFS-7240.002.patch, HDFS-13415-HDFS-7240.003.patch > > > The Ozone components (hdds/ozone) and cblock components (cblock) has > different stability. We suggest to separated the development: Ozone could > remain on HDFS-7240 and could be merged to the trunk as voted by the > community. > The cblock development could be kept on a separated feature branch > (HDFS-8) and could be developed and merged independently. > To achieve this we > 1. need to remove the cblock code from HDFS-7240 branch (this is what this > jira about) > 2. Create a new branch from the latest HDFS-7240 which contains the cblock > server (not in this jira) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13415) Ozone: Remove cblock code from HDFS-7240 (move to a different branch)
[
https://issues.apache.org/jira/browse/HDFS-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432955#comment-16432955
]
genericqa commented on HDFS-13415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HDFS-13415 does not apply to HDFS-7240. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-13415 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12918456/HDFS-13415-HDFS-7240.002.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/23866/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Ozone: Remove cblock code from HDFS-7240 (move to a different branch)
> -
>
> Key: HDFS-13415
> URL: https://issues.apache.org/jira/browse/HDFS-13415
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Minor
> Attachments: HDFS-13415-HDFS-7240.001.patch,
> HDFS-13415-HDFS-7240.002.patch
>
>
> The Ozone components (hdds/ozone) and cblock components (cblock) has
> different stability. We suggest to separated the development: Ozone could
> remain on HDFS-7240 and could be merged to the trunk as voted by the
> community.
> The cblock development could be kept on a separated feature branch
> (HDFS-8) and could be developed and merged independently.
> To achieve this we
> 1. need to remove the cblock code from HDFS-7240 branch (this is what this
> jira about)
> 2. Create a new branch from the latest HDFS-7240 which contains the cblock
> server (not in this jira)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13415) Ozone: Remove cblock code from HDFS-7240 (move to a different branch)
[ https://issues.apache.org/jira/browse/HDFS-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432940#comment-16432940 ] Elek, Marton commented on HDFS-13415: - Thank you [~msingh] to check the patch. It's hard to grep for cblock as this expression is used at many places in the existing hdfs code (...cBlock). I addressed all the issues in the latest patch (you can see the diff between the two patches here: https://github.com/elek/hadoop/commit/d77b2a6df77972275077c3f4650bdaf206b053df) The only exception is the TestConfiguration.java (item 3). Here the cblock is just a custom example string to test the configuration. The code itself isn't related to the cblock. I would keep it as is, because it would introduce additional differences betweeen trunk and HDFS-7240 which could make the merge review harder. > Ozone: Remove cblock code from HDFS-7240 (move to a different branch) > - > > Key: HDFS-13415 > URL: https://issues.apache.org/jira/browse/HDFS-13415 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Reporter: Elek, Marton >Assignee: Elek, Marton >Priority: Minor > Attachments: HDFS-13415-HDFS-7240.001.patch, > HDFS-13415-HDFS-7240.002.patch > > > The Ozone components (hdds/ozone) and cblock components (cblock) has > different stability. We suggest to separated the development: Ozone could > remain on HDFS-7240 and could be merged to the trunk as voted by the > community. > The cblock development could be kept on a separated feature branch > (HDFS-8) and could be developed and merged independently. > To achieve this we > 1. need to remove the cblock code from HDFS-7240 branch (this is what this > jira about) > 2. Create a new branch from the latest HDFS-7240 which contains the cblock > server (not in this jira) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13415) Ozone: Remove cblock code from HDFS-7240 (move to a different branch)
[ https://issues.apache.org/jira/browse/HDFS-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432321#comment-16432321 ] Mukul Kumar Singh commented on HDFS-13415: -- Thanks for working on this, the patch looks really good to me. There are some references remaining in the branch. 1) hadoop-function.sh:603,604 remove cblock references for classpath 2) There is minor indentation error in base pom.xml:723 3) TestConfiguration.java: 2352, 2379. There are references to cblock configs in the test file. 4) hadoop-env.sh: 407-424, lets remove the OPTS as well ? 5) bin/ozone, need to remove references to Cblock commands. 6) hadoop-src.xml:55. Lets remove the reference to cblock here > Ozone: Remove cblock code from HDFS-7240 (move to a different branch) > - > > Key: HDFS-13415 > URL: https://issues.apache.org/jira/browse/HDFS-13415 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Reporter: Elek, Marton >Assignee: Elek, Marton >Priority: Minor > Attachments: HDFS-13415-HDFS-7240.001.patch > > > The Ozone components (hdds/ozone) and cblock components (cblock) has > different stability. We suggest to separated the development: Ozone could > remain on HDFS-7240 and could be merged to the trunk as voted by the > community. > The cblock development could be kept on a separated feature branch > (HDFS-8) and could be developed and merged independently. > To achieve this we > 1. need to remove the cblock code from HDFS-7240 branch (this is what this > jira about) > 2. Create a new branch from the latest HDFS-7240 which contains the cblock > server (not in this jira) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13415) Ozone: Remove cblock code from HDFS-7240 (move to a different branch)
[
https://issues.apache.org/jira/browse/HDFS-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431155#comment-16431155
]
genericqa commented on HDFS-13415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 12 new or modified test
files. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m
2s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 29m
53s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
16s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 20m
15s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 30s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-project hadoop-dist . hadoop-cblock {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
23s{color} | {color:red} server in HDFS-7240 failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
27s{color} | {color:red} tools in HDFS-7240 failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
31s{color} | {color:green} HDFS-7240 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 27m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 27m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 27m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 20m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
12s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 1 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 42s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-project hadoop-dist . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 16s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
43s{color} | {color:red} The patch generated 7 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} |
