[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906240#comment-16906240 ] Hudson commented on HDFS-13505: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17101 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/17101/]) HDFS-13505. Turn on HDFS ACLs by default. Contributed by Siyao Meng. (ayushsaxena: rev e9b6b81de44ff5fb9f833cfc32c69b644eb46bad) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAclConfigFlag.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml * (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsPermissionsGuide.md > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Siyao Meng >Priority: Major > Fix For: 3.3.0 > > Attachments: HDFS-13505.00.patch, HDFS-13505.001.patch, > HDFS-13505.002.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906234#comment-16906234 ] Ayush Saxena commented on HDFS-13505: - Committed to trunk. Thanx [~smeng] [~ajayydv] [~dineshchitlangia] and [~jojochuang] for the work here!!! > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Siyao Meng >Priority: Major > Attachments: HDFS-13505.00.patch, HDFS-13505.001.patch, > HDFS-13505.002.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906223#comment-16906223 ] Ayush Saxena commented on HDFS-13505: - v002 LGTM +1 > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Siyao Meng >Priority: Major > Attachments: HDFS-13505.00.patch, HDFS-13505.001.patch, > HDFS-13505.002.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[
https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905885#comment-16905885
]
Hadoop QA commented on HDFS-13505:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
6s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 57s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 26s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}108m 24s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}163m 58s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.server.namenode.TestNameNodeMXBean |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 Image:yetus/hadoop:bdbca0e |
| JIRA Issue | HDFS-13505 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977438/HDFS-13505.002.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle xml |
| uname | Linux 7842455b039f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 454420e |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_222 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/27491/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/27491/testReport/ |
| Max. process+thread count | 3975 (vs. ulimit of 1) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904561#comment-16904561 ] Wei-Chiu Chuang commented on HDFS-13505: Yes we should update the HDFS Permission Guide. Thanks for catching that [~ayushtkn]! > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Siyao Meng >Priority: Major > Attachments: HDFS-13505.00.patch, HDFS-13505.001.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904543#comment-16904543 ] Dinesh Chitlangia commented on HDFS-13505: -- [~smeng]- Release notes LGTM. Thank you for your kind consideration! > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Siyao Meng >Priority: Major > Attachments: HDFS-13505.00.patch, HDFS-13505.001.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[
https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904510#comment-16904510
]
Ayush Saxena commented on HDFS-13505:
-
Thanx [~smeng] for the patch. Guess you missed updating in
{{HDFSPermissionsGuide}} as I mentioned above.
> Turn on HDFS ACLs by default.
> -
>
> Key: HDFS-13505
> URL: https://issues.apache.org/jira/browse/HDFS-13505
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Ajay Kumar
>Assignee: Siyao Meng
>Priority: Major
> Attachments: HDFS-13505.00.patch, HDFS-13505.001.patch
>
>
> Turn on HDFS ACLs by default.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904445#comment-16904445 ] Siyao Meng commented on HDFS-13505: --- [~dineshchitlangia] I've added release notes to this jira. Please review. Thanks! > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Siyao Meng >Priority: Major > Attachments: HDFS-13505.00.patch, HDFS-13505.001.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[
https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898384#comment-16898384
]
Dinesh Chitlangia commented on HDFS-13505:
--
[~jojochuang] In Hadoop-2.x, the ACL is disabled by default. So most users who
do not want to enable ACL, don't define the
{{dfs.namenode.acls.enabled=false}} explicitly in their configs.
So, if users would still like to keep ACL disabled after upgrading to
Hadoop-3.x, then they must explicitly define
{{dfs.namenode.acls.enabled=false}} in their configs to avoid it being turned
on by the upgrade.
I think documenting this correctly is critical. Thanks!
> Turn on HDFS ACLs by default.
> -
>
> Key: HDFS-13505
> URL: https://issues.apache.org/jira/browse/HDFS-13505
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Ajay Kumar
>Assignee: Siyao Meng
>Priority: Major
> Attachments: HDFS-13505.00.patch, HDFS-13505.001.patch
>
>
> Turn on HDFS ACLs by default.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898362#comment-16898362 ] Wei-Chiu Chuang commented on HDFS-13505: Dinesh, this change will not affect those users disables HDFS ACL explicitly. The concern would be if enabling HDFS ACL gives different behavior than disabling it. Inspecting the code, I don't feel this is a big issue, as long as we document this change properly. > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Siyao Meng >Priority: Major > Attachments: HDFS-13505.00.patch, HDFS-13505.001.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897715#comment-16897715 ] Dinesh Chitlangia commented on HDFS-13505: -- For customers who have disabled HDFS ACLs intentionally will not be happy with this being turned on by upgrades. Also, people with large FSImages have to go through additional pain of reverting back to old value after upgrade and then restart HDFS again. This adds to the post upgrade hassles. > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Siyao Meng >Priority: Major > Attachments: HDFS-13505.00.patch, HDFS-13505.001.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[
https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897700#comment-16897700
]
Hadoop QA commented on HDFS-13505:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
39s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 9s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 3s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 83m 16s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}139m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes |
| | hadoop.hdfs.qjournal.server.TestJournalNodeSync |
| | hadoop.hdfs.server.datanode.TestLargeBlockReport |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 Image:yetus/hadoop:bdbca0e |
| JIRA Issue | HDFS-13505 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976374/HDFS-13505.001.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle xml |
| uname | Linux 89f04e09091c 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / b008072 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_212 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/27364/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/27364/testReport/ |
| Max.
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[
https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856593#comment-16856593
]
Ayush Saxena commented on HDFS-13505:
-
Thanx [~ajayydv] for the patch.
* {{TestAclConfigFlag}} is related.
* You need to update in {{HDFSPermissionsGuide}} here
{code:java}
`dfs.namenode.acls.enabled = true`
Set to true to enable support for HDFS ACLs (Access Control Lists).* By
default, ACLs are disabled.* When ACLs are disabled, the NameNode rejects
all attempts to set an ACL.
{code}
* Even the same description change in {{hdfs-defaults.xml}}
{code:java}
Set to true to enable support for HDFS ACLs (Access Control Lists). * By
default, ACLs are disabled. When ACLs are disabled*, the NameNode rejects
all RPCs related to setting or getting ACLs.
{code}
> Turn on HDFS ACLs by default.
> -
>
> Key: HDFS-13505
> URL: https://issues.apache.org/jira/browse/HDFS-13505
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Ajay Kumar
>Assignee: Ajay Kumar
>Priority: Major
> Attachments: HDFS-13505.00.patch
>
>
> Turn on HDFS ACLs by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[
https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856231#comment-16856231
]
Hadoop QA commented on HDFS-13505:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 5s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 54s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 78m 33s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}134m 1s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.server.namenode.TestAclConfigFlag |
| | hadoop.hdfs.web.TestWebHdfsTimeouts |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:bdbca0e |
| JIRA Issue | HDFS-13505 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12920702/HDFS-13505.00.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle xml |
| uname | Linux 568d0efe2e72 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / d45669c |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_212 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/26898/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/Pr
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854777#comment-16854777 ] Wei-Chiu Chuang commented on HDFS-13505: +1 I came realize that this is enabled by default for Ambari-installed clusters, and it looks like there's no report of backward incompatibility. I will commit this into trunk. Due to the compatibility requirement (_The default property values will not be changed during a maintenance releas._) this change shouldn't be cherrypicked into lower branches. > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Ajay Kumar >Priority: Major > Attachments: HDFS-13505.00.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[
https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457242#comment-16457242
]
Wei-Chiu Chuang commented on HDFS-13505:
Thank you for the answer.
{quote}ACLs is basic functionality required by most of the use cases and
clients.
{quote}
There's probably some misunderstanding here. But at least from the numbers I
have at hand, this is untrue.
Also, at least from the source code perspective, HBase doesn't seem to rely on
Hadoop ACLs.
That aside, I still want to know: is it a backward compatible change?
> Turn on HDFS ACLs by default.
> -
>
> Key: HDFS-13505
> URL: https://issues.apache.org/jira/browse/HDFS-13505
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Ajay Kumar
>Assignee: Ajay Kumar
>Priority: Major
> Attachments: HDFS-13505.00.patch
>
>
> Turn on HDFS ACLs by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457198#comment-16457198 ] Ajay Kumar commented on HDFS-13505: --- [~jojochuang] ACLs is basic functionality required by most of the use cases and clients. Currently turning it on involves additional step of reconfiguring cluster and restarting service. We can avoid this by enabling it by default. This feature is in use for quite some time now and it is safe to make it default. > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Ajay Kumar >Priority: Major > Attachments: HDFS-13505.00.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455600#comment-16455600 ] Wei-Chiu Chuang commented on HDFS-13505: Hi [~ajayydv] could you please elaborate the reason for this change? This affects the following set of operations: setAcl() removeAcl() getAclStatus() removeDefaultAcl() removeAclEntries() modifyAclEntries() getAclStatus(), for example, is used in distcp within Hadoop codebase. There could be impact to other downstream applications as well. Not against the change, but I'd love to see why you think it is a good idea to enable it by default. Thank you. > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Ajay Kumar >Priority: Major > Attachments: HDFS-13505.00.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455486#comment-16455486 ] Ajay Kumar commented on HDFS-13505: --- [~jojochuang] Thanks for checking this. Could you please elaborate why you think its incompatible change? IMO this will not have any impact unless someone sets ACL's explicitly. May be i am missing something. > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Ajay Kumar >Priority: Major > Attachments: HDFS-13505.00.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13505) Turn on HDFS ACLs by default.
[ https://issues.apache.org/jira/browse/HDFS-13505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453294#comment-16453294 ] Wei-Chiu Chuang commented on HDFS-13505: Isn't this an incompatible change? > Turn on HDFS ACLs by default. > - > > Key: HDFS-13505 > URL: https://issues.apache.org/jira/browse/HDFS-13505 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Ajay Kumar >Assignee: Ajay Kumar >Priority: Major > Attachments: HDFS-13505.00.patch > > > Turn on HDFS ACLs by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
