[jira] [Commented] (HDFS-14367) EC: Parameter maxPoolSize in striped reconstruct thread pool isn't affecting number of threads

2020-05-12 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-14367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105433#comment-17105433
 ] 

Hudson commented on HDFS-14367:
---

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18236 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/18236/])
HDFS-14367. EC: Parameter maxPoolSize in striped reconstruct thread pool 
(ayushsaxena: rev 8dad38c0bed4522b3f90e945f40920d8d9e731c6)
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java


> EC: Parameter maxPoolSize in striped reconstruct thread pool isn't affecting 
> number of threads
> --
>
> Key: HDFS-14367
> URL: https://issues.apache.org/jira/browse/HDFS-14367
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ec
>Affects Versions: 3.3.0
>Reporter: Guo Lei
>Assignee: Guo Lei
>Priority: Major
> Fix For: 3.2.2, 3.3.1, 3.4.0, 3.1.5
>
> Attachments: HDFS-14367.001.patch
>
>
> The workQueue length wasn't specified, so the thread number never be increase.
> The thread number increase to maximumPoolSize only when the workQueue is full.
> file location: 
> org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java
> private void initializeStripedBlkReconstructionThreadPool(int numThreads) {
>    LOG.debug("Using striped block reconstruction; pool threads={}",
>        numThreads);
>    stripedReconstructionPool = DFSUtilClient.getThreadPoolExecutor(2,
>        {color:#ff}numThreads{color}, 60, {color:#ff}new 
> LinkedBlockingQueue<>(){color},
>        "StripedBlockReconstruction-", false);
>    stripedReconstructionPool.allowCoreThreadTimeOut(true);
>  }



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-14367) EC: Parameter maxPoolSize in striped reconstruct thread pool isn't affecting number of threads

2020-05-12 Thread Ayush Saxena (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-14367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105422#comment-17105422
 ] 

Ayush Saxena commented on HDFS-14367:
-

Committed to trunk, branch-3.3, 3.2 and 3.1
Thanx [~glove747] for the contribution!!!

> EC: Parameter maxPoolSize in striped reconstruct thread pool isn't affecting 
> number of threads
> --
>
> Key: HDFS-14367
> URL: https://issues.apache.org/jira/browse/HDFS-14367
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ec
>Affects Versions: 3.3.0
>Reporter: Guo Lei
>Assignee: Guo Lei
>Priority: Major
> Attachments: HDFS-14367.001.patch
>
>
> The workQueue length wasn't specified, so the thread number never be increase.
> The thread number increase to maximumPoolSize only when the workQueue is full.
> file location: 
> org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java
> private void initializeStripedBlkReconstructionThreadPool(int numThreads) {
>    LOG.debug("Using striped block reconstruction; pool threads={}",
>        numThreads);
>    stripedReconstructionPool = DFSUtilClient.getThreadPoolExecutor(2,
>        {color:#ff}numThreads{color}, 60, {color:#ff}new 
> LinkedBlockingQueue<>(){color},
>        "StripedBlockReconstruction-", false);
>    stripedReconstructionPool.allowCoreThreadTimeOut(true);
>  }



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-14367) EC: Parameter maxPoolSize in striped reconstruct thread pool isn't affecting number of threads

2020-05-12 Thread Ayush Saxena (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-14367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105417#comment-17105417
 ] 

Ayush Saxena commented on HDFS-14367:
-

Thanx [~glove747] for the patch.
v001 LGTM +1
Test failures aren't related

> EC: Parameter maxPoolSize in striped reconstruct thread pool isn't affecting 
> number of threads
> --
>
> Key: HDFS-14367
> URL: https://issues.apache.org/jira/browse/HDFS-14367
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ec
>Affects Versions: 3.3.0
>Reporter: Guo Lei
>Assignee: Guo Lei
>Priority: Major
> Attachments: HDFS-14367.001.patch
>
>
> The workQueue length wasn't specified, so the thread number never be increase.
> The thread number increase to maximumPoolSize only when the workQueue is full.
> file location: 
> org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java
> private void initializeStripedBlkReconstructionThreadPool(int numThreads) {
>    LOG.debug("Using striped block reconstruction; pool threads={}",
>        numThreads);
>    stripedReconstructionPool = DFSUtilClient.getThreadPoolExecutor(2,
>        {color:#ff}numThreads{color}, 60, {color:#ff}new 
> LinkedBlockingQueue<>(){color},
>        "StripedBlockReconstruction-", false);
>    stripedReconstructionPool.allowCoreThreadTimeOut(true);
>  }



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org