[jira] [Commented] (HDFS-14367) Useless parameter maxPoolSize in striped reconstruct thread pool
[
https://issues.apache.org/jira/browse/HDFS-14367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105360#comment-17105360
]
Hadoop QA commented on HDFS-14367:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
54s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 24m
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
16m 7s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
53s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
51s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 55s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 93m 9s{color}
| {color:red} hadoop-hdfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
43s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}165m 45s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://builds.apache.org/job/PreCommit-HDFS-Build/29269/artifact/out/Dockerfile
|
| JIRA Issue | HDFS-14367 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12962269/HDFS-14367.001.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux f63d3f508679 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 0fe49036e55 |
| Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 |
| unit |
[jira] [Commented] (HDFS-14367) Useless parameter maxPoolSize in striped reconstruct thread pool
[
https://issues.apache.org/jira/browse/HDFS-14367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105261#comment-17105261
]
Ayush Saxena commented on HDFS-14367:
-
Have triggered jenkins
> Useless parameter maxPoolSize in striped reconstruct thread pool
>
>
> Key: HDFS-14367
> URL: https://issues.apache.org/jira/browse/HDFS-14367
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ec
>Affects Versions: 3.3.0
>Reporter: Guo Lei
>Priority: Major
> Attachments: HDFS-14367.001.patch
>
>
> The workQueue length wasn't specified, so the thread number never be increase.
> The thread number increase to maximumPoolSize only when the workQueue is full.
> file location:
> org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java
> private void initializeStripedBlkReconstructionThreadPool(int numThreads) {
> LOG.debug("Using striped block reconstruction; pool threads={}",
> numThreads);
> stripedReconstructionPool = DFSUtilClient.getThreadPoolExecutor(2,
> {color:#ff}numThreads{color}, 60, {color:#ff}new
> LinkedBlockingQueue<>(){color},
> "StripedBlockReconstruction-", false);
> stripedReconstructionPool.allowCoreThreadTimeOut(true);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14367) Useless parameter maxPoolSize in striped reconstruct thread pool
[
https://issues.apache.org/jira/browse/HDFS-14367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793369#comment-16793369
]
Guo Lei commented on HDFS-14367:
[~2012ec...@smvdu.ac.in] PTAL
> Useless parameter maxPoolSize in striped reconstruct thread pool
>
>
> Key: HDFS-14367
> URL: https://issues.apache.org/jira/browse/HDFS-14367
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ec
>Affects Versions: 3.3.0
>Reporter: Guo Lei
>Priority: Major
> Attachments: HDFS-14367.001.patch
>
>
> The workQueue length wasn't specified, so the thread number never be increase.
> The thread number increase to maximumPoolSize only when the workQueue is full.
> file location:
> org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java
> private void initializeStripedBlkReconstructionThreadPool(int numThreads) {
> LOG.debug("Using striped block reconstruction; pool threads={}",
> numThreads);
> stripedReconstructionPool = DFSUtilClient.getThreadPoolExecutor(2,
> {color:#ff}numThreads{color}, 60, {color:#ff}new
> LinkedBlockingQueue<>(){color},
> "StripedBlockReconstruction-", false);
> stripedReconstructionPool.allowCoreThreadTimeOut(true);
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
