[jira] [Commented] (HDFS-14653) RBF: Correct the default value for dfs.federation.router.namenode.heartbeat.enable
[
https://issues.apache.org/jira/browse/HDFS-14653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887538#comment-16887538
]
Hudson commented on HDFS-14653:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16943 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/16943/])
HDFS-14653. RBF: Correct the default value for (tasanuma: rev
9792f58662a256f79d2c8352e11d7368ac49698a)
* (edit)
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouter.java
* (edit)
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/resources/hdfs-rbf-default.xml
> RBF: Correct the default value for
> dfs.federation.router.namenode.heartbeat.enable
> --
>
> Key: HDFS-14653
> URL: https://issues.apache.org/jira/browse/HDFS-14653
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Ayush Saxena
>Assignee: Ayush Saxena
>Priority: Major
> Fix For: 3.3.0
>
> Attachments: HDFS-14653-01.patch, HDFS-14653-02.patch
>
>
> dfs.federation.router.namenode.heartbeat.enable is suppose to take the value
> of dfs.federation.router.heartbeat.enable when it isn't explicitly specified.
> by ::
> {noformat}
> boolean isRouterHeartbeatEnabled = conf.getBoolean(
> RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE,
> RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE_DEFAULT);
> boolean isNamenodeHeartbeatEnable = conf.getBoolean(
> RBFConfigKeys.DFS_ROUTER_NAMENODE_HEARTBEAT_ENABLE,
> isRouterHeartbeatEnabled);
> {noformat}
> But since now RBF-Defaults are added by default, this logic doesn't hold, and
> the value defaults to true.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14653) RBF: Correct the default value for dfs.federation.router.namenode.heartbeat.enable
[
https://issues.apache.org/jira/browse/HDFS-14653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887526#comment-16887526
]
Takanobu Asanuma commented on HDFS-14653:
-
Surely, the default value should be empty to follow the description. +1.
Will commit it soon.
> RBF: Correct the default value for
> dfs.federation.router.namenode.heartbeat.enable
> --
>
> Key: HDFS-14653
> URL: https://issues.apache.org/jira/browse/HDFS-14653
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Ayush Saxena
>Assignee: Ayush Saxena
>Priority: Major
> Attachments: HDFS-14653-01.patch, HDFS-14653-02.patch
>
>
> dfs.federation.router.namenode.heartbeat.enable is suppose to take the value
> of dfs.federation.router.heartbeat.enable when it isn't explicitly specified.
> by ::
> {noformat}
> boolean isRouterHeartbeatEnabled = conf.getBoolean(
> RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE,
> RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE_DEFAULT);
> boolean isNamenodeHeartbeatEnable = conf.getBoolean(
> RBFConfigKeys.DFS_ROUTER_NAMENODE_HEARTBEAT_ENABLE,
> isRouterHeartbeatEnabled);
> {noformat}
> But since now RBF-Defaults are added by default, this logic doesn't hold, and
> the value defaults to true.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14653) RBF: Correct the default value for dfs.federation.router.namenode.heartbeat.enable
[
https://issues.apache.org/jira/browse/HDFS-14653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887224#comment-16887224
]
Íñigo Goiri commented on HDFS-14653:
[~tasanuma] do you mind taking a look?
This might be related to the change for the defaults file.
> RBF: Correct the default value for
> dfs.federation.router.namenode.heartbeat.enable
> --
>
> Key: HDFS-14653
> URL: https://issues.apache.org/jira/browse/HDFS-14653
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Ayush Saxena
>Assignee: Ayush Saxena
>Priority: Major
> Attachments: HDFS-14653-01.patch, HDFS-14653-02.patch
>
>
> dfs.federation.router.namenode.heartbeat.enable is suppose to take the value
> of dfs.federation.router.heartbeat.enable when it isn't explicitly specified.
> by ::
> {noformat}
> boolean isRouterHeartbeatEnabled = conf.getBoolean(
> RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE,
> RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE_DEFAULT);
> boolean isNamenodeHeartbeatEnable = conf.getBoolean(
> RBFConfigKeys.DFS_ROUTER_NAMENODE_HEARTBEAT_ENABLE,
> isRouterHeartbeatEnabled);
> {noformat}
> But since now RBF-Defaults are added by default, this logic doesn't hold, and
> the value defaults to true.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14653) RBF: Correct the default value for dfs.federation.router.namenode.heartbeat.enable
[
https://issues.apache.org/jira/browse/HDFS-14653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887200#comment-16887200
]
Hadoop QA commented on HDFS-14653:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 23s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
56s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 10s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 22m 32s{color}
| {color:red} hadoop-hdfs-rbf in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 73m 19s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup |
| | hadoop.hdfs.server.federation.security.TestRouterHttpDelegationToken |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 Image:yetus/hadoop:bdbca0e |
| JIRA Issue | HDFS-14653 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12975061/HDFS-14653-02.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml findbugs checkstyle |
| uname | Linux 2a1a0eb66dc0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / c58e11b |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_212 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/27246/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/27246/testReport/ |
| Max. process+thread count | 1618 (vs. ulimit of
[jira] [Commented] (HDFS-14653) RBF: Correct the default value for dfs.federation.router.namenode.heartbeat.enable
[
https://issues.apache.org/jira/browse/HDFS-14653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887098#comment-16887098
]
Ayush Saxena commented on HDFS-14653:
-
Fixed Checkstyle in v2.
> RBF: Correct the default value for
> dfs.federation.router.namenode.heartbeat.enable
> --
>
> Key: HDFS-14653
> URL: https://issues.apache.org/jira/browse/HDFS-14653
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Ayush Saxena
>Assignee: Ayush Saxena
>Priority: Major
> Attachments: HDFS-14653-01.patch, HDFS-14653-02.patch
>
>
> dfs.federation.router.namenode.heartbeat.enable is suppose to take the value
> of dfs.federation.router.heartbeat.enable when it isn't explicitly specified.
> by ::
> {noformat}
> boolean isRouterHeartbeatEnabled = conf.getBoolean(
> RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE,
> RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE_DEFAULT);
> boolean isNamenodeHeartbeatEnable = conf.getBoolean(
> RBFConfigKeys.DFS_ROUTER_NAMENODE_HEARTBEAT_ENABLE,
> isRouterHeartbeatEnabled);
> {noformat}
> But since now RBF-Defaults are added by default, this logic doesn't hold, and
> the value defaults to true.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14653) RBF: Correct the default value for dfs.federation.router.namenode.heartbeat.enable
[
https://issues.apache.org/jira/browse/HDFS-14653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885619#comment-16885619
]
Hadoop QA commented on HDFS-14653:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m
3s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
32s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 35s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
3s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 15s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs-rbf: The patch
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 10s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 24m 7s{color}
| {color:red} hadoop-hdfs-rbf in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 80m 32s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hdfs.server.federation.security.TestRouterHttpDelegationToken |
| | hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 Image:yetus/hadoop:bdbca0e53b4 |
| JIRA Issue | HDFS-14653 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12974761/HDFS-14653-01.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml findbugs checkstyle |
| uname | Linux fef2b62a1975 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4
22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 64d4abf |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_212 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/27231/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
|
| unit |
