[jira] [Commented] (HDFS-14724) Fix JDK7 compatibility in branch-2
[ https://issues.apache.org/jira/browse/HDFS-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905701#comment-16905701 ] Chen Liang commented on HDFS-14724: --- Thanks [~jojochuang] for the review. The failed test is unrelated and passed in my local run. I've committed v001 patch to branch-2. > Fix JDK7 compatibility in branch-2 > -- > > Key: HDFS-14724 > URL: https://issues.apache.org/jira/browse/HDFS-14724 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.10.0 >Reporter: Wei-Chiu Chuang >Assignee: Chen Liang >Priority: Blocker > Attachments: HDFS-14724-branch-2.001.patch > > > With the feature Consistent Read from Standby now in branch-2, I found it > breaks the build when building with JDK7, because it uses > java.util.concurrent.atomic.LongAccumulator which is only in JDK8 and above. > > We should figure out if we want to fix it, or give up JDK7 compatibility. > [~xkrogen] [~shv] [~vagarychen] -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14724) Fix JDK7 compatibility in branch-2
[
https://issues.apache.org/jira/browse/HDFS-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905698#comment-16905698
]
Hadoop QA commented on HDFS-14724:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 4m
52s{color} | {color:red} root in branch-2 failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m
3s{color} | {color:red} hadoop-hdfs in branch-2 failed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} branch-2 passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
56s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
4s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
12s{color} | {color:green} branch-2 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} branch-2 passed with JDK v1.8.0_212 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 50s{color}
| {color:red} hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95 with JDK v1.7.0_95
generated 1 new + 372 unchanged - 2 fixed = 373 total (was 374) {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed with JDK v1.8.0_212 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} hadoop-hdfs-project/hadoop-hdfs: The patch generated
0 new + 17 unchanged - 1 fixed = 17 total (was 18) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} the patch passed with JDK v1.8.0_212 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 73m 26s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 97m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 Image:yetus/hadoop:da675796017 |
| JIRA Issue | HDFS-14724 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977384/HDFS-14724-branch-2.001.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 6a2519b2e10c 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4
22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HDFS-14724) Fix JDK7 compatibility in branch-2
[ https://issues.apache.org/jira/browse/HDFS-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905505#comment-16905505 ] Wei-Chiu Chuang commented on HDFS-14724: +1 pending Jenkins. passed my local build after this patch. > Fix JDK7 compatibility in branch-2 > -- > > Key: HDFS-14724 > URL: https://issues.apache.org/jira/browse/HDFS-14724 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.10.0 >Reporter: Wei-Chiu Chuang >Assignee: Chen Liang >Priority: Blocker > Attachments: HDFS-14724-branch-2.001.patch > > > With the feature Consistent Read from Standby now in branch-2, I found it > breaks the build when building with JDK7, because it uses > java.util.concurrent.atomic.LongAccumulator which is only in JDK8 and above. > > We should figure out if we want to fix it, or give up JDK7 compatibility. > [~xkrogen] [~shv] [~vagarychen] -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14724) Fix JDK7 compatibility in branch-2
[ https://issues.apache.org/jira/browse/HDFS-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905417#comment-16905417 ] Chen Liang commented on HDFS-14724: --- Post 001 patch to just remove this import. Worked in my local build. > Fix JDK7 compatibility in branch-2 > -- > > Key: HDFS-14724 > URL: https://issues.apache.org/jira/browse/HDFS-14724 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.10.0 >Reporter: Wei-Chiu Chuang >Assignee: Chen Liang >Priority: Blocker > Attachments: HDFS-14724-branch-2.001.patch > > > With the feature Consistent Read from Standby now in branch-2, I found it > breaks the build when building with JDK7, because it uses > java.util.concurrent.atomic.LongAccumulator which is only in JDK8 and above. > > We should figure out if we want to fix it, or give up JDK7 compatibility. > [~xkrogen] [~shv] [~vagarychen] -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14724) Fix JDK7 compatibility in branch-2
[
https://issues.apache.org/jira/browse/HDFS-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905397#comment-16905397
]
Chen Liang commented on HDFS-14724:
---
I thought I had already replaced all the {{LongAccumulator}} with
{{AtomicLong}}, but I guess I missed this import (oops...). The actual code
always uses {{AtomicLong}}, just need to get rid of this import.
> Fix JDK7 compatibility in branch-2
> --
>
> Key: HDFS-14724
> URL: https://issues.apache.org/jira/browse/HDFS-14724
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.10.0
>Reporter: Wei-Chiu Chuang
>Priority: Blocker
>
> With the feature Consistent Read from Standby now in branch-2, I found it
> breaks the build when building with JDK7, because it uses
> java.util.concurrent.atomic.LongAccumulator which is only in JDK8 and above.
>
> We should figure out if we want to fix it, or give up JDK7 compatibility.
> [~xkrogen] [~shv] [~vagarychen]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14724) Fix JDK7 compatibility in branch-2
[
https://issues.apache.org/jira/browse/HDFS-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905386#comment-16905386
]
He Xiaoqiao commented on HDFS-14724:
[~jojochuang],[~xkrogen], just check {{HATestUtil}} which is unused import.
Should we remove it directly? Please correct me if miss something.
> Fix JDK7 compatibility in branch-2
> --
>
> Key: HDFS-14724
> URL: https://issues.apache.org/jira/browse/HDFS-14724
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.10.0
>Reporter: Wei-Chiu Chuang
>Priority: Blocker
>
> With the feature Consistent Read from Standby now in branch-2, I found it
> breaks the build when building with JDK7, because it uses
> java.util.concurrent.atomic.LongAccumulator which is only in JDK8 and above.
>
> We should figure out if we want to fix it, or give up JDK7 compatibility.
> [~xkrogen] [~shv] [~vagarychen]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14724) Fix JDK7 compatibility in branch-2
[
https://issues.apache.org/jira/browse/HDFS-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905385#comment-16905385
]
Erik Krogen commented on HDFS-14724:
Thanks for reporting this [~jojochuang]. [~vagarychen], we can probably switch
this to use an {{AtomicLong}} instead?
> Fix JDK7 compatibility in branch-2
> --
>
> Key: HDFS-14724
> URL: https://issues.apache.org/jira/browse/HDFS-14724
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.10.0
>Reporter: Wei-Chiu Chuang
>Priority: Blocker
>
> With the feature Consistent Read from Standby now in branch-2, I found it
> breaks the build when building with JDK7, because it uses
> java.util.concurrent.atomic.LongAccumulator which is only in JDK8 and above.
>
> We should figure out if we want to fix it, or give up JDK7 compatibility.
> [~xkrogen] [~shv] [~vagarychen]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14724) Fix JDK7 compatibility in branch-2
[
https://issues.apache.org/jira/browse/HDFS-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905373#comment-16905373
]
Wei-Chiu Chuang commented on HDFS-14724:
I'm not sure Yetus doesn't complain, but this is what I have when I build with
JDK7:
{noformat}
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 57.797 s
[INFO] Finished at: 2019-08-12T09:51:10-07:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile
(default-testCompile) on project hadoop-hdfs: Compilation failure: Compilation
failure:
[ERROR]
/Users/weichiu/sandbox/upstream/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/HATestUtil.java:[39,35]
cannot find symbol
[ERROR] symbol: class LongAccumulator
[ERROR] location: package java.util.concurrent.atomic
[ERROR]
/Users/weichiu/sandbox/upstream/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NameNodeAdapter.java:[226,23]
cannot find symbol
[ERROR] symbol: method
setBlockManagerForTesting(org.apache.hadoop.hdfs.server.blockmanagement.BlockManager)
[ERROR] location: class org.apache.hadoop.hdfs.server.namenode.FSNamesystem
[ERROR] -> [Help 1]
{noformat}
> Fix JDK7 compatibility in branch-2
> --
>
> Key: HDFS-14724
> URL: https://issues.apache.org/jira/browse/HDFS-14724
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.10.0
>Reporter: Wei-Chiu Chuang
>Priority: Blocker
>
> With the feature Consistent Read from Standby now in branch-2, I found it
> breaks the build when building with JDK7, because it uses
> java.util.concurrent.atomic.LongAccumulator which is only in JDK8 and above.
>
> We should figure out if we want to fix it, or give up JDK7 compatibility.
> [~xkrogen] [~shv] [~vagarychen]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
