[jira] [Commented] (HDFS-15389) DFSAdmin should close filesystem and dfsadmin -setBalancerBandwidth should work with ViewFSOverloadScheme
[ https://issues.apache.org/jira/browse/HDFS-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127241#comment-17127241 ] Hudson commented on HDFS-15389: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18334 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/18334/]) HDFS-15389. DFSAdmin should close filesystem and dfsadmin (github: rev cc671b16f7b0b7c1ed7b41b96171653dc43cf670) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestViewFileSystemOverloadSchemeWithDFSAdmin.java > DFSAdmin should close filesystem and dfsadmin -setBalancerBandwidth should > work with ViewFSOverloadScheme > -- > > Key: HDFS-15389 > URL: https://issues.apache.org/jira/browse/HDFS-15389 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Attachments: HDFS-15389-01.patch > > > Two Issues Here : > Firstly Prior to HDFS-15321, When DFSAdmin was closed the FileSystem > associated with it was closed as part of close method, But post HDFS-15321, > the {{FileSystem}} isn't stored as part of {{FsShell}}, hence during close, > the FileSystem still stays and isn't close. > * This is the reason for failure of TestDFSHAAdmin > Second : {{DfsAdmin -setBalancerBandwidth}} doesn't work with > {{ViewFSOverloadScheme}} since the setBalancerBandwidth calls {{getFS()}} > rather than {{getDFS()}} which resolves the scheme in {{HDFS-15321}} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15389) DFSAdmin should close filesystem and dfsadmin -setBalancerBandwidth should work with ViewFSOverloadScheme
[ https://issues.apache.org/jira/browse/HDFS-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127005#comment-17127005 ] Ayush Saxena commented on HDFS-15389: - Have fixed the checkstyle in PR https://github.com/apache/hadoop/pull/2057 > DFSAdmin should close filesystem and dfsadmin -setBalancerBandwidth should > work with ViewFSOverloadScheme > -- > > Key: HDFS-15389 > URL: https://issues.apache.org/jira/browse/HDFS-15389 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Attachments: HDFS-15389-01.patch > > > Two Issues Here : > Firstly Prior to HDFS-15321, When DFSAdmin was closed the FileSystem > associated with it was closed as part of close method, But post HDFS-15321, > the {{FileSystem}} isn't stored as part of {{FsShell}}, hence during close, > the FileSystem still stays and isn't close. > * This is the reason for failure of TestDFSHAAdmin > Second : {{DfsAdmin -setBalancerBandwidth}} doesn't work with > {{ViewFSOverloadScheme}} since the setBalancerBandwidth calls {{getFS()}} > rather than {{getDFS()}} which resolves the scheme in {{HDFS-15321}} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15389) DFSAdmin should close filesystem and dfsadmin -setBalancerBandwidth should work with ViewFSOverloadScheme
[ https://issues.apache.org/jira/browse/HDFS-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126581#comment-17126581 ] Hadoop QA commented on HDFS-15389: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 23s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m 42s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 8s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 48s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 15s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 17m 30s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s{color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m 2s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 0s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 44s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 179 unchanged - 0 fixed = 180 total (was 179) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 15m 40s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 5s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}119m 3s{color} | {color:red} hadoop-hdfs in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 35s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}190m 42s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy | | | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure | | | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks | | | hadoop.hdfs.TestMultipleNNPortQOP | | | hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy | | | hadoop.hdfs.TestReconstructStripedFile | | | hadoop.hdfs.TestStripedFileAppend | | | hadoop.hdfs.TestRollingUpgrade | \\ \\ || Subsystem || Report/Notes || | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-HDFS-Build/29404/artifact/out/Dockerfile | | JIRA Issue | HDFS-15389 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13004879/HDFS-15389-01.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux
[jira] [Commented] (HDFS-15389) DFSAdmin should close filesystem and dfsadmin -setBalancerBandwidth should work with ViewFSOverloadScheme
[ https://issues.apache.org/jira/browse/HDFS-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126436#comment-17126436 ] Ayush Saxena commented on HDFS-15389: - [~umamaheswararao] / [~rakeshr] / [~vinayakumarb] can you give a check once > DFSAdmin should close filesystem and dfsadmin -setBalancerBandwidth should > work with ViewFSOverloadScheme > -- > > Key: HDFS-15389 > URL: https://issues.apache.org/jira/browse/HDFS-15389 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Attachments: HDFS-15389-01.patch > > > Two Issues Here : > Firstly Prior to HDFS-15321, When DFSAdmin was closed the FileSystem > associated with it was closed as part of close method, But post HDFS-15321, > the {{FileSystem}} isn't stored as part of {{FsShell}}, hence during close, > the FileSystem still stays and isn't close. > ** This is the reason for failure of TestDFSHAAdmin > Second : {{DfsAdmin -setBalancerBandwidth}} doesn't work with > {{ViewFSOverloadScheme}} since the setBalancerBandwidth calls {{getFS()}} > rather than {{getDFS()}} which resolves the scheme in {{HDFS-15321}} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org