[jira] [Commented] (HDFS-15971) Make mkstemp cross platform
[
https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360371#comment-17360371
]
Jim Brennan commented on HDFS-15971:
[~gautham], thanks for your response. I have upgraded everything on my linux VM
based on what is in the centos 7 docker image, and I have been able to get
native hadoop to compile.
I think improving the Windows build experience is a worthy goal. I am a bit
concerned about how much of an upgrade this is on the linux (gcc) side, going
from 4.8.5 to 9.3.0. Maybe this is OK to do in trunk, but if the intention is
to push this back to earlier branch-3 branches, that might be a problem for
groups using those branches. I'm not sure what the guidelines are for upgrading
the build environment in minor releases. As you say, maybe it is worth it in
this case.
Note that I can build trunk with 4.8.5 if I revert the change to this line in
build_libhdfs_test in hadoop-hdfs-native-client/.../src/CMakeLists.txt:
{code:java}
add_executable("${NAME}_${LIBRARY}" $
$ ${FILES})
{code}
But I think that just prevents it from building the x_platform_obj.
I'm not sure if it was building the x_platform stuff prior to this commit, or
if it was just silently failing with 4.8.5?
{quote}*I'm also puzzled by this failing check. This did not fail on 4.8.5
before this commit (and the warning message hasn't been updated either):*
This is coming from here. Let me take a look at this and get back to you.
Nevertheless, we don't face this issue when GCC is upgraded to 9.3.0.
{quote}
I am curious to see what you find. I would like to understand better what
specifically in this commit is causing this check to fail with gcc 4.8.5. It
wasn't failing before, and you didn't modify this check.
> Make mkstemp cross platform
> ---
>
> Key: HDFS-15971
> URL: https://issues.apache.org/jira/browse/HDFS-15971
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs++
>Affects Versions: 3.4.0
>Reporter: Gautham Banasandra
>Assignee: Gautham Banasandra
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: Dockerfile_centos_7, build-log.zip, commit-details.txt
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> mkstemp isn't available in Visual C++. Need to make it cross platform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15971) Make mkstemp cross platform
[
https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359695#comment-17359695
]
Gautham Banasandra commented on HDFS-15971:
---
Hi [~Jim_Brennan],
I'm sorry for the inconvenience that you're facing. Please find my answers
below -
*_It looks like HDFS-15740 caused a need for the rhel8 build instructions to be
updated_*
I'm working on a bigger change HADOOP-17193 - this requires the latest C++
compiler to be used. At least the one which supports the C++17 standard. Hence,
the upgrade from GCC 4.8.1 to 9.3.0. Now, if we think about the possibility of
having the compiler upgraded only for Windows and let GCC 4.8.1 stay for Linux
systems, this would lead to a huge dichotomy in the codebase, which would be
extremely difficult to maintain and to make further improvements/fixes.
*_The Cmake update seems reasonable, but do these changes really justify
updating the GCC from 4.8 to 9.3 - that's a pretty significant change. I don't
think we usually upgrade dependencies that aggressively._*
I believe you had HDFS-15740 in mind when you wrote this, but thinking about
HADOOP-17193, it certainly is huge. Resolving HADOOP-17193 will enable Hadoop
to be used on Windows platform. It will also get rid of the age old winutils
issues HADOOP-13223. This'll not just benefit Hadoop, but also the ecosystem
that runs on top of Hadoop - Spark on Windows still needs winutils.exe. I've
also fixed a lot of bugs on my journey through HADOOP-17193, please take a look
its children and related JIRAs. With all this in mind, I believe the compiler
upgrade is justified.
*_[~elgoiri] mentioned fuse dependencies. Does this change require Linux FUSE?
I think that used to be optional._*
No, this change has no relation with Linux FUSE. I think [~elgoiri]
[mentioned|https://issues.apache.org/jira/browse/HDFS-15971?focusedCommentId=17352081&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17352081]
about FUSE because of the CMake stack trace seen in [~ebadger]'s
[comment|https://issues.apache.org/jira/browse/HDFS-15971?focusedCommentId=17322535&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17322535].
{code}
[WARNING] -- Checking for module 'fuse'
[WARNING] -- No package 'fuse' found
[WARNING] -- Failed to find Linux FUSE libraries or include files. Will not
build FUSE client.
{code}
What [~goiri] was saying is that the build setup used by [~ebadger] doesn't
contain FUSE, however, the [^Dockerfile_centos_7] has FUSE installed and was
suggesting to use this.
*_I'm also puzzled by this failing check. This did not fail on 4.8.5 before
this commit (and the warning message hasn't been updated either):_*
This is coming from
[here|https://github.com/apache/hadoop/blob/bcaeb1ac8cd67a14bd332d62bdec1a90ce1c9549/hadoop-hdfs-project/hadoop-hdfs-native-client/src/CMakeLists.txt#L159-L178].
Let me take a look at this and get back to you. Nevertheless, we don't face
this issue when GCC is upgraded to 9.3.0.
[~Jim_Brennan] have you considered upgrading GCC to 9.3.0 in your system? I've
also added the
[Dockerfile|https://github.com/apache/hadoop/blob/trunk/dev-support/docker/Dockerfile_centos_7]
for convenience of those who wish to run Hadoop on Centos 7.
> Make mkstemp cross platform
> ---
>
> Key: HDFS-15971
> URL: https://issues.apache.org/jira/browse/HDFS-15971
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs++
>Affects Versions: 3.4.0
>Reporter: Gautham Banasandra
>Assignee: Gautham Banasandra
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: Dockerfile_centos_7, build-log.zip, commit-details.txt
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> mkstemp isn't available in Visual C++. Need to make it cross platform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15971) Make mkstemp cross platform
[
https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359559#comment-17359559
]
Jim Brennan commented on HDFS-15971:
I'm also puzzled by this failing check. This did not fail on 4.8.5 before this
commit (and the warning message hasn't been updated either):
{noformat}
[WARNING] -- The C compiler identification is GNU 4.8.5
[WARNING] -- The CXX compiler identification is GNU 4.8.5
...
[WARNING] CMake Warning at CMakeLists.txt:174 (message):
[WARNING] WARNING: Libhdfs++ library was not built because the required
feature
[WARNING] thread_local storage is not supported by your compiler. Known
compilers
[WARNING] that support this feature: GCC 4.8+, Visual Studio 2015+, Clang
(community
[WARNING] version 3.3+), Clang (version for Xcode 8+ and iOS 9+).
{noformat}
> Make mkstemp cross platform
> ---
>
> Key: HDFS-15971
> URL: https://issues.apache.org/jira/browse/HDFS-15971
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs++
>Affects Versions: 3.4.0
>Reporter: Gautham Banasandra
>Assignee: Gautham Banasandra
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: Dockerfile_centos_7, build-log.zip, commit-details.txt
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> mkstemp isn't available in Visual C++. Need to make it cross platform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15971) Make mkstemp cross platform
[
https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359551#comment-17359551
]
Jim Brennan commented on HDFS-15971:
[~gautham], [~elgoiri], [~ebadger] There still seems to be a problem here.
Our development systems are RHEL7 with GCC 4.8.5. Until this jira went in, I
had no problems building native code on that system. And we don't use docker
for our builds.If I revert this change, I can build with no problems.
It looks like HDFS-15740 caused a need for the rhel8 build instructions to be
updated to change:
{noformat}
CMake 3.1 --> CMake 3.19
GCC 4.8.1 or later --> GCC 9.3.0 or later
{noformat}
The Cmake update seems reasonable, but do these changes really justify updating
the GCC from 4.8 to 9.3 - that's a pretty significant change. I don't think
we usually upgrade dependencies that aggressively.
But my build was still working fine before this jira went in. Apparently
previous changes did not require these upgrades for all platforms.
[~elgoiri] mentioned fuse dependencies. Does this change require Linux FUSE?
I think that used to be optional.
> Make mkstemp cross platform
> ---
>
> Key: HDFS-15971
> URL: https://issues.apache.org/jira/browse/HDFS-15971
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs++
>Affects Versions: 3.4.0
>Reporter: Gautham Banasandra
>Assignee: Gautham Banasandra
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: Dockerfile_centos_7, build-log.zip, commit-details.txt
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> mkstemp isn't available in Visual C++. Need to make it cross platform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15971) Make mkstemp cross platform
[ https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352081#comment-17352081 ] Íñigo Goiri commented on HDFS-15971: I'm merging this again as the Docker image seems to work fine. It looks like the fuse dependencies were missing but the Docker image has them. > Make mkstemp cross platform > --- > > Key: HDFS-15971 > URL: https://issues.apache.org/jira/browse/HDFS-15971 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs++ >Affects Versions: 3.4.0 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: pull-request-available > Attachments: Dockerfile_centos_7, build-log.zip, commit-details.txt > > Time Spent: 1.5h > Remaining Estimate: 0h > > mkstemp isn't available in Visual C++. Need to make it cross platform. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15971) Make mkstemp cross platform
[ https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350514#comment-17350514 ] Íñigo Goiri commented on HDFS-15971: [~ebadger] can you take a look and verify that this works for Centos 7? > Make mkstemp cross platform > --- > > Key: HDFS-15971 > URL: https://issues.apache.org/jira/browse/HDFS-15971 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs++ >Affects Versions: 3.4.0 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: pull-request-available > Attachments: Dockerfile_centos_7, build-log.zip, commit-details.txt > > Time Spent: 1.5h > Remaining Estimate: 0h > > mkstemp isn't available in Visual C++. Need to make it cross platform. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15971) Make mkstemp cross platform
[ https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350077#comment-17350077 ] Gautham Banasandra commented on HDFS-15971: --- Hi [~ebadger], I was able to verify that Hadoop trunk builds fine with my fix on Centos 7. Please refer to the [^build-log.zip] and [^commit-details.txt]. I used [^Dockerfile_centos_7] docker image for building. The most likely reason why the build could've failed in your system is because you might be using an older version of CMake. Could you please ensure that you're running CMake 3.19 or higher? Please feel free to use [^Dockerfile_centos_7] if you would like to verify too. I'm restoring my PR - https://github.com/apache/hadoop/pull/3044. [~elgoiri] please review this. > Make mkstemp cross platform > --- > > Key: HDFS-15971 > URL: https://issues.apache.org/jira/browse/HDFS-15971 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs++ >Affects Versions: 3.4.0 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: pull-request-available > Attachments: Dockerfile_centos_7, build-log.zip, commit-details.txt > > Time Spent: 1h 20m > Remaining Estimate: 0h > > mkstemp isn't available in Visual C++. Need to make it cross platform. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15971) Make mkstemp cross platform
[ https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17323953#comment-17323953 ] Eric Badger commented on HDFS-15971: Yea, I think reverting would be best until we can figure out how to fix it on RHEL. I'll revert it. I'm not familiar with the code that was modified, but I'm happy to test any patches on RHEL to make sure that they work on that environment before we merge again. > Make mkstemp cross platform > --- > > Key: HDFS-15971 > URL: https://issues.apache.org/jira/browse/HDFS-15971 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs++ >Affects Versions: 3.4.0 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 1h > Remaining Estimate: 0h > > mkstemp isn't available in Visual C++. Need to make it cross platform. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15971) Make mkstemp cross platform
[ https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17323948#comment-17323948 ] Gautham Banasandra commented on HDFS-15971: --- Sorry about the inconvenience [~ebadger]. It's quite strange as to why the CMake in RHEL 7.6 isn't able to find x_platform_obj_c_api. Since, this runs without any issues on Ubuntu Focal. [~elgoiri] I'll fix this over the weekend. But if it's blocking folks on RHEL 7, please feel free to revert this. > Make mkstemp cross platform > --- > > Key: HDFS-15971 > URL: https://issues.apache.org/jira/browse/HDFS-15971 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs++ >Affects Versions: 3.4.0 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 1h > Remaining Estimate: 0h > > mkstemp isn't available in Visual C++. Need to make it cross platform. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15971) Make mkstemp cross platform
[ https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322546#comment-17322546 ] Íñigo Goiri commented on HDFS-15971: [~ebadger], sorry about the inconvenience. We did not test with RHEL and we had a similar issue in HDFS-15977. [~gautham], is it possible to add a check or to add the dependency to the instructions? Otherwise, I'll go ahead and revert. > Make mkstemp cross platform > --- > > Key: HDFS-15971 > URL: https://issues.apache.org/jira/browse/HDFS-15971 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs++ >Affects Versions: 3.4.0 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 1h > Remaining Estimate: 0h > > mkstemp isn't available in Visual C++. Need to make it cross platform. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15971) Make mkstemp cross platform
[
https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322535#comment-17322535
]
Eric Badger commented on HDFS-15971:
{noformat}
[INFO] Running cmake
/home/ebadger/hadoop/hadoop-hdfs-project/hadoop-hdfs-native-client/src
-DGENERATED_JAVAH=/home/ebadger/hadoop/hadoop-hdfs-project/hadoop-hdfs-native-client/target/native/javah
-DHADOOP_BUILD=1 -DJVM_ARCH_DATA_MODEL=64 -DREQUIRE_FUSE=false
-DREQUIRE_LIBWEBHDFS=false -DREQUIRE_VALGRIND=false -G Unix Makefiles
[INFO] with extra environment variables {}
[WARNING] JAVA_HOME=,
JAVA_JVM_LIBRARY=/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.191.b12-1.el7_6.x86_64/jre/lib/amd64/server/libjvm.so
[WARNING]
JAVA_INCLUDE_PATH=/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.191.b12-1.el7_6.x86_64/include,
JAVA_INCLUDE_PATH2=/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.191.b12-1.el7_6.x86_64/include/linux
[WARNING] Located all JNI components successfully.
[WARNING] CUSTOM_OPENSSL_PREFIX =
[WARNING] -- Performing Test THREAD_LOCAL_SUPPORTED
[WARNING] -- Performing Test THREAD_LOCAL_SUPPORTED - Failed
[WARNING] CMake Warning at CMakeLists.txt:174 (message):
[WARNING] WARNING: Libhdfs++ library was not built because the required
feature
[WARNING] thread_local storage is not supported by your compiler. Known
compilers
[WARNING] that support this feature: GCC 4.8+, Visual Studio 2015+, Clang
(community
[WARNING] version 3.3+), Clang (version for Xcode 8+ and iOS 9+).
[WARNING]
[WARNING]
[WARNING] -- Checking for module 'fuse'
[WARNING] -- No package 'fuse' found
[WARNING] -- Failed to find Linux FUSE libraries or include files. Will not
build FUSE client.
[WARNING] -- Configuring done
[WARNING] CMake Error at CMakeLists.txt:94 (add_executable):
[WARNING] Error evaluating generator expression:
[WARNING]
[WARNING] $
[WARNING]
[WARNING] Objects of target "x_platform_obj_c_api" referenced but no such
target
[WARNING] exists.
[WARNING] Call Stack (most recent call first):
[WARNING] main/native/libhdfs/CMakeLists.txt:74 (build_libhdfs_test)
[WARNING]
[WARNING]
[WARNING] CMake Error at CMakeLists.txt:94 (add_executable):
[WARNING] Error evaluating generator expression:
[WARNING]
[WARNING] $
[WARNING]
[WARNING] Objects of target "x_platform_obj_c_api" referenced but no such
target
[WARNING] exists.
[WARNING] Call Stack (most recent call first):
[WARNING] main/native/libhdfs/CMakeLists.txt:66 (build_libhdfs_test)
[WARNING]
[WARNING]
[WARNING] CMake Error at CMakeLists.txt:94 (add_executable):
[WARNING] Error evaluating generator expression:
[WARNING]
[WARNING] $
[WARNING]
[WARNING] Objects of target "x_platform_obj_c_api" referenced but no such
target
[WARNING] exists.
[WARNING] Call Stack (most recent call first):
[WARNING] main/native/libhdfs/CMakeLists.txt:61 (build_libhdfs_test)
[WARNING]
[WARNING]
[WARNING] CMake Error at CMakeLists.txt:94 (add_executable):
[WARNING] Error evaluating generator expression:
[WARNING]
[WARNING] $
[WARNING]
[WARNING] Objects of target "x_platform_obj_c_api" referenced but no such
target
[WARNING] exists.
[WARNING] Call Stack (most recent call first):
[WARNING] main/native/libhdfs/CMakeLists.txt:57 (build_libhdfs_test)
[WARNING]
[WARNING]
[WARNING] CMake Error at CMakeLists.txt:94 (add_executable):
[WARNING] No SOURCES given to target: test_libhdfs_vecsum_hdfs
[WARNING] Call Stack (most recent call first):
[WARNING] main/native/libhdfs/CMakeLists.txt:74 (build_libhdfs_test)
[WARNING]
[WARNING]
[WARNING] CMake Error at CMakeLists.txt:94 (add_executable):
[WARNING] No SOURCES given to target: test_libhdfs_zerocopy_hdfs_static
[WARNING] Call Stack (most recent call first):
[WARNING] main/native/libhdfs/CMakeLists.txt:66 (build_libhdfs_test)
[WARNING]
[WARNING]
[WARNING] CMake Error at CMakeLists.txt:94 (add_executable):
[WARNING] No SOURCES given to target: test_libhdfs_threaded_hdfs_static
[WARNING] Call Stack (most recent call first):
[WARNING] main/native/libhdfs/CMakeLists.txt:61 (build_libhdfs_test)
[WARNING]
[WARNING]
[WARNING] CMake Error at CMakeLists.txt:94 (add_executable):
[WARNING] No SOURCES given to target: test_libhdfs_ops_hdfs_static
[WARNING] Call Stack (most recent call first):
[WARNING] main/native/libhdfs/CMakeLists.txt:57 (build_libhdfs_test)
[WARNING]
[WARNING]
[WARNING] -- Build files have been written to:
/home/ebadger/hadoop/hadoop-hdfs-project/hadoop-hdfs-native-client/target
{noformat}
[~gautham], [~inigoiri], this PR broke the build for me on trunk. I'm running
on RHEL 7.6 and narrowed it down to this PR. Reverting it allows the build to
succeed for me. Please revert this unless it is a very quick fix
> Make mkstemp cross platform
> ---
>
> Key: HDFS-15971
> URL: https://issues.apache.org/jira/browse/HDFS-15971
> Project: Hadoop HDFS
> Issue Type: Improv
[jira] [Commented] (HDFS-15971) Make mkstemp cross platform
[ https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320269#comment-17320269 ] Íñigo Goiri commented on HDFS-15971: Thanks [~gautham] for the patch. Merged PR 2898. > Make mkstemp cross platform > --- > > Key: HDFS-15971 > URL: https://issues.apache.org/jira/browse/HDFS-15971 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs++ >Affects Versions: 3.4.0 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 1h > Remaining Estimate: 0h > > mkstemp isn't available in Visual C++. Need to make it cross platform. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
