[jira] [Commented] (HDFS-1692) In secure mode, Datanode process doesn't exit when disks fail.
[ https://issues.apache.org/jira/browse/HDFS-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050792#comment-13050792 ] Bharath Mundlapudi commented on HDFS-1692: -- Exiting tests like TestDataNodeExit should check for this condition. So i have not added a new test for this. In secure mode, Datanode process doesn't exit when disks fail. -- Key: HDFS-1692 URL: https://issues.apache.org/jira/browse/HDFS-1692 Project: Hadoop HDFS Issue Type: Bug Components: data-node Affects Versions: 0.20.204.0, 0.23.0 Reporter: Bharath Mundlapudi Assignee: Bharath Mundlapudi Fix For: 0.20.204.0, 0.23.0 Attachments: HDFS-1692-1.patch, HDFS-1692-v0.23-1.patch, HDFS-1692-v0.23-2.patch In secure mode, when disks fail more than volumes tolerated, datanode process doesn't exit properly and it just hangs even though shutdown method is called. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1692) In secure mode, Datanode process doesn't exit when disks fail.
[ https://issues.apache.org/jira/browse/HDFS-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050816#comment-13050816 ] Hudson commented on HDFS-1692: -- Integrated in Hadoop-Hdfs-trunk-Commit #749 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/749/]) HDFS-1692. In secure mode, Datanode process doesn't exit when disks fail. Contributed by Bharath Mundlapudi. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1136741 Files : * /hadoop/common/trunk/hdfs/CHANGES.txt * /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java * /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java In secure mode, Datanode process doesn't exit when disks fail. -- Key: HDFS-1692 URL: https://issues.apache.org/jira/browse/HDFS-1692 Project: Hadoop HDFS Issue Type: Bug Components: data-node Affects Versions: 0.20.204.0, 0.23.0 Reporter: Bharath Mundlapudi Assignee: Bharath Mundlapudi Fix For: 0.20.204.0, 0.23.0 Attachments: HDFS-1692-1.patch, HDFS-1692-v0.23-1.patch, HDFS-1692-v0.23-2.patch In secure mode, when disks fail more than volumes tolerated, datanode process doesn't exit properly and it just hangs even though shutdown method is called. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1692) In secure mode, Datanode process doesn't exit when disks fail.
[ https://issues.apache.org/jira/browse/HDFS-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049925#comment-13049925 ] Suresh Srinivas commented on HDFS-1692: --- Minor comments: # DataNode.java - in finally block, LOG.warn is more appropriate # DataXceiverServer.java - Catching AsynchronousCloseException may not be neccessary In secure mode, Datanode process doesn't exit when disks fail. -- Key: HDFS-1692 URL: https://issues.apache.org/jira/browse/HDFS-1692 Project: Hadoop HDFS Issue Type: Bug Components: data-node Affects Versions: 0.20.204.0, 0.23.0 Reporter: Bharath Mundlapudi Assignee: Bharath Mundlapudi Fix For: 0.20.204.0, 0.23.0 Attachments: HDFS-1692-1.patch, HDFS-1692-v0.23-1.patch In secure mode, when disks fail more than volumes tolerated, datanode process doesn't exit properly and it just hangs even though shutdown method is called. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1692) In secure mode, Datanode process doesn't exit when disks fail.
[ https://issues.apache.org/jira/browse/HDFS-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050182#comment-13050182 ] Hadoop QA commented on HDFS-1692: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482713/HDFS-1692-v0.23-2.patch against trunk revision 1136230. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/790//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/790//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/790//console This message is automatically generated. In secure mode, Datanode process doesn't exit when disks fail. -- Key: HDFS-1692 URL: https://issues.apache.org/jira/browse/HDFS-1692 Project: Hadoop HDFS Issue Type: Bug Components: data-node Affects Versions: 0.20.204.0, 0.23.0 Reporter: Bharath Mundlapudi Assignee: Bharath Mundlapudi Fix For: 0.20.204.0, 0.23.0 Attachments: HDFS-1692-1.patch, HDFS-1692-v0.23-1.patch, HDFS-1692-v0.23-2.patch In secure mode, when disks fail more than volumes tolerated, datanode process doesn't exit properly and it just hangs even though shutdown method is called. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1692) In secure mode, Datanode process doesn't exit when disks fail.
[ https://issues.apache.org/jira/browse/HDFS-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13033855#comment-13033855 ] Eli Collins commented on HDFS-1692: --- @Bharath are you planning to make the same change on trunk? * The change to ipc/Server.java should be covered by a HADOOP jira right? What does this particular change address? * Should the exit value reflect whether the start was successful? In secure mode, Datanode process doesn't exit when disks fail. -- Key: HDFS-1692 URL: https://issues.apache.org/jira/browse/HDFS-1692 Project: Hadoop HDFS Issue Type: Bug Components: data-node Affects Versions: 0.20.204.0 Reporter: Bharath Mundlapudi Assignee: Bharath Mundlapudi Fix For: 0.20.204.0 Attachments: HDFS-1692-1.patch In secure mode, when disks fail more than volumes tolerated, datanode process doesn't exit properly and it just hangs even though shutdown method is called. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1692) In secure mode, Datanode process doesn't exit when disks fail.
[ https://issues.apache.org/jira/browse/HDFS-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13033868#comment-13033868 ] Bharath Mundlapudi commented on HDFS-1692: -- Yes, I will be porting this one to trunk. We run our clusters in secured mode. When a volume tolerated threshold is reached, shutdown is called but datanode continue to run and doesn't exit. This change will address only in secured mode and non secure mode shouldn't have this problem. In secure mode, Datanode process doesn't exit when disks fail. -- Key: HDFS-1692 URL: https://issues.apache.org/jira/browse/HDFS-1692 Project: Hadoop HDFS Issue Type: Bug Components: data-node Affects Versions: 0.20.204.0 Reporter: Bharath Mundlapudi Assignee: Bharath Mundlapudi Fix For: 0.20.204.0 Attachments: HDFS-1692-1.patch In secure mode, when disks fail more than volumes tolerated, datanode process doesn't exit properly and it just hangs even though shutdown method is called. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1692) In secure mode, Datanode process doesn't exit when disks fail.
[ https://issues.apache.org/jira/browse/HDFS-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13033876#comment-13033876 ] Eli Collins commented on HDFS-1692: --- Why is the change to ipc/Server.java necessary to accomplish this? Please file a Hadoop jira for this change, as this code does not live in HDFS. In secure mode, Datanode process doesn't exit when disks fail. -- Key: HDFS-1692 URL: https://issues.apache.org/jira/browse/HDFS-1692 Project: Hadoop HDFS Issue Type: Bug Components: data-node Affects Versions: 0.20.204.0 Reporter: Bharath Mundlapudi Assignee: Bharath Mundlapudi Fix For: 0.20.204.0 Attachments: HDFS-1692-1.patch In secure mode, when disks fail more than volumes tolerated, datanode process doesn't exit properly and it just hangs even though shutdown method is called. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1692) In secure mode, Datanode process doesn't exit when disks fail.
[ https://issues.apache.org/jira/browse/HDFS-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13033880#comment-13033880 ] Bharath Mundlapudi commented on HDFS-1692: -- As i was tracking this hang issue, i have cleaned up some threads which were not exiting. So the change to ipc/Server.java. But yes we can move this particular code to other Jira. For 0.23, we can do separately. In secure mode, Datanode process doesn't exit when disks fail. -- Key: HDFS-1692 URL: https://issues.apache.org/jira/browse/HDFS-1692 Project: Hadoop HDFS Issue Type: Bug Components: data-node Affects Versions: 0.20.204.0 Reporter: Bharath Mundlapudi Assignee: Bharath Mundlapudi Fix For: 0.20.204.0 Attachments: HDFS-1692-1.patch In secure mode, when disks fail more than volumes tolerated, datanode process doesn't exit properly and it just hangs even though shutdown method is called. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1692) In secure mode, Datanode process doesn't exit when disks fail.
[ https://issues.apache.org/jira/browse/HDFS-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13015671#comment-13015671 ] Boris Shkolnik commented on HDFS-1692: -- committed to branch-0.20-security. Thanks Bharath. In secure mode, Datanode process doesn't exit when disks fail. -- Key: HDFS-1692 URL: https://issues.apache.org/jira/browse/HDFS-1692 Project: Hadoop HDFS Issue Type: Bug Components: data-node Affects Versions: 0.20.204.0 Reporter: Bharath Mundlapudi Assignee: Bharath Mundlapudi Fix For: 0.20.204.0 Attachments: HDFS-1692-1.patch In secure mode, when disks fail more than volumes tolerated, datanode process doesn't exit properly and it just hangs even though shutdown method is called. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1692) In secure mode, Datanode process doesn't exit when disks fail.
[ https://issues.apache.org/jira/browse/HDFS-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13014844#comment-13014844 ] Boris Shkolnik commented on HDFS-1692: -- +1 In secure mode, Datanode process doesn't exit when disks fail. -- Key: HDFS-1692 URL: https://issues.apache.org/jira/browse/HDFS-1692 Project: Hadoop HDFS Issue Type: Bug Components: data-node Affects Versions: 0.20.204.0 Reporter: Bharath Mundlapudi Assignee: Bharath Mundlapudi Fix For: 0.20.204.0 Attachments: HDFS-1692-1.patch In secure mode, when disks fail more than volumes tolerated, datanode process doesn't exit properly and it just hangs even though shutdown method is called. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
