[jira] [Commented] (HDFS-1723) quota errors messages should use the same scale
[ https://issues.apache.org/jira/browse/HDFS-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055375#comment-13055375 ] Hudson commented on HDFS-1723: -- Integrated in Hadoop-Hdfs-trunk-Commit #761 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/761/]) HDFS-1723. quota errors messages should use the same scale. (Jim Plush via atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1140030 Files : * /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/cli/testHDFSConf.xml * /hadoop/common/trunk/hdfs/CHANGES.txt * /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestQuota.java * /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/protocol/DSQuotaExceededException.java quota errors messages should use the same scale --- Key: HDFS-1723 URL: https://issues.apache.org/jira/browse/HDFS-1723 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 0.21.0 Reporter: Allen Wittenauer Assignee: Jim Plush Priority: Minor Labels: newbie Fix For: 0.23.0 Attachments: HDFS-1723-take1.txt, HDFS-1723-take2.txt, HDFS-1723-take3.txt, HDFS-1723-take4.txt A typical error message looks like this: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: The DiskSpace quota of /dir is exceeded: quota=3298534883328 diskspace consumed=5246.0g Since the two values are in difference scales and one is replicated vs. not replicated (I think), this isn't very easy for the user to understand. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1723) quota errors messages should use the same scale
[ https://issues.apache.org/jira/browse/HDFS-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055513#comment-13055513 ] Hudson commented on HDFS-1723: -- Integrated in Hadoop-Hdfs-trunk #708 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/708/]) HDFS-1723. quota errors messages should use the same scale. (Jim Plush via atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1140030 Files : * /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/cli/testHDFSConf.xml * /hadoop/common/trunk/hdfs/CHANGES.txt * /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestQuota.java * /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/protocol/DSQuotaExceededException.java quota errors messages should use the same scale --- Key: HDFS-1723 URL: https://issues.apache.org/jira/browse/HDFS-1723 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 0.21.0 Reporter: Allen Wittenauer Assignee: Jim Plush Priority: Minor Labels: newbie Fix For: 0.23.0 Attachments: HDFS-1723-take1.txt, HDFS-1723-take2.txt, HDFS-1723-take3.txt, HDFS-1723-take4.txt A typical error message looks like this: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: The DiskSpace quota of /dir is exceeded: quota=3298534883328 diskspace consumed=5246.0g Since the two values are in difference scales and one is replicated vs. not replicated (I think), this isn't very easy for the user to understand. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1723) quota errors messages should use the same scale
[ https://issues.apache.org/jira/browse/HDFS-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055129#comment-13055129 ] Jim Plush commented on HDFS-1723: - good catch, I'll update the patch and re-submit quota errors messages should use the same scale --- Key: HDFS-1723 URL: https://issues.apache.org/jira/browse/HDFS-1723 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 0.21.0 Reporter: Allen Wittenauer Assignee: Jim Plush Priority: Minor Labels: newbie Fix For: 0.23.0 Attachments: HDFS-1723-take1.txt, HDFS-1723-take2.txt A typical error message looks like this: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: The DiskSpace quota of /dir is exceeded: quota=3298534883328 diskspace consumed=5246.0g Since the two values are in difference scales and one is replicated vs. not replicated (I think), this isn't very easy for the user to understand. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1723) quota errors messages should use the same scale
[ https://issues.apache.org/jira/browse/HDFS-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055157#comment-13055157 ] Hadoop QA commented on HDFS-1723: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483868/HDFS-1723-take3.txt against trunk revision 1139715. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/842//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/842//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/842//console This message is automatically generated. quota errors messages should use the same scale --- Key: HDFS-1723 URL: https://issues.apache.org/jira/browse/HDFS-1723 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 0.21.0 Reporter: Allen Wittenauer Assignee: Jim Plush Priority: Minor Labels: newbie Fix For: 0.23.0 Attachments: HDFS-1723-take1.txt, HDFS-1723-take2.txt, HDFS-1723-take3.txt A typical error message looks like this: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: The DiskSpace quota of /dir is exceeded: quota=3298534883328 diskspace consumed=5246.0g Since the two values are in difference scales and one is replicated vs. not replicated (I think), this isn't very easy for the user to understand. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1723) quota errors messages should use the same scale
[ https://issues.apache.org/jira/browse/HDFS-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055292#comment-13055292 ] Aaron T. Myers commented on HDFS-1723: -- Thanks for addressing my comments, Jim. I should have noticed this earlier, but I have one final comment and then I'll give it a +1 / commit it: Earlier in the test we're explicitly setting the quota value to 1k, so we might as well explicitly test that the output is 1.0k, rather than have a regex which will match it. We wouldn't want this test to pass if it output, for example, quota=9.5k quota errors messages should use the same scale --- Key: HDFS-1723 URL: https://issues.apache.org/jira/browse/HDFS-1723 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 0.21.0 Reporter: Allen Wittenauer Assignee: Jim Plush Priority: Minor Labels: newbie Fix For: 0.23.0 Attachments: HDFS-1723-take1.txt, HDFS-1723-take2.txt, HDFS-1723-take3.txt A typical error message looks like this: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: The DiskSpace quota of /dir is exceeded: quota=3298534883328 diskspace consumed=5246.0g Since the two values are in difference scales and one is replicated vs. not replicated (I think), this isn't very easy for the user to understand. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1723) quota errors messages should use the same scale
[ https://issues.apache.org/jira/browse/HDFS-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055323#comment-13055323 ] Hadoop QA commented on HDFS-1723: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483898/HDFS-1723-take4.txt against trunk revision 1139715. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/846//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/846//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/846//console This message is automatically generated. quota errors messages should use the same scale --- Key: HDFS-1723 URL: https://issues.apache.org/jira/browse/HDFS-1723 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 0.21.0 Reporter: Allen Wittenauer Assignee: Jim Plush Priority: Minor Labels: newbie Fix For: 0.23.0 Attachments: HDFS-1723-take1.txt, HDFS-1723-take2.txt, HDFS-1723-take3.txt, HDFS-1723-take4.txt A typical error message looks like this: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: The DiskSpace quota of /dir is exceeded: quota=3298534883328 diskspace consumed=5246.0g Since the two values are in difference scales and one is replicated vs. not replicated (I think), this isn't very easy for the user to understand. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1723) quota errors messages should use the same scale
[ https://issues.apache.org/jira/browse/HDFS-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055018#comment-13055018 ] Aaron T. Myers commented on HDFS-1723: -- Hey Jim, the patch looks pretty good. Only thing is that I don't think you should have changed the output for namespace quotas as well. The namespace quota is a count of files/directories under the relevant path, so it doesn't make much sense to represent those values in k/m/g. quota errors messages should use the same scale --- Key: HDFS-1723 URL: https://issues.apache.org/jira/browse/HDFS-1723 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 0.21.0 Reporter: Allen Wittenauer Assignee: Jim Plush Priority: Minor Labels: newbie Fix For: 0.23.0 Attachments: HDFS-1723-take1.txt, HDFS-1723-take2.txt A typical error message looks like this: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: The DiskSpace quota of /dir is exceeded: quota=3298534883328 diskspace consumed=5246.0g Since the two values are in difference scales and one is replicated vs. not replicated (I think), this isn't very easy for the user to understand. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1723) quota errors messages should use the same scale
[ https://issues.apache.org/jira/browse/HDFS-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054804#comment-13054804 ] Hadoop QA commented on HDFS-1723: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483799/HDFS-1723-take1.txt against trunk revision 1139473. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/839//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/839//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/839//console This message is automatically generated. quota errors messages should use the same scale --- Key: HDFS-1723 URL: https://issues.apache.org/jira/browse/HDFS-1723 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 0.21.0 Reporter: Allen Wittenauer Assignee: Jim Plush Priority: Minor Labels: newbie Fix For: 0.23.0 Attachments: HDFS-1723-take1.txt A typical error message looks like this: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: The DiskSpace quota of /dir is exceeded: quota=3298534883328 diskspace consumed=5246.0g Since the two values are in difference scales and one is replicated vs. not replicated (I think), this isn't very easy for the user to understand. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1723) quota errors messages should use the same scale
[ https://issues.apache.org/jira/browse/HDFS-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054817#comment-13054817 ] Hadoop QA commented on HDFS-1723: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483805/HDFS-1723-take2.txt against trunk revision 1139473. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/840//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/840//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/840//console This message is automatically generated. quota errors messages should use the same scale --- Key: HDFS-1723 URL: https://issues.apache.org/jira/browse/HDFS-1723 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 0.21.0 Reporter: Allen Wittenauer Assignee: Jim Plush Priority: Minor Labels: newbie Fix For: 0.23.0 Attachments: HDFS-1723-take1.txt, HDFS-1723-take2.txt A typical error message looks like this: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: org.apache.hadoop.hdfs.protocol.DSQuotaExceededException: The DiskSpace quota of /dir is exceeded: quota=3298534883328 diskspace consumed=5246.0g Since the two values are in difference scales and one is replicated vs. not replicated (I think), this isn't very easy for the user to understand. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
